Re: New end to end testing proposal...

2024-06-19 Thread Avik Ganguly
> > Are we keeping the existing integration tests? Or are we going to sunset > them at some point? Should people count on the integration tests? +1 I heard some talk about ~700 Cucumber Tests. Is this mostly existing integration tests wrapped with Cucumber Step Defs and Scenarios? Is it alrea

Re: New end to end testing proposal...

2024-06-14 Thread James Dailey
Devs - I believe that the cucumber test framework and approach are now accepted by the Community as per this discussion, and while this didn't go through a formal vote, I think that the discussion was sufficient and more formality on this is not needed. So, now there needs to be a wiki page or a

Re: New end to end testing proposal...

2024-05-01 Thread Ádám Sághy
Hi guys,I am happy to get involved with the new testing framework and help the acceptance of it.I believe a nice set of test case were published already that could provide as examples and ideas how things should be done.If required and I can give a try to come up with some materials which explains

Re: New end to end testing proposal...

2024-05-01 Thread James Dailey
Arnold and all- Ok. So, I'm still seeking clarification and discussion here with more voices involved in this decision. How do we avoid the pitfalls? Make this maintainable? Set expectations? Yes, we've got poorly documented code and poorly maintained things, so saying "this isn't worse" is n

Re: New end to end testing proposal...

2024-04-29 Thread Arnold Galovics
Hi James, > does this replace the integration tests? Do we do away with those? Eventually, yes. It's a process to decommission the integration tests. Now there's overlap between the int tests and the new cucumber tests. The overlapping scenarios shall be removed from the integration tests for sur

Re: New end to end testing proposal...

2024-04-26 Thread James Dailey
Arnold - does this replace the integration tests? Do we do away with those? And, for training up on Cucumber - are you willing to put an explainer together for this project here as to how it should be used specifically here on this project? James Dailey On Fri, Apr 26, 2024 at 10:13 AM Arnold

Re: New end to end testing proposal...

2024-04-26 Thread Arnold Galovics
Hi James, I'm still in support of this new testing solution. The old integration tests are very much unmaintainable, especially the ones being 2-3+ years old. To answer specifically some thoughts: > The challenge with Cucumber is that it requires new skills (e.g. new programming language Gherkin

Re: New end to end testing proposal...

2024-04-26 Thread James Dailey
Community - I would like to highlight this email thread and bring it back to top of mind for an important discussion. It is our policy and written plainly in the PR acceptance criteria: We should NOT accept a large code dump. The exception to this is if it is well discussed and a VOTE has been t

Re: New end to end testing proposal...

2024-03-25 Thread Arnold Galovics
Hi Aleks, Looks awesome, I'll take a look at the PR. Best, Arnold On Mon, Mar 25, 2024 at 6:37 AM Aleksandar Vidakovic wrote: > Hello everyone, > > ... as you know our integration tests are quite essential to ensure that > we are not breaking anything when we try to add new features or fix bug

New end to end testing proposal...

2024-03-24 Thread Aleksandar Vidakovic
Hello everyone, ... as you know our integration tests are quite essential to ensure that we are not breaking anything when we try to add new features or fix bugs. Everyone who contributed to Fineract probably saw the integration tests or even wrote one as part of their contribution. I guess you ag