Hi Courage,
Good to know the PRs are merged. I know you're busy, but Can we have a call
so that you can help with testing the scenarios?
On Fri, Dec 21, 2018 at 4:03 PM Avik Ganguly
wrote:
> Hi Courage / Ed,
>
> Yes, that PR was merged with some minor changes due to conflicts after
> rebasing
Hi Courage / Ed,
Yes, that PR was merged with some minor changes due to conflicts after
rebasing your code. The commit history should include all your changes.
There was another open PR which looked like a subset of PR #424 so I closed
that as well.
Is there a subsequent PR which needs to be
Hi Ed,
The PR was merged by Avik from this PR:
https://github.com/apache/fineract/pull/424
Avik please can you confirm that?
Thanks,
Courage
On Thu, Dec 20, 2018 at 8:52 AM Ed Cable wrote:
> Courage,
>
> It looks like that pull request wasn't actually merged.
>
> Avik, it was closed by
Courage,
It looks like that pull request wasn't actually merged.
Avik, it was closed by asfgit on Dec 13, 2017 with comments from your end.
Can you shine light on what changes Courage needs to make for PR to be
merged?
Thanks,
Ed
On Tue, Dec 18, 2018 at 7:09 AM Courage Angeh
wrote:
> Hi Ed,
Hi Ed,
Sorry for the late reply. Here is the link to the documentation used to
configure notifications for an event on Fineract.
https://mifosforge.jira.com/wiki/spaces/docs/pages/153387033/Configure+Notifications
Thanks,
Courage.
On Tue, Dec 11, 2018 at 1:46 PM Ed Cable wrote:
> Thanks for
Thanks for the update. So we can close out the ticket on JIRA? Can you
point us to the notifications framework documentation again? For some of
the ongoing work with mobile apps in the community, understanding the
points of integration is necessary.
Ed
On Tue, Dec 11, 2018 at 9:53 AM Courage
Hi Ed,
Hope this email finds you well.
My code was merged. Here is a link to one of the new files I created during
GSCOC'17:
https://github.com/apache/fineract/blob/develop/fineract-provider/src/main/java/org/apache/fineract/notification/data/TopicData.java
I will set-up my system to test the
