Re: Updates to code review guidelines : pull request size limits

2019-03-23 Thread James Dailey
Hi All - Good policy change and process clarification. +1 For transparency and to bump up this discussion, the size limit entry says: This project does not accept "code dumps" - i.e. massive huge Pull Requests of major new features consisting of thousands of lines of new code, typically

Updates to code review guidelines : pull request size limits

2019-03-22 Thread Vishwas Babu
Hi All, The PMC has recently updated the code review guidelines at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide with details of pull request size limits. Please let us know if you have any concerns regarding the same. Regards, Vishwas