[ https://issues.apache.org/jira/browse/FINERACT-232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15898891#comment-15898891 ]
ASF GitHub Bot commented on FINERACT-232: ----------------------------------------- Github user Ippezrobert commented on a diff in the pull request: https://github.com/apache/incubator-fineract/pull/302#discussion_r104605492 --- Diff: fineract-provider/src/main/java/org/apache/fineract/portfolio/savings/service/SavingsApplicationProcessWritePlatformServiceJpaRepositoryImpl.java --- @@ -446,6 +446,72 @@ public CommandProcessingResult rejectApplication(final Long savingsId, final Jso .build(); } + @Transactional + @Override + public CommandProcessingResult undoApplicationRejection(final Long savingsId, final JsonCommand command) { + this.context.authenticatedUser(); + + this.savingsAccountApplicationTransitionApiJsonValidator.validateForUndo(command.json()); + + final SavingsAccount savingsAccount = this.savingAccountAssembler.assembleFrom(savingsId); + checkClientOrGroupActive(savingsAccount); + + final Map<String, Object> changes = savingsAccount.undoApplicationRejection(); + if (!changes.isEmpty()) { + this.savingAccountRepository.save(savingsAccount); + + final String noteText = command.stringValueOfParameterNamed("note"); + if (StringUtils.isNotBlank(noteText)) { + final Note note = Note.savingNote(savingsAccount, noteText); + changes.put("note", noteText); + this.noteRepository.save(note); + } + } + + return new CommandProcessingResultBuilder() // + .withCommandId(command.commandId()) // + .withEntityId(savingsId) // + .withOfficeId(savingsAccount.officeId()) // + .withClientId(savingsAccount.clientId()) // + .withGroupId(savingsAccount.groupId()) // + .withSavingsId(savingsId) // + .with(changes) // + .build(); + } + + @Transactional + @Override + public CommandProcessingResult reopen(final Long savingsId, final JsonCommand command) { --- End diff -- @nazeer1100126 , These changes will only be possible if the issues https://issues.apache.org/jira/browse/FINERACT-232 and https://issues.apache.org/jira/browse/FINERACT-408 are implemented and those are more technical for me. > Ability to Post General Ledger Entries Directly to Customer Account > ------------------------------------------------------------------- > > Key: FINERACT-232 > URL: https://issues.apache.org/jira/browse/FINERACT-232 > Project: Apache Fineract > Issue Type: Improvement > Reporter: Dayna Harp > Assignee: Markus Geiss > Attachments: Complete New UI Mock up for Journal Entry Screen.png, > Enhancements for Journal Entry.pdf > > > https://mifosforge.jira.com/browse/MIFOSX-2182 > From MIFOS X: As an accountant, i would like to be able to make a transfer > from a client's account (Savings Account or Loan Account) to a GL Account and > also be able to make transfer from a GL Account (e.g Cash at Hand) to > Client's Account (e.g Savings Account or Loan Account) -- This message was sent by Atlassian JIRA (v6.3.15#6346)