[GitHub] [incubator-flagon-useralejs] confusingstraw commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
confusingstraw commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-80702 @poorejc @UncleGedd I will try to keep this sane. 1. I don't think Web Workers help us very much, as [the spec](https://www.w3.org/TR/workers/)

[GitHub] [incubator-flagon-useralejs] UncleGedd edited a comment on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd edited a comment on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806951761 Gotcha. I was able to get this journey test passing consistently, we can also add a "retry" option to cypress where it'll attempt the test a couple times if

[GitHub] [incubator-flagon-useralejs] UncleGedd edited a comment on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd edited a comment on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806951761 Gotcha. I was able to get this journey test passing consistently, we can also add a "retry" option to cypress where it'll attempt the test a couple times if

[GitHub] [incubator-flagon-useralejs] UncleGedd commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806951761 Gotcha. I was able to get this journey test passing consistently, we can also add a "retry" option to cypress where it'll attempt the test a couple times if it

[GitHub] [incubator-flagon-useralejs] poorejc commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
poorejc commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806930053 > No problem! Also, welcome @kevbrowndev! > > Regarding the other failing unit test: > > ```js > it('sends logs on page exit without navigator', () =>

[GitHub] [incubator-flagon-useralejs] UncleGedd commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806919414 No problem! Also, welcome @kevbrowndev! Regarding the other failing unit test: ```js it('sends logs on page exit without navigator', () => { //

[GitHub] [incubator-flagon-useralejs] poorejc commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
poorejc commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806908863 > Ok, so I've tried writing a cypress/journey test for `sendBeacon` and it's pretty flaky, but manual testing works in the browser (Chrome) consistently though

[GitHub] [incubator-flagon-useralejs] poorejc commented on issue #72: NPM deployment automatically starts regardless of usage

2021-03-25 Thread GitBox
poorejc commented on issue #72: URL: https://github.com/apache/incubator-flagon-useralejs/issues/72#issuecomment-806885224 That's a good ticket. So far haven't heard much concern from the users I'm connected with, but they were expecting this behavior. Maybe should add something to

[GitHub] [incubator-flagon-useralejs] kevbrowndev commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
kevbrowndev commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806866064 Fwiw, I've seen the exact same thing. Frustrating! On Thu, Mar 25, 2021, 8:41 AM UncleGedd ***@***.***> wrote: > Ok, so I've tried writing a

[GitHub] [incubator-flagon-useralejs] UncleGedd edited a comment on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd edited a comment on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806668259 Ok, so I've tried writing a cypress/journey test for `sendBeacon` and it's pretty flaky, but manual testing works in the browser (Chrome) consistently

[GitHub] [incubator-flagon-useralejs] UncleGedd commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806668259 Ok, so I've tried writing a cypress/journey test for `sendBeacon` and it's pretty flaky. It does work in the browser (Chrome) consistently though -- This is an

[GitHub] [incubator-flagon-useralejs] UncleGedd commented on issue #50: sendOnClose function broken -- logs dropped when users navigate away from page

2021-03-25 Thread GitBox
UncleGedd commented on issue #50: URL: https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-806553427 I don't think we are going to be able to send an HTTP request in those page unload event handlers, see this [SO