poorejc commented on issue #50:
URL:
https://github.com/apache/incubator-flagon-useralejs/issues/50#issuecomment-805452663
@UncleGedd are you open to helping me test this out a bit? I'm digging into
this one tomorrow night, but if you're into it, I would love some more testing
on this
poorejc commented on pull request #69:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/69#issuecomment-805446394
Merged earlier PRs, but want to test the new build pipeline on updated test
branch. Will test and review tomorrow thanks again @UncleGedd
--
This is an
asfgit merged pull request #64:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
asfgit closed issue #63:
URL: https://github.com/apache/incubator-flagon-useralejs/issues/63
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
poorejc commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805436438
> personally, im not terribly sure of the value of it at all. @poorejc
probably has more context, but it being in the extension build _seems_
pointless, as the
poorejc opened a new issue #71:
URL: https://github.com/apache/incubator-flagon-useralejs/issues/71
current method is 'detect-browser'. Adds run-time dependencies (overhead).
explore more modern fingerprinting methods as alternative:
example of such a library:
Finally, got around to really testing and messing around with cypress. I’m flat
out in love with these things. I definitely think these are going to be very
important for our sendOnClose behavior…
GREAT PR—have merged to test.
> On Mar 17, 2021, at 10:36 AM, Joshua Poore wrote:
>
> No
dependabot[bot] closed pull request #68:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries
dependabot[bot] commented on pull request #68:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/68#issuecomment-805415509
Looks like rollup is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the
asfgit merged pull request #61:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this
confusingstraw edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805222334
personally, im not terribly sure of the value of it at all. @poorejc
probably has more context, but it being in the extension build _seems_
confusingstraw commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805222334
personally, im not terribly sure of the value of it at all. @poorejc
probably has more context, but it being in the extension build _seems_
pointless, as
UncleGedd edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805056097
Regarding `detect-browser`, @confusingstraw do you know of an elegant way to
get around using that dependency? How do you feel about just using the user
UncleGedd commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805056097
Regarding `detect-browser`, @confusingstraw do you know of an elegant way to
get around using that dependency? How do you feel about just using the user
UncleGedd edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805043818
Very nice! I also noticed that we weren't transpiling in our builds and
thought it was odd. Glad it was an easy fix!
--
This is an automated message
UncleGedd commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-805043818
Very nice! I also noticed that we weren't transpiling in our builds and
thought it was odd. Glad it was a easy fix!
--
This is an automated message from the
confusingstraw edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804985422
ah, seems like you are right. i think it is because we only use babel in our
testing, not our building.
i just went down a rabbit hole
confusingstraw commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804985422
ah, seems like you are right. i think it is because we only use babel in our
testing, not our building.
i just went down a rabbit hole trying to
UncleGedd edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804943594
The changes in the build files are the result of running the build script
before final testing. I guess Rollup decided to do something a little
UncleGedd edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804943594
The changes in the build files are the result of running the build script
before final testing. I guess Rollup decided to do something a little
UncleGedd edited a comment on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804943594
The changes in the build files are the result of running the build script
before final testing. I guess Rollup decided to do something a little
UncleGedd commented on pull request #70:
URL:
https://github.com/apache/incubator-flagon-useralejs/pull/70#issuecomment-804943594
The changes in the build files are the result of running the build script
before final testing. I guess Rollup decided to do something a little different
with
UncleGedd opened a new pull request #70:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/70
# Updates Variable Declarations to ES6 syntax
A todo in the codebase was to change `var` to `let` (see
UncleGedd opened a new pull request #69:
URL: https://github.com/apache/incubator-flagon-useralejs/pull/69
# Refactors Gulp, [issue #
67](https://github.com/apache/incubator-flagon-useralejs/issues/67)
I have done this work using both Webpack and Rollup, and Rollup is by far
the
24 matches
Mail list logo
