[DISCUSS] What Reviews Required-or-Needed / When OK to merge?
Hi Flagon-Dev, Do we have a Flagon community standard for when OK to merge a PR? Inviting us to have a discussion, and to get consensus around community standards for reviewing PRs/when-OK-to-Merge. Apologies if I missed a prior discussion/doc on this topic. I assume we ultimately need a committer to review the work of a non-committer ahead of merge ( since someone with permissions eventually has to actually accept/merge/commit the code ). In general, is one reviewer/committer sufficient? How does this change if the author of the PR is an existing committer? I have seen some communities require a committee to review things ( no matter the status of the author), and others require anyone else -- so that's more of a community determination. For example, could also be a judgement call as to whether to tag in the expertise of someone having great depth on a specific component, or just some eyeballs for sanity check. Hoping we can try to be *somewhat* specific [ where possible ] about the sort of expected requirements, and our standards. A result of the discussion likely will be things that can be summarized and used for updating http://flagon.incubator.apache.org/docs/contributing/ And, naturally there are exceptions ( ex: very large commits, when functionality significantly altered [ such a case could warrant a FIP / Flagon-Improvement-Proposal ], etc ). And, exception in the other direction -- how sufficiently small to be OK merging without another reviewer [ of any kind ]? Thanks, Austin
[GitHub] [incubator-flagon] brucearctor commented on pull request #25: typos
brucearctor commented on PR #25: URL: https://github.com/apache/incubator-flagon/pull/25#issuecomment-1155626110 @UncleGedd -- I think I'll take that to dev list, so we have an archive of a discussion/resolution of when OK to merge. We should formalize general community conventions. Thinking ahead to potential community growth ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-flagon] brucearctor merged pull request #25: typos
brucearctor merged PR #25: URL: https://github.com/apache/incubator-flagon/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [incubator-flagon] UncleGedd commented on pull request #25: typos
UncleGedd commented on PR #25: URL: https://github.com/apache/incubator-flagon/pull/25#issuecomment-1155623184 LGTM Sorry for the slow response on this @brucearctor. I'd recommend making a PR for all changes to solicit community feedback. That said, on small changes like this you can use your best judgement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@flagon.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
