Re: Roll-Call for Apache Flagon

2023-10-21 Thread Rob Foley
I am still willing to contribute, though most of my contributions are more on the legacy side at this point. Rob On 10/21/2023 12:26 PM, jason_y54 wrote: Hey Chris, I’m also willing and able. - Jason On Sat, Oct 21, 2023 at 10:45 AM, Evan Jones <[evan.a.jon...@gmail.com](mailto:On Sat,

Re: Web Extension updates

2022-09-02 Thread Rob Foley
I don't recall enough about our initial browser compatibility list, but, if we haven't yet already deprecated IE support, this will do it. For the sake of correctness, |fetch| isn't a protocol, it is just a browser API. Both the |fetch| and |XMLHttpRequest| APIs will make essentially the same

Re: [DISCUSS] What Reviews Required-or-Needed / When OK to merge?

2022-06-24 Thread Rob Foley
I don't have a strong opinion on this but, in my experience, having one reviewer ought to be sufficient assuming they are familiar with the code-to-be-changed. I don't believe committers should be able review their code outside of extraordinary circumstances, such as a very high priority

Potential relevant Mozilla add-on policy changes

2021-11-09 Thread Rob Foley
I received an automated notification on my personal email regarding this policy change: https://blog.mozilla.org/addons/2021/11/03/add-on-policy-changes-2021/ I don't think Flagon would be too adversely affected, but some of the bullets do apply. Here are the main changes: - Collecting

Re: [DISCUSS] Weak/Strong Cypress Integration/Examples for UserALE.js

2021-03-17 Thread Rob Foley
Evidently I did not hit "submit review". Really killing it. On 3/16/2021 9:05 PM, Joshua Poore wrote: Rob—Sorry, I was just digging into it and I didn’t see your review or feedback. is your new handle added to apache-git? PM me if you want about this. On Mar 16, 2021, at 10:36 AM,

Re: [DISCUSS] Weak/Strong Cypress Integration/Examples for UserALE.js

2021-03-16 Thread Rob Foley
Added some feedback to the PR, looks good though. I think that there is a lot of room for useful Cypress tests to automate what is likely a very manual process at the moment. A bespoke branch is probably the right option (imo). Rob On 3/15/2021 2:01 PM, Joshua Poore wrote: Starting new

Re: Introduction @UncleGedd

2021-03-15 Thread Rob Foley
le? We can continue discussion on another thread. Josh On Mar 14, 2021, at 1:09 PM, Rob Foley wrote: Hi Gedd, Thanks for contributing. If you have any questions about Userale or any of its design decisions, feel free to reach out. Ditto on the Zoom/etc. front. @poorejc wrt Cypress, I've gotten a

Re: Introduction @UncleGedd

2021-03-14 Thread Rob Foley
Hi Gedd, Thanks for contributing. If you have any questions about Userale or any of its design decisions, feel free to reach out. Ditto on the Zoom/etc. front. @poorejc wrt Cypress, I've gotten a decent bit of experience writing Cypress tests in the last year or so. I don't quite see (at

Re: [VOTE] Release Apache Flagon UserALE.js (Incubating) 2.1.1

2021-02-21 Thread Rob Foley
+1 On Sun, Feb 21, 2021 at 12:38 PM Joshua Poore wrote: > +1 (non-binding, Flagon PPMC) > > > On Feb 21, 2021, at 12:34 PM, Laura Mariano > wrote: > > > > +1 > > > > On Sat, Feb 20, 2021 at 9:06 PM Joshua Poore wrote: > > > >> Hi Folks, > >> > >> Please VOTE on the Apache Flagon UserALE.js

Re: [VOTE] Release Apache Flagon UserALE.js (Incubating) 2.1.0

2020-02-14 Thread Rob Foley
A bit late, but +1: [x] Build and Unit Tests Pass [x] DISCLAIMER, LICENSE, and NOTICE Files in Source and Binary Release Packages [x] Signatures and Hashes Match Keys [x] CHANGELOG included with release distribution On Mon, Feb 10, 2020 at 9:14 PM Joshua Poore wrote: > pushed updated

[jira] [Commented] (FLAGON-464) Figure out how to include PlotLy and Dash

2019-10-04 Thread Rob Foley (Jira)
[ https://issues.apache.org/jira/browse/FLAGON-464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944659#comment-16944659 ] Rob Foley commented on FLAGON-464: -- It should be a fairly straightforward integration in terms

Re: Unit Tests Behaving Oddly on new Session Id Storage feature

2019-09-12 Thread Rob Foley
ext of > getInitialSettings it looks like we get an error specific to > sessionStorage. I’ve tried pulling in some add’l npm packages meant to > define storage elements, but haven’t had success yet. Then again, haven’t > had bandwidth to try really hard yet. > > > > Thanks Rob. Mor

Re: Unit Tests Behaving Oddly on new Session Id Storage feature

2019-08-12 Thread Rob Foley
I looked through the branch/issue and tried playing around with the code a bit. It seems like the userale script is not being added to the JSDom environment. Our custom resourceLoader (found in test/testUtils.js) is being ran, and is getting the correct content, however at some point JSDom is not

Re: [jira] [Closed] (FLAGON-437) not capturing click events inside iframe

2019-08-06 Thread Rob Foley
s actively discouraging its misuse, but that would likely only discourage those who had no ill intentions anyways. Rob On Tue, Aug 6, 2019 at 5:47 PM Rob Foley (JIRA) wrote: > > [ > https://issues.apache.org/jira/browse/FLAGON-437?page=com.atlassian.jira.plugin.system.issuetab

[jira] [Commented] (FLAGON-435) TabID to attach handlers

2019-08-05 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16900151#comment-16900151 ] Rob Foley commented on FLAGON-435: -- If the idea is "attach script tag to the tab with this id"

Re: [VOTE] Release Apache Flagon (Incubating) 2.0.1

2019-08-01 Thread Rob Foley
+1 On Thu, Aug 1, 2019, 4:40 PM Furkan KAMACI wrote: > Hi, > > +1 from me. > > I checked: > - Incubating in name > - Disclaimer exists > - LICENSE is fine > - NOTICE is fine > - No unexpected binary files > - Code compiles and tests successfully run > > On the other hand, I've tried to run

[jira] [Commented] (FLAGON-395) Add ability to send data via Sockets (as opposed to POST)

2019-06-13 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16863082#comment-16863082 ] Rob Foley commented on FLAGON-395: -- Why not just use vanilla WebSockets? There shouldn't be too great

Re: VOTE (Re)Release Apache FLAGON UserALE.js (Incubating) 1.0.0

2019-06-13 Thread Rob Foley
+1 On Wed, Jun 12, 2019 at 11:36 PM Joshua Poore wrote: > Hi Folks, > > Mentors say safe bet is to do re-release of UserALE.js 1.0.0 under strict > release process. As such I am calling a VOTE: > > Please VOTE on the Apache FLAGON UserALE.js 1.0.0 Release Candidate #3. > > We solved 50 issues:

[jira] [Comment Edited] (FLAGON-394) Latency Between Funnel Elements (Kibana)

2019-06-11 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861648#comment-16861648 ] Rob Foley edited comment on FLAGON-394 at 6/12/19 1:05 AM: --- Ahh, so

[jira] [Commented] (FLAGON-394) Latency Between Funnel Elements (Kibana)

2019-06-11 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861648#comment-16861648 ] Rob Foley commented on FLAGON-394: -- Ahh, so is this intended as a potential alternative to the bowie viz

[jira] [Commented] (FLAGON-296) UserALE should be able to detect if there is Restricted Content

2019-06-10 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860153#comment-16860153 ] Rob Foley commented on FLAGON-296: -- This may be difficult/not plausible. A server might just return

[jira] [Commented] (FLAGON-394) Latency

2019-06-10 Thread Rob Foley (JIRA)
[ https://issues.apache.org/jira/browse/FLAGON-394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16860148#comment-16860148 ] Rob Foley commented on FLAGON-394: -- What's a funnel element? Is this NiFi slang? > Late