Re: [ApacheCon/FlexJS Summit] FlexJS 1.0 Discussion Round - Summary

Peter, If u can give me few pointers then I am willing to work on this. One more point, right now I am not a flexjs contributer. Since one year I am using flexjs and creating demos so that I can get good grip on it. Now I am having free time and want to contribute to FlexJS. So What are the

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Well, it is strange that is empty, but that doesn't seem to be problem. Still looking. -Alex On 5/24/17, 4:47 PM, "Alex Harui" wrote: >I have to stop for kids and dinner, but I noticed that in >target/compile-app-config.xml, the is empty. It should be >populated

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I have to stop for kids and dinner, but I noticed that in target/compile-app-config.xml, the is empty. It should be populated similar to frameworks/flex-config.xml. On 5/24/17, 4:19 PM, "piotrz" wrote: >I just go to the examples\express\DataBindingExample\ and run

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just go to the examples\express\DataBindingExample\ and run mvn clean install and got different error [1]. Once I add Effects module to pom it started to build for me locally. I never got error which is on Jenkins. https://paste.apache.org/P0qC Piotr - Apache Flex PMC

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

How do we reproduce the error? On 5/24/17, 4:07 PM, "piotrz" wrote: >Ok It didn't help. I tried couple of options, but ended up with solution >above where Effects has been added to DataBindingExample. - That was for >sure one of the issue, but in general didn't fix. >

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Ok It didn't help. I tried couple of options, but ended up with solution above where Effects has been added to DataBindingExample. - That was for sure one of the issue, but in general didn't fix. The strange thing is that after several builds of framework locally finally I was able to build

Contributions / SonarCube (was odd headers)

Hi, > Absolutely want to see more discussion about the 9 or 13 points from > ApacheCon. I don't agree that discussing trace statements, inlining > constants, and empty constructors will bring in more contributors. > Getting quality releases out encourages more contributors. Well actually the

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just found cause of failing Express DataBindingExample on Maven build and pushed fix! Cause of this issue was that the "Express" module is using class from "Effects" -> default.css -> ClassReference("org.apache.flex.core.StatesWithTransitionsImpl"); but in Express's pom.xml there is no

Re: [FlexJS] odd license headers on some files

Your changes look good to me. Onward! - Josh On Wed, May 24, 2017 at 2:53 PM, Justin Mclean wrote: > HI, > > Changes made and committed. > > There were about 50 files as there was some noise form 3rd party files > when I did a grep looking for the issue. I did not

Re: [FlexJS] odd license headers on some files

HI, Changes made and committed. There were about 50 files as there was some noise form 3rd party files when I did a grep looking for the issue. I did not alter the header of any 3rd party file. I believe I know what the issue is here. The text for the Apache license contains some text for

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, Still cannot find cause. I cleaned my .m2\repository\org\apache\flex\flexjs\framework\ and found one more place where Font.swf is mentioned - distribution\src\main\assembly\component.xml I commented following code: But it still failing. Paste is from the second attempt after

Re: [FlexJS] odd license headers on some files

On 5/24/17, 1:35 PM, "Dave Fisher" wrote: >Alex - are we really close to cutting a release? Every day, I keep hoping I'm about to fix the last big bug, only to find that something else big. Apparently only now are folks testing some parts of the Maven build and there

Re: [FlexJS] odd license headers on some files

Hi, > I had a great time meeting most of you last week. Alex I met some 3 years ago. Good to meet you in person as well. > Justin can you please provide a precise diff explaining what is off with > these headers? They are missing this bit: Licensed to the Apache Software Foundation (ASF)

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

On 5/24/17, 1:32 PM, "Christofer Dutz" wrote: >If you had built it before it will still find it. Even if you have >internet access. Then it will download the snapshot. The only time it >should fail is if you build it outline with an empty repo. Unless it's >not

Re: [FlexJS] odd license headers on some files

Hi Folks, I had a great time meeting most of you last week. Alex I met some 3 years ago. Justin can you please provide a precise diff explaining what is off with these headers? Also how many files. Alex - are we really close to cutting a release? Regards, Dave Sent from my iPhone > On May

Re: [FlexJS] odd license headers on some files

Hi, > How does fixing these headers help the community? In short -by giving the ASF board and users confidence that they can use our software without any legal issues. > each of us will now have to take time to make sure we have the right > header before committing new files. And if you miss

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

If you had built it before it will still find it. Even if you have internet access. Then it will download the snapshot. The only time it should fail is if you build it outline with an empty repo. Unless it's not bundled in the dist. Then it shouldn't fail at all. Chris Von meinem Samsung

Re: [FlexJS] odd license headers on some files

On 5/24/17, 10:35 AM, "Josh Tynjala" wrote: >Alex, > >If Justin were proposing these changes to an RC, I would strongly agree >with you that it should wait. However, I thought we all agreed that Last >Call was the better time to get things in that we want to get in. It

Re: [FlexJS] odd license headers on some files

Hi, > but as we're still in Last Call, I'm going to defend him. Thanks for that. > I understand that you think licensing details aren't as important as other > things The PMC as a whole was a responsible to get the licensing stuff right and while some people may not think it is important

RE: Flex SDK Patch

Created the issue and attached the patch file: https://issues.apache.org/jira/browse/FLEX-35312 Am I doing this correctly? -Original Message- From: Jason Taylor [mailto:ja...@dedoose.com] Sent: Wednesday, May 24, 2017 11:59 AM To: dev@flex.apache.org Subject: Flex SDK Patch Hi, I

Re: [FlexJS] hard coded event names

Hi, > I was under the assumption that every constant adds an alias to the output. That doesn’t seem to be the case as the compiler can optimise this - that’s a good think. Leet like get to make a cake and eat it. > But again, I'd prefer that we don't spend time on this topic until after the >

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just ran: mvn -P build-distribution clean install And was successful. Am I still not doing the right thing? -Alex On 5/24/17, 12:20 PM, "Christofer Dutz" wrote: >Well Fonts.SWF is the file that is no longer generated due to my "fix" I >did during the

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Well Fonts.SWF is the file that is no longer generated due to my "fix" I did during the discussion round. But it's strange that it's failing as I did a search for usages. But it should be fixable by commenting it out in the distribution xml files. Chris Von meinem Samsung Galaxy Smartphone

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just tried Maven distribution with fresh sources and it's failing on Fonts.swf. [1] Not sure why actually. I will try to dig into that. [1] https://paste.apache.org/6nLJ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Flex SDK Patch

Hi, I created a patch file for a few minor changes to the FlexSDK to address a memory leak in GridViewLayout. GridViewLayout uses a strong dictionary for caching items, and under many circumstances this cache isn't properly cleared. The patch coverts the dictionaries to weak dictionares and

Re: [FlexJS] odd license headers on some files

Alex, If Justin were proposing these changes to an RC, I would strongly agree with you that it should wait. However, I thought we all agreed that Last Call was the better time to get things in that we want to get in. It feels to me like you're moving the goal posts to now say that it should wait

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi Alex, That only builds the libraries, not the examples. And it doesn't test, if the examples work. The failures come from the examples and not the libs. So that won't be detected. Anyway Jenkins now builds the release and that doesn't work at the moment because of these problems. Nothing

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

On 5/24/17, 5:10 AM, "Christofer Dutz" wrote: >Unfortunately, this also demonstrates the failures I was getting locally. >I guess no one really tested the release branch with maven yet, which >makes me sad :-( Mvn clean install in the release branches for

Re: [FlexJS] odd license headers on some files

Technically, I am not blocking. I am saying that there is a better time to do this change and we need to focus on the big picture and spend energy on things that matter. This topic could have been as simple as an email from Justin that said "hey, I just noticed we have inconsistent headers. I

Re: [FlexJS] trace statements in SDK code

I don't think you get my point, but let's discuss further after the release. Thanks, -Alex On 5/23/17, 3:03 PM, "Justin Mclean" wrote: >Hi, > >> Interesting topic. Is this something that folks think is important for >> this release? > >Again IMO no need to hold up

Re: [FlexJS] hard coded event names

Again, interesting topic, but maybe table it until after the release? I was under the assumption that every constant adds an alias to the output. Otherwise data binding to constants would not work after variable renaming. But again, I'd prefer that we don't spend time on this topic until after

Re: [FlexJS] Compiler doesn't recognize reserved JS words like 'enum'

In ES5, there were two changes. As you said, they removed some items from the list of reserved words. Also, all reserved words are now allowed to be used for certain names. As I recall, this includes names of members, but not names of local variables. If enum is still considered reserved in ES,

Re: [FlexJS] odd license headers on some files

The thing is, I can’t see that file in my repo … I think you only have this when installing a Flex(JS)SDK with AIR. So eventually if you ran an Ant build, this is probably there. Chris Am 24.05.17, 15:39 schrieb "Josh Tynjala" : If it's ANE-related, it seems

Re: [FlexJS] odd license headers on some files

If it's ANE-related, it seems likely that it's from an AIR SDK. - Josh On May 23, 2017 10:47 PM, "Alex Harui" wrote: On 5/23/17, 3:17 PM, "Justin Mclean" wrote: >Hi, > >> Agreed. Justin is good at catching licensing issues, and he seems

Re: [FlexJS] odd license headers on some files

Alex, by continuing to block Justin, you're making this exactly the kind of grind that you've said we should avoid. If you just said "okay cool, make the change!" that's painless and won't discourage any potential release managers. - Josh On May 23, 2017 9:52 PM, "Alex Harui"

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, I will be looking into this later today if you will not beat me. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/LAST-CALL-Release-FlexJS-FalconJX-0-8-0-tp61275p61843.html Sent from

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, It is true that I'm checking only couple of examples after build of SDK. Sorry about that I will be more careful next time with checking and do all the tests! Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi Piotr, I guess the difference is that I always build with examples and distribution and integration-tests. As I know lacking a unit-test suite checking the running examples is somewhat the only test-like thing we currently have. So, if you run with examples, you will probably get the same

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, I'm using release branch and building everything from Falcon, through typedefs ("develop" branch) daily, so not sure why you end up with such problems. - I didn't have it. Today also one more person build FlexJS from this branch and we had two issues: 1) With font compilation - Once we

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Ok … so I was to bold to just create the missing branch for the typedefs repo … now the autobuild worked … well let’s say it started doing its job. I changed the configuration for the auto-build jog to automatically build release branches too (even if I would like to suggest a more

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Would it be ok to cut a release branch with the same name for the typedefs? Right now the Jenkinsfile which handles the auto-build-branch stuff requires all three repos to have matching branches. Chris Am 24.05.17, 12:59 schrieb "Christofer Dutz" : I just merged

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi Chris, Can you try to do two buildings: 1) Where SWF 2) Where JSFlex Just to expose which one is actually have problems. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

I just merged my changes to release and currently can’t build the examples due to this error: [INFO] --- flexjs-maven-plugin:0.8.0-SNAPSHOT:compile-app (default-compile-app) @ DataBindingExample-Express --- [INFO] Executing MXMLC in tool group FlexJS with args:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

It shouldn’t have anything to do with that, because my fixes just fine-tuned things there. Chris Am 24.05.17, 10:41 schrieb "Justin Mclean" : Hi, I’m unable to compile the FlexJS nightly release using maven. A “mvn -X clean compile” gives:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi, I’m unable to compile the FlexJS nightly release using maven. A “mvn -X clean compile” gives: [ERROR] The build could not read 1 project -> [Help 1] org.apache.maven.project.ProjectBuildingException: Some problems were encountered while processing the POMs: [ERROR] Child module

Re: [ApacheCon/FlexJSSummit] Just registered...

The link :) https://twitter.com/ApacheFlex/status/867286702016036864 El 24 de mayo de 2017, 9:53, Carlos Rovira escribió: > Just posted on tweeter. > Please retweet to spread the word!! :) > > 2017-05-23 20:50 GMT+02:00 piotrz : > >> I

Re: [FlexJS] Compiler doesn't recognize reserved JS words like 'enum'

Josh Tynjala wrote > As I mentioned in my previous post, JavaScript started > allowing reserved words in places where they couldn't be used before with > ES5. Since AS3 is derived from ECMAScript, it's pretty safe for us to do Hi Josh, maybe I get something wrong once again or I miss something

Re: [ApacheCon/FlexJSSummit] Just registered...

Just posted on tweeter. Please retweet to spread the word!! :) 2017-05-23 20:50 GMT+02:00 piotrz : > I think it should be posted on our Twitter and Facebook! :) > > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

On 5/23/17, 11:28 PM, "piotrz" wrote: >Alex, > >Are you saying that I don't have to have environment variable set for type >defs and script should take over this ? That's the way it looks for me. I think the only environment variables needed are

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Chris, I think that we should have your fixes from develop. I just got report from someone who tried build flexjs on clean pc and without your fixes failed on this font problems. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Alex, Are you saying that I don't have to have environment variable set for type defs and script should take over this ? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

On 5/23/17, 10:45 PM, "piotrz" wrote: >Hi, > >I just tried to go through the ApproveFlexJS.xml script and end up on >following building problem [1]. I point fresh download by installer to >FlexJS folder where there is flex-typedefs/js/target/, but I don't see >inside

Re: [LAST CALL] Release FlexJS/FalconJX 0.8.0

Hi, I just tried to go through the ApproveFlexJS.xml script and end up on following building problem [1]. I point fresh download by installer to FlexJS folder where there is flex-typedefs/js/target/, but I don't see inside js.swc. - Is this a bug ? Apart of that I examined Readme.txt and for the