Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-27 Thread Justin Mclean
Hi, > The compiler, the language, and the Flash runtime are all designed to > prevent you from making silly mistakes, so I think the best practice is t > define data classes. I've even considered adding a warning that detects > use of plain object. . Sonar Cube can do that for you - for instance

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-27 Thread Alex Harui
Well, it may be just me, but I have the opposite thought... IMO, instead of bracket access, we should take the time to create ValueObjects for each of the data structures used in the ASDoc example. I'm not even quite sure how to do #2 without blindly preventing renames of all uses of the

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Harbs
That’s probably it. It really needs bracket access. Alex, if you are looking for a task in the compiler, here’s a suggestion that would drastically reduce bugs in minified apps: 1. For all untyped objects, dot notation should be rewritten to bracket notation: var myObj:Object = myArr[idx];

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Alex Harui
You can grab the JSON files from the Jenkins server, but the Ant build should also build them. My guess is that the code isn't finding properties from the JSON objects because GCC renamed the properties. -Alex On 9/26/17, 2:25 PM, "Harbs" wrote: >I can’t test because

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Harbs
I can’t test because I’m missing the json files and I’m not sure how to generate them. Looks like some binding problem probably due to renaming. The json files appear to be loading correctly from the web. > On Sep 26, 2017, at 11:41 PM, Alex Harui wrote: > > Feel

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Alex Harui
Feel free to take a investigate. Peter's old ASDoc page points to the js-debug version. It loads slowly some times, but at least it is functional. I'd rather work on other things right now than chasing down a js-release problem. -Alex On 9/26/17, 1:36 PM, "Harbs"

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Harbs
FWIW, the debug version is working, but the release version does not appear to work: http://apacheflexbuild.cloudapp.net:8080/job/FlexJS_ASDoc_Example/lastSuccessfulBuild/artifact/examples/flexjs/ASDoc/bin/js-release/index.html

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Alex Harui
If I understand the problem (which I'm not sure, since the fix you posted runs code if not Safari), you could create a OneFlexibleChildLayoutWithSafariXSupport and put your fixes with browser sniffing in there. That way folks who don't need it, don't pay for the sniffing. There might be a

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Harbs
I’m showing how to fix the “non-ForOverflow” layouts. The problem is that Safari handles flex layouts differently than other browsers. I’d like to use the flexbox layouts and AFAICT, they need browser sniffing to work across the board. Ideally, the browser sniffing should be included in the

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Alex Harui
I'm not sure if you have the exact same problem as ASDoc, but the ASDoc example is working fine with the "ForOverflow" layouts and no extra code in the app. Or are you saying ASDoc isn't working for you on some browser? IMO, that's the whole point of having many different flavors of layouts.

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-09-26 Thread Harbs
I ran into the Safari problem in my app. I needed to add code like this: var info:BrowserInfo = BrowserInfo.current(); if(info.browser != "Safari" && info.formFactor.indexOf("iP") == -1){ outerContainer.percentHeight = 100; leftResizeThumb.percentHeight = 100; } The components

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-07-31 Thread Harbs
The only example I found was the ASDoc app. I switched it and it appears to work. (I pushed my changes.) > On Jul 31, 2017, at 7:35 AM, Alex Harui wrote: > > It will either work in the examples that use it or it won't. Try it and > find out. > > -Alex > > On

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-07-30 Thread Alex Harui
It will either work in the examples that use it or it won't. Try it and find out. -Alex On 7/30/17, 3:04 AM, "Harbs" wrote: >I think I just ran into the same issue. > >This layout seems to more-or-less do the job, but it’s kind of heavy. > >I did some research into

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-07-30 Thread yishayw
Here's a test app [1] that demonstrates it. [1] https://paste.apache.org/i5Ui -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Re-07-13-git-commit-flex-asjs-refs-heads-release0-8-0-give-up-on-trying-to-use-FlexBox-for-full-scred-tp63598p63599.html Sent

Re: [07/13] git commit: [flex-asjs] [refs/heads/release0.8.0] - give up on trying to use FlexBox for full-screen 3-pane views. FlexBox seems more happy stretching to content size instead of clipping a

2017-07-30 Thread Harbs
I think I just ran into the same issue. This layout seems to more-or-less do the job, but it’s kind of heavy. I did some research into flexbox and it appear that setting flex-basis to 0 does the job. It needs to be set on ONLY the one flexible child. Here’s a codepen which shows a use case.