Re: [2/2] git commit: [flex-sdk] - Added single digit day and month tests. Fixed broken tests (state remembers date format). Two test currently fail bitmaps as different error is show. Not clear what

2013-04-26 Thread Justin Mclean
HI, Thanks for grinding through these. But are you saying if I run these tests I will get failures. 2 tests report bit map failure but the tests themselves pass. Issue is that only one error is displayed when there could actually be more than one so in a way the test were wrong but and

Re: [2/2] git commit: [flex-sdk] - Added single digit day and month tests. Fixed broken tests (state remembers date format). Two test currently fail bitmaps as different error is show. Not clear what

2013-04-26 Thread Justin Mclean
Hi, I don't like the sound of this. So fix them :-) We should either fix them or comment then out. The issues I see with commenting them out is that: a) they may be forgotten about b) unrun test may hide other introduced issues. c) It may encourage other people to fix them Justin

Re: [2/2] git commit: [flex-sdk] - Added single digit day and month tests. Fixed broken tests (state remembers date format). Two test currently fail bitmaps as different error is show. Not clear what

2013-04-26 Thread OmPrakash Muppirala
On Apr 26, 2013 7:06 PM, Justin Mclean jus...@classsoftware.com wrote: Hi, I don't like the sound of this. So fix them :-) Sure, I would fix it by commenting it out :-) We should either fix them or comment then out. The issues I see with commenting them out is that: a) they may be

Re: [2/2] git commit: [flex-sdk] - Added single digit day and month tests. Fixed broken tests (state remembers date format). Two test currently fail bitmaps as different error is show. Not clear what

2013-04-26 Thread Justin Mclean
HI, Why not add a detailed JIRA ticket for this so that we don't forget this? There's an existing JIRA issue. I will get around to trying to fixing it in the next week - unless someone else does. Justin

Re: [2/2] git commit: [flex-sdk] - Added single digit day and month tests. Fixed broken tests (state remembers date format). Two test currently fail bitmaps as different error is show. Not clear what

2013-04-26 Thread OmPrakash Muppirala
On Apr 26, 2013 7:49 PM, Justin Mclean jus...@classsoftware.com wrote: HI, Why not add a detailed JIRA ticket for this so that we don't forget this? There's an existing JIRA issue. I will get around to trying to fixing it in the next week - unless someone else does. Justin Just to be