I understand clear as mud, that is exactly what it was to you. My
point is that sometimes when I am creating things from scratch as in
AMD, I am not going to commit it right off the bat because I don't
want to be moving files around and doing a bunch of nosensical
commits, that is the way I
Just to clarify some stuff, since this is my "first day back on the
job after a week long sick leave which was supposed to a ski vacation"
(and I'm a bit cranky still as a result... I really shouldn't be in
public) and I need to get back up to speed on our lovely project:
> You don't need to test
Thanks Erik!
Basically this is where a modular approach is best suited for testing.
You need to think about what you need to test in your "publisher"
program and how you can break it into pieces
BTW, the compiler is not doing much stuff different that that simple
FileNode request. :)
Mik
"Reverted" the removal of the two methods. All should be well now.
I didn't really want to functional test the compiler (for now), I was
just asking if it was a good idea to have the implemenation in the
tests and the implementation in the MXMLJSC be so different. But since
you've clearly thought
You don't need to test anything, I haven't committed them yet.
As far as asking about methods, what I added made sense and should
have made sense to you by them being overridable. I mean;
addLibraries(libraries)
addSourcePath(paths)
Should be pretty clear they were hooks to add sources and S
Those AMD test are local, not yet committed? I cannot test what isn't there...
EdB
On Tue, Feb 12, 2013 at 7:54 PM, Michael Schmalle
wrote:
> I guess I have to stick my foot in my mouth on this.
>
> I see you didn't actually implement the compiler yet. So I will stand by
> what I just said tha
I haven't changed anything, I was asking IF changing it was a bad idea...
I did however remove those two methods, as they were empty and unused.
Maybe we should comment when we add some types of abstract methods
that is only meant to be overridden. I'm not that familiar with Java,
but I think ther
I guess I have to stick my foot in my mouth on this.
I see you didn't actually implement the compiler yet. So I will stand
by what I just said that changing this is bad so don't do it (future
tense).
But you did clobber a commit I made a day or two ago. This is making
AMD tests I have bro
Hi Erik,
Yes, this was a bad move. The way the TestBase was setup was testing
'unit's of code, thus we are using a simple setup for config and a
simple AST syntax request to get a FileNode.
You need to change it back, what you changed it to is a 'functional'
test. We are not testing funct
Hi Mike (I guess ;-)),
I was poking around the FalconJx unit tests to set up the testing of
projects (tests made up of more than one (generated) file), and I
noticed that the tests "roll their own" implementation of the
compilation process. It's generally the same, but some differences
exist. Whil
10 matches
Mail list logo
