[GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/flex-sdk/pull/19 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread OmPrakash Muppirala
On Fri, Jun 12, 2015 at 12:11 PM, Michael Schmalle < teotigraphix...@gmail.com> wrote: > Is there any protocol on testing stuff, or does experience warrant > understanding the side effects and making a decision based on your > understanding? > At a minimum, a build, checkin test before commiting

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread Michael Schmalle
Is there any protocol on testing stuff, or does experience warrant understanding the side effects and making a decision based on your understanding? Mike On Fri, Jun 12, 2015 at 3:08 PM, OmPrakash Muppirala wrote: > I think this is documented somewhere, but I will give it a go here. > > The git

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread OmPrakash Muppirala
I think this is documented somewhere, but I will give it a go here. The github pull request usually has an url like: https://github.com/apache/flex-sdk/pull/19 You will just have to append a ".patch" to the end of the url like this: https://github.com/apache/flex-sdk/pull/19.patch That would giv

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread Michael Schmalle
I'm playing stupid here but, how does a committer/PMC go about fulfilling a pull request? Can you explain or point me to documentation? Mike On Fri, Jun 12, 2015 at 2:53 PM, OmPrakash Muppirala wrote: > I'll take this one. > > Thanks, > Om > > On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin >

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread OmPrakash Muppirala
I'll take this one. Thanks, Om On Fri, Jun 12, 2015 at 11:50 AM, Erik de Bruin wrote: > Can someone please take a look a this? > > Thanks, > > EdB > > > > On Thu, Jun 11, 2015 at 1:09 PM, adpg wrote: > > > GitHub user adpg opened a pull request: > > > > https://github.com/apache/flex-sdk/p

Re: [GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-12 Thread Erik de Bruin
Can someone please take a look a this? Thanks, EdB On Thu, Jun 11, 2015 at 1:09 PM, adpg wrote: > GitHub user adpg opened a pull request: > > https://github.com/apache/flex-sdk/pull/19 > > Update DateTimeFormatterEx.as > > Proposing patch for bug Apache Flex / FLEX-34581: DateSpi

[GitHub] flex-sdk pull request: Update DateTimeFormatterEx.as

2015-06-11 Thread adpg
GitHub user adpg opened a pull request: https://github.com/apache/flex-sdk/pull/19 Update DateTimeFormatterEx.as Proposing patch for bug Apache Flex / FLEX-34581: DateSpinner crash when locale that uses a 24-hour setting. Modification of public function getUse24HourFlag() o