[ https://issues.apache.org/jira/browse/FLEX-27291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Mclean updated FLEX-27291: --------------------------------- Labels: performance (was: ) > Redundant code in Scroller: orientation change handler > ------------------------------------------------------ > > Key: FLEX-27291 > URL: https://issues.apache.org/jira/browse/FLEX-27291 > Project: Apache Flex > Issue Type: Bug > Components: Spark: Scroller > Affects Versions: Adobe Flex SDK Previous > Environment: Affected OS(s): All OS Platforms > Language Found: English > Reporter: Adobe JIRA > Labels: performance > > Found in version: Hero i6 (prerelease) > orientationChangeHandler seems to be redundant, since the scroll positions > depends on scroller/viewport properties (height, contentHeight, etc), not > something top and global like device orientation. This brings undesirable > dependencies and affects the performance a bit (since it would make double > proccessing on orientation change and on component properties change). > Solution: remove everything regarding orientation. > If someone will point on checkScrollPosition() and how orientation change > affects stopping throwEffect and snapping — it makes more sense to > distinguish between viewport's content resize and scroller resize to achieve > that. But not the orientation. The code smells... like _global variables. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira