RE: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maurice Amsellem
Thanks Alex for your detailed answers. I will think about it -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : lundi 14 octobre 2013 16:52 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation On 10/13/13 5:58 PM, "Maurice Amsell

Re: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Alex Harui
On 10/13/13 5:58 PM, "Maurice Amsellem" wrote: >>That might be a flaw in the design. I think other Spark components have >>a content property that can take a textFlow. >>Then it is left to the skin designer to grab the right property from the >>model and display it in the view/skin. > >Shouldn

RE: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maurice Amsellem
on it probably in November. Maurice -Message d'origine- De : Maxime Cowez [mailto:maxime.co...@gmail.com] Envoyé : lundi 14 octobre 2013 12:42 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation > I think both sentences lead to the same conclusion: makin

RE: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maurice Amsellem
:-) -Message d'origine- De : Justin Mclean [mailto:jus...@classsoftware.com] Envoyé : lundi 14 octobre 2013 12:31 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation Hi, > IMO, the buttons configuration Yes/No , Ok/Cancel, is part of the standard

Re: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maxime Cowez
> I think both sentences lead to the same conclusion: making a new "Popup" as easy as possible to implement (using your "PopupController"). > That way, it's not even needed to derive from anything. > If you need a custom alert with let's say "Retry/Ignore/Abort" buttons, build a custom Panel and

Re: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Justin Mclean
Hi, > IMO, the buttons configuration Yes/No , Ok/Cancel, is part of the standard > Alert behavior (see Windows or Java API, for example). > For the same reason, the icons should also be standardized ( INFO, WARNING, > ERROR). Let take a leaf from Android with debug , info, warning, error and

RE: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maurice Amsellem
But if the implementation is simple enough, this shouldn't be even needed. WDYT? Maurice -Message d'origine- De : Maxime Cowez [mailto:maxime.co...@gmail.com] Envoyé : lundi 14 octobre 2013 12:03 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation >

Re: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maxime Cowez
to use. > If someone wants to implement a super-duper-extended Alert box, they can > always subclass and change the skin. > > WDYT ? > > Maurice > > -Message d'origine----- > De : Maxime Cowez [mailto:maxime.co...@gmail.com] > Envoyé : lundi 14 octobre 2013 10:45 &

RE: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maurice Amsellem
xtended Alert box, they can always subclass and change the skin. WDYT ? Maurice -Message d'origine- De : Maxime Cowez [mailto:maxime.co...@gmail.com] Envoyé : lundi 14 octobre 2013 10:45 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation > But on the othe

Re: FLEX-33806 and spark Alert implementation

2013-10-14 Thread Maxime Cowez
n a Panel Skin frame. > How would you do that without inheriting Alert from Panel and without > "duplicating" the code from PanelSkin? > > Maurice > > -Message d'origine- > De : Alex Harui [mailto:aha...@adobe.com] > Envoyé : vendredi 11 octobre 2013 18

RE: FLEX-33806 and spark Alert implementation

2013-10-13 Thread Maurice Amsellem
tainer for similar reasons. > >Maurice > >-----Message d'origine- >De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre >2013 06:26 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark >Alert implementation > > > >On 10/10/13 7:20 PM,

Re: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Alex Harui
part) >or just overriding the content in a subclass of the container. > >What do you think? I haven't looked at the Alert code, but it sounds like the design may not be correct. In FlexJS the Alert is not a Container for similar reasons. > >Maurice > >-----Message d&#x

RE: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maurice Amsellem
xime Cowez [mailto:maxime.co...@gmail.com] Envoyé : vendredi 11 octobre 2013 17:40 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation I absolutely agree about the code redundancy. However at this moment it is already all over the place. Alert, SkinnablePopUpContainer, PopUpA

Re: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maxime Cowez
low). > -- > > PS: to say the truth, I am not using PopupAnchor but a variant of it, > called "Popup" that is part of Cairngorm/Parsley, because it's IOC aware, > but it's the same idea: > > open="{model.editDialogPM.showDialog}" paren="{someButton}&qu

RE: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maurice Amsellem
k? Maurice -Message d'origine- De : Maxime Cowez [mailto:maxime.co...@gmail.com] Envoyé : vendredi 11 octobre 2013 12:23 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation > What's the difference between you new SkinnablePopup and the ex

Re: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maxime Cowez
msellem [mailto:maurice.amsel...@systar.com] > Envoyé : vendredi 11 octobre 2013 11:31 > À : dev@flex.apache.org > Objet : RE: FLEX-33806 and spark Alert implementation > > Hi Maxime, > > What's the difference between you new SkinnablePopup and the existing > Skinnab

RE: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maurice Amsellem
BTW, I like the idea of the mxml based Alert (in addition to AS script API) :-) Maurice -Message d'origine- De : Maurice Amsellem [mailto:maurice.amsel...@systar.com] Envoyé : vendredi 11 octobre 2013 11:31 À : dev@flex.apache.org Objet : RE: FLEX-33806 and spark Alert implement

RE: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maurice Amsellem
st overriding the content in a subclass of the container. > > What do you think? > > Maurice > > -Message d'origine- > De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre > 2013 06:26 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark >

Re: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maxime Cowez
on the "data" > and not of the skin. > It's not clear to me if changes in the content of SkinnableContainers > should be set as skinParts and moved to the skin (and disabling the content > skinpart) > or just overriding the content in a subclass of the container. >

RE: FLEX-33806 and spark Alert implementation

2013-10-11 Thread Maurice Amsellem
What do you think? Maurice -Message d'origine- De : Alex Harui [mailto:aha...@adobe.com] Envoyé : vendredi 11 octobre 2013 06:26 À : dev@flex.apache.org Objet : Re: FLEX-33806 and spark Alert implementation On 10/10/13 7:20 PM, "Justin Mclean" wrote: >Hi, > >Being

Re: FLEX-33806 and spark Alert implementation

2013-10-10 Thread Alex Harui
On 10/10/13 7:20 PM, "Justin Mclean" wrote: >Hi, > >Being an experimental component I think just about any improvement is a >good idea. I agree with that statement, but is removing skinparts a "good idea"? Simplification tends to remove flexibility. Spark components are supposed to leave contr

Re: FLEX-33806 and spark Alert implementation

2013-10-10 Thread Justin Mclean
Hi, Being an experimental component I think just about any improvement is a good idea. Thanks, Justin

FLEX-33806 and spark Alert implementation

2013-10-10 Thread Maurice Amsellem
Hi, while working on FLEX-33806 (changing the message top padding of experimental Alert), I realized the implementation of this class was unnecessarily complex: - it derives from Panel (ok) and adds 3 skinParts (messageDisplay , iconDisplay, and buttonGroup) - Defines its own