Re: Just need to vent...

Personally, I think Closure compiler is too quirky with its strict requirements for circulars, and I want -remove-circulars to go away, if possible. Or switch the default to the opposite, where you need to set a flag if you want things to be stricter. - Josh On Tue, Mar 21, 2017 at 1:41 PM, Alex

Re: Just need to vent...

Update: I'm making progress on this, and it looks like it will work, but there is one thing I don't like about it, which is that it means that the JS files in the SWCs won't be usable as-is in Google Closure. They will always have to be processed by FalconJX so their non-prototype dependencies

Re: Just need to vent...

On 3/18/17, 9:56 AM, "Harbs" wrote: >In principle that sounds good, but what will make sure that all the >necessary files are loaded? > >Also, will that effect the google compiler being able to optimize the >code? > >Ah. I think I understand. You’ll still output the

Re: Just need to vent...

In principle that sounds good, but what will make sure that all the necessary files are loaded? Also, will that effect the google compiler being able to optimize the code? Ah. I think I understand. You’ll still output the requires in the main app, but you’ll build the list from js tags in the

Re: Just need to vent...

On 3/18/17, 1:02 AM, "Justin Mclean" wrote: >HI, > >> So, does anyone think the we should try to retain the "don't copy if it >> exists" code? Otherwise I will change the code to always copy. > >Do you know how much of a performance hit to compile time this might be?

Re: Just need to vent...

HI, > So, does anyone think the we should try to retain the "don't copy if it > exists" code? Otherwise I will change the code to always copy. Do you know how much of a performance hit to compile time this might be? If it’s any at all that is? Thanks, Justin

Re: Just need to vent...

Well, I sort of have Harb's suggestion working, then I discovered that the removal of most of the requires as suggested in #3 means that the compiler/publisher will have to start copying JS files from the SWCs at the end of each compile. Right now, the compiler/publisher checks to see if the .JS

Re: Just need to vent...

On 3/16/17, 12:35 AM, "Harbs" wrote: >I think that’s a good plan. > >Here’s what (I think) should solve the problem: > >1. The compiler goes through the require chain once and build a list of >all inheritance chains. >2. It also builds a list of requires that either have

Re: Just need to vent...

;> >>> Please post all console output. Thanks >>> >>> Get Outlook for Android<https://aka.ms/ghei36> >>> >>> >>> >>> From: Harbs <harbs.li...@gmail.com> >>

Re: Just need to vent...

aka.ms/ghei36> >> >> >> >> From: Harbs <harbs.li...@gmail.com> >> Sent: Tuesday, March 14, 2017 11:52:50 PM >> To: dev@flex.apache.org >> Subject: Re: Just need to vent... >> >>

Re: Just need to vent...

> From: Harbs <harbs.li...@gmail.com> > Sent: Tuesday, March 14, 2017 11:52:50 PM > To: dev@flex.apache.org > Subject: Re: Just need to vent... > > I just pulled in the latests changes and the build now “completes” wi

Re: Just need to vent...

Please post all console output. Thanks Get Outlook for Android<https://aka.ms/ghei36> From: Harbs <harbs.li...@gmail.com> Sent: Tuesday, March 14, 2017 11:52:50 PM To: dev@flex.apache.org Subject: Re: Just need to vent... I just pulled in the lat

Re: Just need to vent...

I just pulled in the latests changes and the build now “completes” with a different problem: [java] Mar 15, 2017 8:49:42 AM com.google.javascript.jscomp.LoggerErrorManager println [java] SEVERE:

Re: Just need to vent...

Hmm. I wonder what that is. I just pushed an attempt to report on why that is. -Alex On 3/14/17, 2:16 PM, "Harbs" wrote: >Got an error: >https://paste.apache.org/KgxC > >> On Mar 14, 2017, at 10:34 PM, Harbs

Re: Just need to vent...

Got an error: https://paste.apache.org/KgxC > On Mar 14, 2017, at 10:34 PM, Harbs wrote: > > Pulling now. I’ll let you know how it goes. > >> On Mar 14, 2017, at 9:44 PM, Alex Harui wrote: >> >> >> >> On 3/14/17,

Re: Just need to vent...

Pulling now. I’ll let you know how it goes. > On Mar 14, 2017, at 9:44 PM, Alex Harui wrote: > > > > On 3/14/17, 12:20 AM, "Harbs" wrote: > >> That’s great! I’m anxiously waiting to see what you can do! ;-) > > OK, I put in a fix for my simple case.

Re: Just need to vent...

On 3/14/17, 12:20 AM, "Harbs" wrote: >That’s great! I’m anxiously waiting to see what you can do! ;-) OK, I put in a fix for my simple case. See if it helps on your case and if compile times really bog down. Basically, we are trying to list the contents of a DAG, but

Re: Just need to vent...

That’s great! I’m anxiously waiting to see what you can do! ;-) > On Mar 14, 2017, at 8:17 AM, Alex Harui wrote: > > OK, I reproduced it in a simple case. > > StandardFlowComposer extends FlowComposerBase which references > FactoryComposer which extends StandardFlowComposer >

Re: Just need to vent...

OK, I reproduced it in a simple case. StandardFlowComposer extends FlowComposerBase which references FactoryComposer which extends StandardFlowComposer This is totally allowed, but the order of files passed to GCC isn't correct. I will work on a fix. -Alex On 3/13/17, 3:06 PM, "Harbs"

Re: Just need to vent...

Yes. Remove circulars is on. I will send you a dropbox link privately. Harbs > On Mar 13, 2017, at 11:42 PM, Alex Harui wrote: > > I would definitely have remove-circulars on, since GCC definitely hates > circulars. Then, in theory, the new code is telling GCC exactly which

Re: Just need to vent...

I would definitely have remove-circulars on, since GCC definitely hates circulars. Then, in theory, the new code is telling GCC exactly which order to visit the files so that we can compute namespaces correctly by removing circulars. So, if -remove-circulars is on, then can you package up the

Re: Just need to vent...

I got rid of circulars which was causing the two SubParagraphGroupElementBase errors, but the StandardFlowComposer error seems wrong to me. (Of course I could be missing something…) > On Mar 13, 2017, at 10:28 PM, Harbs wrote: > > I’m getting these three errors with

Re: Just need to vent...

I’m getting these three errors with remove-circulars enabled. [java] Mar 13, 2017 10:17:00 PM com.google.javascript.jscomp.LoggerErrorManager println [java] SEVERE:

Re: Just need to vent...

I pulle the latest commit and the error went away. I’m looking to see if the output is better. > On Mar 13, 2017, at 9:57 PM, Harbs wrote: > > I just tried and got this error: > > [java] Compiling file: >

Re: Just need to vent...

I just tried and got this error: [java] Compiling file: /Users/harbs/Documents/git/PrintUI/printui-flexjs/text_engine/test/HelloWorldTLF/bin/js-debug/HelloWorldTLF.js [java] HelloWorldTLF as: [HelloWorldTLF, org.apache.flex.textLayout.container.ContainerController, NaN,

Re: Just need to vent...

So I just pushed some changes in flex-falcon that might help. Give it a try and let me know... -Alex On 3/10/17, 10:45 PM, "Alex Harui" wrote: >Ah crud. Nevermind. I didn't have remove-circulars in the failing case. > >Still pondering... >-Alex > >On 3/10/17, 4:17 PM,

Re: Just need to vent...

Ah crud. Nevermind. I didn't have remove-circulars in the failing case. Still pondering... -Alex On 3/10/17, 4:17 PM, "Alex Harui" wrote: >For those keeping track, I think I have gathered enough evidence to >conclude that it is a Java 6 vs 7 difference in the Hash iterators

Re: Just need to vent...

For those keeping track, I think I have gathered enough evidence to conclude that it is a Java 6 vs 7 difference in the Hash iterators that is fooling the way we build the list of files for GCC. I will look into fixing that. -Alex On 3/10/17, 11:27 AM, "Alex Harui" wrote: >

Re: Just need to vent...

On 3/9/17, 2:35 PM, "Harbs" wrote: >It looks to me like the missing definitions are classes which are only >used in static methods. > >Could it be that Falcon is not properly declaring dependencies in static >methods? I think the issue is the order of files being passed

Re: Just need to vent...

JustificationStyle is in a separate Text.swc file, and yes, the js files are there. The js files are copied correctly to the bin/js-debug folder, but something is wrong with the dependency tree. There’s quite a few classes that are not recognized. Some are in TLF and some are in Text. The

Re: Just need to vent...

It looks to me like the missing definitions are classes which are only used in static methods. Could it be that Falcon is not properly declaring dependencies in static methods? > On Mar 10, 2017, at 12:28 AM, Harbs wrote: > > JustificationStyle is in a separate

Re: Just need to vent...

On 3/9/17, 12:41 PM, "Harbs" wrote: >I’ve already eliminated those errors by removing circular dependencies. > >I moved static functions to utility classes and all inter-class >references are using interfaces. > >To get you the output, I’d need to revert the state of the

Re: Just need to vent...

I’ve already eliminated those errors by removing circular dependencies. I moved static functions to utility classes and all inter-class references are using interfaces. To get you the output, I’d need to revert the state of the repo. I’m not getting a new class of errors:

Re: Just need to vent...

It might be a bug in Google Closure Compiler. Can you send me the bin/js-debug/index.html. It will have the dependency chain in it. Thanks, -Alex On 3/9/17, 12:43 AM, "Harbs" wrote: >I already using remove-circulars and it’s not helping in this case. If >you’re

Re: Just need to vent...

I already using remove-circulars and it’s not helping in this case. If you’re interested here’s the output: https://paste.apache.org/Kd9l And running the debug in the browser has tons of runtime errors. I had this problem when porting my app as well. Basically static properties really mess

Re: Just need to vent...

On 3/8/17, 5:05 PM, "Harbs" wrote: >The only other option is to just drop TLF and that’s way more work (I >think). > >As it is, it cannot be compiled by the Google Compiler. > >There’s lots of superclass dependencies on subclasses. > >The good news is that I’m making it

Re: Just need to vent...

The only other option is to just drop TLF and that’s way more work (I think). As it is, it cannot be compiled by the Google Compiler. There’s lots of superclass dependencies on subclasses. The good news is that I’m making it a lot more reliant on interfaces which is probably a good thing. >

Re: Just need to vent...

On 3/8/17, 3:53 PM, "Harbs" wrote: >Wow! > >TLF is seriously spaghetti code. I have been working on removing circular >dependencies for about 16 hours straight. There are more A -> B -> A >dependencies than I can count. > >What a pain! I hear you. I don't know if I

Just need to vent...

Wow! TLF is seriously spaghetti code. I have been working on removing circular dependencies for about 16 hours straight. There are more A -> B -> A dependencies than I can count. What a pain! (Now back to our regular programming…) ;-) Harbs