Re: [FlexJS] DefineProperty Code Style

2015-05-18 Thread OmPrakash Muppirala
On Mon, May 18, 2015 at 10:29 AM, Peter Ent wrote: > I created a simple example (flex-asjs/examples/RollEventsTest) to > demonstrate rollover/out events using an IBeadController bead. I can add > more to if needed. > > Great! Thanks Peter. I will take a look at it once I resolve my git related

Re: [FlexJS] DefineProperty Code Style

2015-05-18 Thread Peter Ent
I created a simple example (flex-asjs/examples/RollEventsTest) to demonstrate rollover/out events using an IBeadController bead. I can add more to if needed. Peter Ent Adobe Systems On 4/9/15, 10:49 AM, "Peter Ent" wrote: >I ahould be able to do this for you. > >Peter Ent >Adobe Systems > >On 4

Re: [FlexJS] DefineProperty Code Style

2015-04-09 Thread OmPrakash Muppirala
On Apr 9, 2015 7:50 AM, "Peter Ent" wrote: > > I ahould be able to do this for you. > I would welcome it :-) Thanks, Om > Peter Ent > Adobe Systems > > On 4/9/15, 12:06 AM, "OmPrakash Muppirala" wrote: > > >On Wed, Apr 8, 2015 at 8:50 PM, Alex Harui wrote: > > > >> > >> > >> On 4/8/15, 8:23 P

Re: [FlexJS] DefineProperty Code Style

2015-04-09 Thread Peter Ent
I ahould be able to do this for you. Peter Ent Adobe Systems On 4/9/15, 12:06 AM, "OmPrakash Muppirala" wrote: >On Wed, Apr 8, 2015 at 8:50 PM, Alex Harui wrote: > >> >> >> On 4/8/15, 8:23 PM, "OmPrakash Muppirala" wrote: >> >> >> >At some point, I would like to get back to working on skinnin

Re: [FlexJS] DefineProperty Code Style

2015-04-08 Thread OmPrakash Muppirala
On Wed, Apr 8, 2015 at 8:50 PM, Alex Harui wrote: > > > On 4/8/15, 8:23 PM, "OmPrakash Muppirala" wrote: > > > >At some point, I would like to get back to working on skinning using the > >FXG/SVG drawing APIs. I will need your help with the mouse event handling > >across FP and HTML/JS. Any ch

Re: [FlexJS] DefineProperty Code Style

2015-04-08 Thread Alex Harui
On 4/8/15, 8:23 PM, "OmPrakash Muppirala" wrote: >At some point, I would like to get back to working on skinning using the >FXG/SVG drawing APIs. I will need your help with the mouse event handling >across FP and HTML/JS. Any chance you can whip up a small app that throws >rollover, rollout,

Re: [FlexJS] DefineProperty Code Style

2015-04-08 Thread OmPrakash Muppirala
On Wed, Apr 8, 2015 at 4:07 PM, Alex Harui wrote: > DefineProperty has landed. I’m sure there are bugs, and the js compile > currently generates tons of warnings, but I think it was good enough to > push. I filed a bug against GCC for most of the warnings. > > Next up, I want to do a big rename

Re: [FlexJS] DefineProperty Code Style

2015-04-08 Thread Alex Harui
DefineProperty has landed. I’m sure there are bugs, and the js compile currently generates tons of warnings, but I think it was good enough to push. I filed a bug against GCC for most of the warnings. Next up, I want to do a big rename of classes and SWCs to better organize things. Opinions are

Re: [FlexJS] DefineProperty Code Style

2015-04-07 Thread Erik de Bruin
> Google has deprecated @expose so this solution may stop working some day. I would take that deprecated bit with a grain of salt: https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/closure-compiler-discuss/pZaodHd0KD0/p767zHJzWO8J I read that thread to mean that they want

Re: [FlexJS] DefineProperty Code Style

2015-04-07 Thread OmPrakash Muppirala
I am glad you were able to work it out. Looking forward, it appears that ECMA6 has support for AS3 like (or ECMA4 ;-) like )getters and setters. Example here: http://es6-features.org/?utm_content=buffer94d31&utm_medium=social&utm_source=twitter.com&utm_campaign=buffer#GetterSetter I am guessing

Re: [FlexJS] DefineProperty Code Style

2015-04-07 Thread Alex Harui
Update: Inspired by Erik’s suggestion to use @expose, I found that I can use @expose on the structure keys instead of having to create more prototype slots. So the pattern now is: Object.defineProperties(org_apache_flex_utils_BinaryData.prototype, { /** @expose */ productService: { /** @

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Alex Harui
Hi Erik, Well, this renaming issue is coming from an actual scenario that runs correctly when not minified. I think what you are showing is that the code-flow analyzer contributes to the renaming logic. In this actual test case, someFunction is called from an event handler, so maybe the renaming

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Erik de Bruin
Alex, I think what you're seeing is an artifact of the way you've set up your example... You don't instantiate the object and never reference the property outside of the class' internals. WIth such a minimal case, that basically doesn't execute, the compiler thinks it can be smart and 'optimize' a

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Alex Harui
This is very strange. It could be that certain words like position and data are in a blacklist. I tried this (essentially the same example but using productService as the name) // ==ClosureCompiler== // @compilation_level ADVANCED_OPTIMIZATIONS // @output_file_name default.js // @language ECMASC

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Alex Harui
On 4/6/15, 12:25 AM, "Erik de Bruin" wrote: >Have you tried it without the quotes around the property name in >Object.defineProperties? I did, and no luck there either. And in the final result, there will be some properties that are accessed by name and thus can’t be renamed (well, at least n

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Erik de Bruin
I'm assuming (but can't find any directly relevant links ;-) that this is because the JS spec (ECMA) says that an object's properties should be addressable with quoted AND dotted notification (i.e. obj['prop'] and obj.prop). If the compiler renamed the property, it would remove the ability to use q

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Alex Harui
Hi Erik, That’s interesting. I’ll try that site. I would have expected the compiler to rename position to some one or two-letter variable. Can you tell me why it didn’t? -Alex On 4/6/15, 5:17 AM, "Erik de Bruin" wrote: >Alex, > >I used 'http://closure-compiler.appspot.com/' with this input:

Re: [FlexJS] DefineProperty Code Style

2015-04-06 Thread Erik de Bruin
Alex, I used 'http://closure-compiler.appspot.com/' with this input: // ==ClosureCompiler== // @compilation_level ADVANCED_OPTIMIZATIONS // @warning_level VERBOSE // @language ECMASCRIPT5_STRICT // ==/ClosureCompiler== 'use strict'; /** * @constructor */ var org_apache_flex_utils_BinaryData =

Re: [FlexJS] DefineProperty Code Style

2015-04-05 Thread Alex Harui
Thanks for the suggestion. It didn’t seem to help. I’ve grepped the GCC code and didn’t see any attempt to handle defineProp. I think the issue is that GCC doesn’t expect code in the defineProperties functions to be referencing other functions in the class and vice versa. For example, this meth

Re: [FlexJS] DefineProperty Code Style

2015-04-04 Thread Erik de Bruin
Alex, When working with Object.definePropert(y)(ies), did you experiment using with the setting: options_.setLanguageIn(LanguageMode.ECMASCRIPT5_STRICT) in the class JSClosureCompilerWrapper? The compiler defaults to ECMASCRIPT3 and I guess that might explain why it doesn't handle 'newer' featu

Re: [FlexJS] DefineProperty Code Style

2015-04-04 Thread Alex Harui
After getting this working for the js-debug version, I’ve come to the conclusion that the Google Closure Compiler cannot handle the defineProperties pattern I proposed. The variable and property renaming, and a few other places, gets totally confused by the code in the object structure, even after

Re: [FlexJS] DefineProperty Code Style

2015-03-13 Thread Alex Harui
On 3/13/15, 1:03 PM, "OmPrakash Muppirala" wrote: >On Thu, Mar 12, 2015 at 9:15 PM, Alex Harui wrote: > >> I’ve been plugging away trying to convert the FlexJS framework to use >> Object.defineProperty. > > >This removes IE8 from the equation. You probably know that already. > I thought we g

Re: [FlexJS] DefineProperty Code Style

2015-03-13 Thread OmPrakash Muppirala
On Thu, Mar 12, 2015 at 9:15 PM, Alex Harui wrote: > I’ve been plugging away trying to convert the FlexJS framework to use > Object.defineProperty. This removes IE8 from the equation. You probably know that already. > I’m looking to get other’s thoughts on how to indent, comment and > otherw