Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-03 Thread Josh Tynjala
I re-read your description of outputFolderMap, and I now I understand how my proposal can be included as its default. - Josh On Fri, Jun 2, 2017 at 10:04 PM, Alex Harui wrote: > Hmm. We seem to be miscommunicating. My proposal is to implement your > proposal via

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
Hmm. We seem to be miscommunicating. My proposal is to implement your proposal via outputFolderMap and some default mappings in flex-config.xml. -Alex On 6/2/17, 9:06 AM, "Josh Tynjala" wrote: >Oh, I didn't realize that you wanted to add -outputFolderMap in addition

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
Oh, I didn't realize that you wanted to add -outputFolderMap in addition to my proposal. That sounds good to me! - Josh On Fri, Jun 2, 2017 at 9:03 AM, Alex Harui wrote: > Agreed. So I think with the defaults I propose we will implement what you > propose and I can

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
Agreed. So I think with the defaults I propose we will implement what you propose and I can tweak it for my needs? -Alex On 6/2/17, 8:55 AM, "Josh Tynjala" wrote: >That's a perfectly valid solution for some people. I prefer to work with >unmodified SDKs so that I don't

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
That's a perfectly valid solution for some people. I prefer to work with unmodified SDKs so that I don't accidentally release any projects that break for other people because their SDKs are not modified like mine. - Josh On Fri, Jun 2, 2017 at 8:42 AM, Alex Harui

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
I would modify my flex-config.xml, so I don't have to modify every project. -Alex On 6/2/17, 8:38 AM, "Josh Tynjala" wrote: >If I need to set an option, then I might as well set -output or >-js-output. >I simply wouldn't use -outputFolderMap. > >- Josh > >On Fri, Jun 2,

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
If I need to set an option, then I might as well set -output or -js-output. I simply wouldn't use -outputFolderMap. - Josh On Fri, Jun 2, 2017 at 8:25 AM, Alex Harui wrote: > OK, sorry, I did miss that. I thought you were the one who wanted the > output in the same

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Alex Harui
OK, sorry, I did miss that. I thought you were the one who wanted the output in the same folder, but I was mistaken. Keep in mind that: 1) The SWF compiler (MXMLC for both the regular Flex SDK and FlexJS) defaults to putting the output in the same folder. So, if you have:

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-02 Thread Josh Tynjala
You seem to be missing the most important part of my proposal. The compiler will put the "bin" directory in the parent of the main source folder, regardless of whether it's named "src", "source", "alex-is-cool" or *any* name whatsoever. I put some pseudo-code to explain that in one of my emails,

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
Maybe I don't understand your proposal. Currently I think you can say that there are exceptions for "src" and "src/main/flex". AIUI, your proposal is that only "src/main/flex" would be handled differently. -Alex On 6/1/17, 12:13 PM, "Josh Tynjala" wrote: >Why would you

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
Why would you need to stop and reconfigure all of those projects? With the change that I suggested, all of your projects that use "src" would continue to work just fine with no changes required. Yes, I'm perfectly happy making any changes after this release. - Josh On Thu, Jun 1, 2017 at 12:05

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
Believe me, I am not worried about perfection here. I am saying that if we make changes, we should allow the set of patterns to be configurable so we don't have to change the compiler to add new patterns. I already have a large set of projects with only "src" and I would prefer not to have to

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
If there are other nested source directory structures recommended as standard practice by opinionated tools, similar to how Maven use "src/main/flex", then sure, let's add them as we become aware of them. "srcx/main/flex" would indeed not be solved by my recommended change. However, "source",

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
If we allow one exception, why not more than one? What if we add an "outputFolderExceptions" list and default it to just contain "src/main/flex". Then I could add "src" in my SDK installs to get what I want. Still not sure how it solves the original problem though. If someone has a

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
If we do as I suggest, there would no longer be a list of patterns. I want to allow *any* folder name. That's what I mean by generalizing. Just automatically put the "bin" directory relative to the parent directory of the main source file. (with one exception: Maven-style project structures with

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
I just want to optimize for a couple of common cases in order to save me and maybe other folks some time. If for some reason I need to compile a Flash Builder project from the command-line or Ant or Java debugger, I don't have to remember to set the -output parameter. I used to get FB projects

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
I'm not sure that I understand why you mentioned changing Flash Builder's default source path. That seems mostly tangential here. I'm saying that the compiler shouldn't care whether it's named "src", "source", or "whatever-i-want-to-call-it". It should simply default to putting "bin" in the

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
I think "src" is for Flash Builder. I don't know what it would take to get FB to default to something else. I know I have lots of projects with just a "src" folder. I agree it is confusing. We could output a warning or error if you haven't specified -output, -js-output and don't have "src" or

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
I think I had some trouble trying to get -output to accept a directory for a JS-only project, and that's when I figured out that -js-output exists. Maybe I was doing something wrong at the time. Or maybe it didn't quite work properly yet. Although, I still think it's confusing to those who don't

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Alex Harui
And if you just use -output and not -js-output the bin folder will be where you specified -output, and if you specify -output=somefolder\somefile.swf the output will be in somefolder\bin. The logic is trying to say: 1) If you specify -output as a SWF, we will use the parent folder of the SWF 2)

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
In that case, the SWF will use the -output option: mxmlc -output=path/to/MyProject.swf -js-output=. source/MyProject.as - Josh On Thu, Jun 1, 2017 at 7:30 AM, piotrz wrote: > Ahh..Ok now it is clear. What about if we have > -compiler.targets=JSFLEX,SWF - > So

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread piotrz
Ahh..Ok now it is clear. What about if we have -compiler.targets=JSFLEX,SWF - So -js-output will be also the place where SWF file will landed? - If yes in that case this param could have different name. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
I'm not sure if I was clear, but the -js-output option already exists, and it may be used today. - Josh On Thu, Jun 1, 2017 at 6:51 AM, piotrz wrote: > Hi Santanu, Josh, > > +1 for having option -js-output=. to configure this one. If those changes > need to be done

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Christofer Dutz
Even if the src/main/flex is the default for maven flex project, it should already be configurable … same as the output directory. Chris Am 01.06.17, 15:30 schrieb "Josh Tynjala" : I ran into this issue too because I frequently use "source" instead of "src".

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread piotrz
Hi Santanu, Josh, +1 for having option -js-output=. to configure this one. If those changes need to be done on compiler sight maybe jira should be raised ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] Why FlexJS compiler statically looks for 'src' folder

2017-06-01 Thread Josh Tynjala
I ran into this issue too because I frequently use "source" instead of "src". It is indeed true that "src" is hard coded, along with "src/main/flex" (for Maven). I wonder if it would be better to simply produce bin in the current working directory by default, instead of having these two hard