Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

2017-07-24 Thread Harbs
Good call. I noticed that I can simplify the code a bit as well. I added this to the other notifier classes too. > On Jul 24, 2017, at 1:37 PM, Piotr Zarzycki wrote: > > Hi Harbs, > > I think this line should be outside "if": > > var object:Object =

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

2017-07-24 Thread Piotr Zarzycki
Hi Harbs, I think this line should be outside "if": var object:Object = document[sourceID]; Please check additionally other beads related to ChangeNotifier. Thanks, Piotr 2017-07-24 12:29 GMT+02:00 : > Repository: flex-asjs > Updated Branches: > refs/heads/develop

Re: git commit: [flex-asjs] [refs/heads/develop] - This appears to be inoperative. I believe this change is correct, but it really needs a test.

2017-07-24 Thread Harbs
While researching the issue I had, I noticed this code. It appears to be removing the event handlers from the object and then adding them back to the same objects. I believe the change I wrote is necessary to add the event handlers to the new object, but I’d appreciate if we get some