Re: output method in installer

2014-10-10 Thread Alex Harui
On 10/10/14, 1:17 PM, "Justin Mclean" wrote: >Hi, > >Just something I noticed while fixing something else - looks a little >broken to me. IIRC, there might be an issue with errors before the first Ant step. Is that what you saw? Feel free to make changes there, but I think it works mostly whe

Re: output method in installer

2014-10-10 Thread Justin Mclean
Hi, Just something I noticed while fixing something else - looks a little broken to me. Justin

Re: output method in installer

2014-10-10 Thread Erik de Bruin
A challenge, or did you just want to share while you were committing a fix? EdB On Friday, October 10, 2014, Justin Mclean wrote: > HI, > > This code in the badly named output method looks wrong to me: > > if (currentStep < stepLabels.length && "\n" + > stepIDs[currentStep] +

output method in installer

2014-10-10 Thread Justin Mclean
HI, This code in the badly named output method looks wrong to me: if (currentStep < stepLabels.length && "\n" + stepIDs[currentStep] + ":" == s) { if (currentStep > 0) updateActivityStep(stepLabels[currentStep - 1], Ste