Re: LAST CALL] Release FlexJS/FalconJX 0.7.0

2016-07-03 Thread Alex Harui
On 7/2/16, 10:34 PM, "Justin Mclean" wrote: >Hi, > >> IMO, because the patch files are generated from ant scripts, they don't >> need headers. > >IMO if it source code it need a header, otherwise how do we know how the >patch is licensed or where it come from? > >This

Re: Encode and Decode UTF8

2016-07-03 Thread Harbs
Yes. It is. I’m going to change it. On Jul 3, 2016, at 8:29 AM, Alex Harui wrote: > > > On 7/2/16, 12:22 PM, "Harbs" wrote: > >> Thanks. The GC implementation is nice and simple. >> >> One question (I think for Peter): >> >> BinaryData is using

AW: AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Christofer Dutz
Hi Alex, I figured out what the problem was. I had to put the externs on the external-lib-path for all of the framework modules. After this all examples now build correctly. I took the opportunity to turn on the feature of failing the build in case of build errors in the plugin. However not

Re: [FlexJS]Events

2016-07-03 Thread Alex Harui
On 7/3/16, 7:21 AM, "Harbs" wrote: >The first “flex” was a typo and it should have been “flash”. I'm not seeing that in the code. Can you be more specific about which lines are doing this? > >I’m not sure my question made sense, but I do have a related question: >Why

Re: AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Alex Harui
IMO, all of the examples issues are related to extra goog.requires in the Maven output. Goog.requires are controlled in several ways: 1. having the required thing on the external-library-path should prevent a goog.require from being generated 2. Remove-circulars should remove

Re: [FlexJS]unit testing

2016-07-03 Thread Alex Harui
On 7/3/16, 2:15 AM, "Harbs" wrote: >Besides the “manualtests” folder, there’s not really much testing that I >can see. Is there an easy way to create unit tests that work on both the >Flash side and the JS side of things? In mustella/tests are sample mustella

Re: [FlexJS]Events

2016-07-03 Thread Alex Harui
On 7/3/16, 1:52 AM, "Harbs" wrote: >I’m struggling to understand events in FlexJS. It looks like events are >conditionally handled to be either “flex” events on the swf side of >“flex” events on the JS side. Specifically, I’m looking at HTTPService. >Why does it not use

Re: [FlexJS]Events

2016-07-03 Thread Harbs
The first “flex” was a typo and it should have been “flash”. I’m not sure my question made sense, but I do have a related question: Why this? COMPILE::SWF public class HTTPServiceBase extends EventDispatcher { } COMPILE::JS public class HTTPServiceBase extends

Re: AW: AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Alex Harui
Excellent! I will investigate the runtime issues this evening. -Alex From: Christofer Dutz > Date: Sunday, July 3, 2016 at 7:20 AM To: Alex Harui >,

Re: [FlexJS]unit testing

2016-07-03 Thread Harbs
What about Jasmine? Unfortunately I have very little experience with unit testing… On Jul 3, 2016, at 5:10 PM, Alex Harui wrote: > > On 7/3/16, 2:15 AM, "Harbs" wrote: > >> Besides the “manualtests” folder, there’s not really much testing that I >>

Re: [FlexJS]Events

2016-07-03 Thread Harbs
Let me explain a bit better why I’m asking. Yishay and I are working on a URLLoader class which will behave similar to the Flash URLLoader class. Is there any reason not to make both the Flash and JS version extend EventDispatcher? From what I can see, the flex EventDispatcher on the JS side

Re: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Alex Harui
OK, took a look. CreateJSExample and FlexJSStore_jquery also have the compiler option: -js-output-optimization=skipFunctionCoercions for the JS build. StorageExample still doesn't have cordova.swc from the externs in the pom and config.xml. HTH, -Alex On 7/2/16, 7:59 AM, "Alex Harui"

AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Christofer Dutz
Hi Alex, I tried adding the js-output-optimization option to the build, but as soon as I add that to the config file, the compiler complains about the element containing invalid CDATA which I debugged and it throws that exception as soon as it contains any content at all. But I tried

Re: flexjs init the int =0

2016-07-03 Thread Harbs
We had a discussion a few months back entitled "[FlexJS]as in”. There were a number of suggestions how to handle int, but I don’t think anyone did anything there. On Jul 3, 2016, at 9:49 AM, Alex Harui wrote: > > > On 7/1/16, 1:44 PM, "jude"

Re: flexjs init the int =0

2016-07-03 Thread Alex Harui
On 7/1/16, 1:44 PM, "jude" wrote: >ihzi is correct. to clarify, the compiler should initialize integers to >zero when they are defined. and it should probably wrap any code that >assigns a value to an int with parseInt(). IMO, it should be easy to initialize integers

Re: AW: AW: AW: AW: LAST CALL] Release FlexJS/FalconJX 0.7.0

2016-07-03 Thread Alex Harui
On 7/2/16, 7:52 AM, "Christofer Dutz" wrote: >Hi Alex, > > >indeed, when building most of the time is spent by the closure compiler >compiling the release build for the examples. It would be great if it was >possible to skip this last build. Especially as I package

[FlexJS]unit testing

2016-07-03 Thread Harbs
Besides the “manualtests” folder, there’s not really much testing that I can see. Is there an easy way to create unit tests that work on both the Flash side and the JS side of things?

AW: AW: AW: AW: AW: AW: AW: AW: [Falcon][FlexJS] Help with finishing the maven migration

2016-07-03 Thread Christofer Dutz
Ok so I had a look at the JS Code generated. In StorageExample it seems to be looking for the cordova dependency as WebStorageProvider.js seems to require it. So I compared the generated code of the Maven build with that of the Ant build and I could see that not all of the "goog.require"

AW: [FlexJS]unit testing

2016-07-03 Thread Christofer Dutz
I could imagine that it could be possible to write tests in selenium webdriver as this can automate flash and JavaScript applications. But that would be more down the path of frontend testing and not unit testing. Chris Von meinem Samsung Galaxy Smartphone gesendet. Ursprüngliche

AW: [FlexJS-Maven] Basic project configuration for FlexJS Maven

2016-07-03 Thread Christofer Dutz
Hi Carlos, Don't the examples in the asjs project work as examples? But at the moment I'm still working on some last problems that need fixing. At the moment all examples successfully build, but the js output still has problems. So I would suggest to wait a few more days till we sort these

Re: [FlexJS-Maven] Basic project configuration for FlexJS Maven

2016-07-03 Thread Carlos Rovira
Thanks Chris, I didn't fall into that. Thanks, I'll check those poms. I was getting different groupsIds and artifacts that makes me completly lost. One of those example poms will definitely help me a lot. I'll wait as you suggest until you rise the green flag :) Thanks! 2016-07-03 22:38

Re: flexjs init the int =0

2016-07-03 Thread jude
in as3 if you sign an object to an int an error is thrown. in js the variable would be assigned to the object and would no longer be an int. so maybe, when the time comes, simply casting it as int would be enough. On Jul 3, 2016 1:50 AM, "Alex Harui" wrote: > > > On 7/1/16,

[FlexJS-Maven] Basic project configuration for FlexJS Maven

2016-07-03 Thread Carlos Rovira
Hi, Now that I have FlexJS build with maven and the artifacts in my repository, I'm trying to create a basic project to test it, but with no luck. Rather than continue trying it, I thought better to ask here for a basic pom config that use FlexJS in a project. I'm with IntelliJ IDEA Thanks in

Re: AW: [FlexJS]unit testing

2016-07-03 Thread Alex Harui
On 7/3/16, 11:09 AM, "Christofer Dutz" wrote: >I could imagine that it could be possible to write tests in selenium >webdriver as this can automate flash and JavaScript applications. But >that would be more down the path of frontend testing and not unit testing.

Re: [FlexJS]Events

2016-07-03 Thread Alex Harui
What does URLLoader do that HTTPService doesn't? -Alex On 7/3/16, 9:36 AM, "Harbs" wrote: >Let me explain a bit better why I’m asking. > >Yishay and I are working on a URLLoader class which will behave similar >to the Flash URLLoader class. Is there any reason not to

Re: [FlexJS]Events

2016-07-03 Thread Harbs
For me the important piece is fetching and sending binary data and HTTP codes. (I have a wrapper around it to handle errors, error codes, multipart uploads, etc.) I have not studied the new HTTPService class very well, but the original version was very rigid about the type of data it got. On

Re: [FlexJS]Events

2016-07-03 Thread Alex Harui
Are you going to use XHR on the JS-side? HTMLElementWrapper has a good place to create the XHR and hooked some things in the JS event dispatching that you might also need. We also have a BinaryUploader that might be a good starting point. HTH, -Alex On 7/3/16, 10:02 PM, "Harbs"

Re: [FlexJS]Events

2016-07-03 Thread Harbs
Yes. We’re using XHR. I don’t understand the advantage of using HTMLElementWrapper. I think all we need is a simple event dispatcher which extending the Flex EventDispatcher seems to do. As far as the events go, we’re handling the XHR events within the class and dispatching separate generic