Re: [FlexJS] Debugging package

2017-07-16 Thread Josh Tynjala
The compiler needs to be modified to support the debugger statement. Ideally, it would also force Flash to pause in the debugger. - Josh On Jul 16, 2017 2:07 AM, "Harbs" wrote: I just added a debugging package to FlexJS. There are two things I don’t know how to do: 1.

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
Because it’s not being imported by CoreClasses. What is making Maven import it? > On Jul 16, 2017, at 6:25 PM, piotrz wrote: > > Let's create jira for that. I'm surprise that Ant build is not complaining > about that. Why? > > Piotr > > > > - > Apache Flex

[FlexJS] Avoiding Language.closure (was Re: [FlexJS] Debugging package)

2017-07-16 Thread Harbs
I figured out the problem. org.apache.flex.utils.callLater has the following code: setTimeout(makeCalls, 0); That compiles to: setTimeout(org.apache.flex.utils.Language.closure(makeCalls, this, 'makeCalls'), 0); When Language.closure is called, it messes up the scope of the calls variable and

Re: [FlexJS] Falcon AsJS Mismatch?

2017-07-16 Thread Harbs
Is this with Alex’s latest changes? These backslash escapes seem really difficult to get right… :-( > On Jul 16, 2017, at 2:41 PM, yishayw wrote: > > Looks like falcon is incompatible with TabStopsPropety.as in TLF. When > initializing that file I'm getting the

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
I just added an example project (maybe it should have gone into manual tests?). Interesting to note: Adding a number of callLater() calls resulted in only the first one being called in JS. I did not try as a SWF. > On Jul 16, 2017, at 12:24 PM, piotrz wrote: > >

Re: [FlexJS] Debugging package

2017-07-16 Thread Josh Tynjala
If it were a variable or function, it could be defined somewhere like that. It's a statement, though, so it needs to be added to where Falcon creates the AST from the ActionScript code. Then, it also needs to emit the statement as JS in FalconJX. On the SWF side, it should be translated to

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
That’s beyond me. One day maybe I’ll be up to fiddling with the compiler like that, but I’m not there yet… I’d think nothing needs to be done on the SWF side (unless we need to support debugger; in client code unwrapped). Right now, here’s what I have: COMPILE::SWF {

RE: [FlexJS] Falcon AsJS Mismatch?

2017-07-16 Thread Yishay Weiss
Yea, flex-falcon is up2date. My ‘fix’ was to change TabStopsProperty.as:191 to private static const _escapeBackslashRegex:RegExp = new RegExp("\\" + "\\", "g"); I’m not pushing this yet so Alex or others can debug the RTE. From: Harbs Sent: Sunday,

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
That import should have been commented out in CoreClasses and it should not be compiled. Does Maven work differently? > On Jul 16, 2017, at 3:02 PM, piotrz wrote: > > Harbs, > > I just tried compile FlexJS by Maven and got following error in core: > >

Re: [FlexJS] Debugging package

2017-07-16 Thread piotrz
Harbs, I just tried compile FlexJS by Maven and got following error in core: conditionalBreak.as(43): col: 17 Access of possibly undefined property debugger. debugger; ^ Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-07-16 Thread Harbs
I renamed the branch. > On Jul 16, 2017, at 12:11 PM, piotrz wrote: > > You are doing core changes. Monitoring it on jenkins would be great. Apart of > that I can check some examples without building it locally. > > Piotr > > > > - > Apache Flex PMC >

[FlexJS] Falcon AsJS Mismatch?

2017-07-16 Thread yishayw
Looks like falcon is incompatible with TabStopsPropety.as in TLF. When initializing that file I'm getting the following RTE: Uncaught syntax error: Invalid regular expression: missing / which originates in TabStopsProperty.as:191 private static const

FYI: React appears to be a no-no

2017-07-16 Thread Harbs
The incompatibility of React’s license is potentially significant for FlexJS.[1] [1]https://issues.apache.org/jira/browse/LEGAL-319

Re: [FlexJS] Debugging package

2017-07-16 Thread piotrz
I don't have free cycle right now, but I have some plan to look into compiler and learn things. Jira need to be created to track this issue. Till it's failing we should comment it out. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: FlexJS MXML ids and classNames - FLEX-35310

2017-07-16 Thread piotrz
Josh, In general if I correct understand that was your idea. I think it is the simpler solution where we - Stop set up "id" to HTML id - Introduce new property which will set up it in html +1 for Josh's idea. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message

Re: [FlexJS] Falcon AsJS Mismatch?

2017-07-16 Thread Alex Harui
Someone else is welcome to take over. This stuff is not something I enjoy doing at all. -Alex On 7/16/17, 5:17 AM, "Harbs" wrote: >Is this with Alex’s latest changes? > >These backslash escapes seem really difficult to get right… :-( > >> On Jul 16, 2017, at 2:41 PM,

Re: [FlexJS] Debugging package

2017-07-16 Thread piotrz
Let's create jira for that. I'm surprise that Ant build is not complaining about that. Why? Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Debugging-package-tp63288p63306.html Sent from the

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
What needs to be modified? Does it need to be added to NativeJSType enums? Somewhere else? I’m really not clear on when things to be added to that and when they need to be in typedefs. > On Jul 16, 2017, at 6:51 PM, Harbs wrote: > >> The compiler needs to be modified

Re: FYI: React appears to be a no-no

2017-07-16 Thread Dave Fisher
Hi - The RocksDB community is changing their license and React is being asked to as well: https://github.com/facebook/react/issues/10191 Let's see how this plays out. Regards, Dave Sent from my iPhone > On Jul 16, 2017, at 6:19 AM, Harbs wrote: > > The

Re: [FlexJS] Falcon AsJS Mismatch?

2017-07-16 Thread Harbs
I wasn’t complaining. I was sympathizing. If I knew how, I’d help. Harbs > On Jul 16, 2017, at 6:30 PM, Alex Harui wrote: > > Someone else is welcome to take over. This stuff is not something I enjoy > doing at all. > > -Alex > > On 7/16/17, 5:17 AM, "Harbs"

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
I added flash.debugger.enterDebugger(); on the SWF side. I have not yet tested it, but it’s *supposed* to work… > On Jul 16, 2017, at 6:34 PM, Josh Tynjala wrote: > > The compiler needs to be modified to support the debugger statement. > > Ideally, it would also force

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-07-16 Thread piotrz
Hi Harbs, Is it possible move this branch to existing folder feature? Once you do this I can creat same branch for Falcon and Typedefs - It will be then automatically build on Maven pipelines. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: Moonshine 1.5.0 Release

2017-07-16 Thread yishayw
I couldn't find the windows installer. -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Moonshine-1-5-0-Release-tp63237p63284.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

[FlexJS] Debugging package

2017-07-16 Thread Harbs
I just added a debugging package to FlexJS. There are two things I don’t know how to do: 1. The debugging functions should disappear in a release build of JS, but I’m not sure how to make the same thing happen in a release build of SWF. I don’t think a debug config is the solution, because the

Re: [FlexJS] Debugging package

2017-07-16 Thread piotrz
Harbs, It would be great if you could creat Example project which demonstrate how to use those functions. Maybe additionally confluence page. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: Moonshine 1.5.0 Release

2017-07-16 Thread piotrz
Hi Yishay, Does this link working for you [1] [1] http://moonshine-ide.com/downloads/releases/windows/Moonshine-1.5.0.exe Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-07-16 Thread Harbs
I was thinking of doing it in feature, but I did not know if it made sense. I’m not opposed to doing so. > On Jul 16, 2017, at 10:31 AM, piotrz wrote: > > Hi Harbs, > > Is it possible move this branch to existing folder feature? Once you do this > I can creat same

Re: [01/10] git commit: [flex-asjs] [refs/heads/refactor-strand] - Core changes to IStrand

2017-07-16 Thread piotrz
You are doing core changes. Monitoring it on jenkins would be great. Apart of that I can check some examples without building it locally. Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

Re: [FlexJS] Debugging package

2017-07-16 Thread piotrz
Thank you! :) And I really like the idea :) Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Debugging-package-tp63288p63292.html Sent from the Apache Flex Development mailing list archive at

Re: [FlexJS] Debugging package

2017-07-16 Thread Harbs
Yes. Will do when I’m done. > On Jul 16, 2017, at 12:18 PM, piotrz wrote: > > Harbs, > > It would be great if you could creat Example project which demonstrate how > to use those functions. > Maybe additionally confluence page. > > Thanks, > Piotr > > > > -

Re: Moonshine 1.4.0 Release

2017-07-16 Thread piotrz
Yishay, Try to uninstall and clean up folder in AppData related to Moonshine. I don't have anymore such problems. Did you upgrade ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context:

RE: Moonshine 1.5.0 Release

2017-07-16 Thread Yishay Weiss
It does, thanks. From: piotrz Sent: Sunday, July 16, 2017 10:28 AM To: dev@flex.apache.org Subject: Re: Moonshine 1.5.0 Release Hi Yishay, Does this link working for you [1] [1]

Re: Moonshine 1.4.0 Release

2017-07-16 Thread yishayw
I see the same problem with 1.5 -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Moonshine-1-4-0-Release-tp61632p63293.html Sent from the Apache Flex Development mailing list archive at Nabble.com.