RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API

Good catch. You’re correct that we’re not using -compiler.exclude-defaults-css-files anywhere. We have some CSS overrides that take care of the controls we’re using. Generally, we just inspect the DOM and figure out which styles need to be fixed and add those to our CSS. Hopefully, this won’t

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

To me, this is all related to PAYG. And also, coding "style" matters. If we want to allow every possible existing AS statement work as-is, then we must initialize every variable that has a different default in JS. I thought the results of the set of tests I ran was that some of those patterns

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Ah yes, I like your answer better. -Alex On 8/1/17, 2:36 PM, "piotrz" wrote: >Alex, > >I just pushed fix for this issue, but I would love to see what you did >also. >Take a look into my commit where I'm adding "defines" to pom of TLF >module. > >Harbs, > >I did

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

What I mean is that if we can somehow have the values uninitialized in JS, but in all cases where uninitialized values somehow diverge with ActionScript behavior be solved (so the use cases would behave correctly), then we’d have the advantages of undefined together with expected AS behavior.

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

I'll bet that most of time that non-initialized values bite me is when I'm checking if a member variable is null or not. I frequently rely on the fact that Object, String, and most classes default to null, and then I do something like this: if(this._myVar === null) { } I dread the day I need to

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

I’d prefer if we could somehow get the best of both worlds. Sorry Harbs, but I don't get it. I think the agreement is already to 'have the best of both worlds'. The issue is what the default should be. I know that you don't think you could have both behaviours as the default :). If we take away

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Hi, > I think if booleans could fail even non-strict equality checks when they > are not initialized, then we should always initialize booleans, like we > currently do with int and uint. +1 > I would still like the see the compiler initialize everything by default so > that ActionScript behaves

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

I’d prefer if we could somehow get the best of both worlds. I don’t see a solution to that dilemma at the moment, but maybe we’ll come up with something... Harbs > On Aug 2, 2017, at 1:24 AM, Josh Tynjala wrote: > > Don't get me wrong. If you see value in it, then we

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Don't get me wrong. If you see value in it, then we definitely shouldn't remove it as an option. However, for compatibility with the existing language, I'd prefer to see initialization be the default instead. - Josh On Tue, Aug 1, 2017 at 3:14 PM, Harbs wrote: > Any

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Yes it does. NaN is an 'instance' of the Number type (even though it is 'Not a Number' ;) ) On Wed, Aug 2, 2017 at 10:18 AM, Harbs wrote: > Interesting. > > I’m not sure that I realized that NaN passes that test. Does it? > > > On Aug 2, 2017, at 1:12 AM, Greg Dove

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Interesting. I’m not sure that I realized that NaN passes that test. Does it? > On Aug 2, 2017, at 1:12 AM, Greg Dove wrote: > > I agree undefined works the same as NaN for many things for example, but it > fails on very basic things like if (x is Number)

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Any maybe vice versa... ;-p Alex was planning on looking into whether he can solve the boolean problem, so let’s hold off until he does that. I think comparing two booleans is pretty rare although I have already run into if(myBool == false) not working. Changing it to if(!myBool) was simple

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

Maybe I'll convince others eventually. fwiw Josh, I agree with you. I agree undefined works the same as NaN for many things for example, but it fails on very basic things like if (x is Number) that to me is quite wrong and would be quite unexpected for anyone expecting flexjs actionscript

RE: [FlexJS, MDL] Menu with dataProvider and itemRenderer API

Hi Yishay, I've analyzed your stacktrace and I think I understand why it is working in your app and it is not in MDLExample. As I remember from Harbs presentation from ApacheCON that your app is using MDL library along with Basic module. In general when someone would like to build your

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

I think if booleans could fail even non-strict equality checks when they are not initialized, then we should always initialize booleans, like we currently do with int and uint. It doesn't even make sense to make it an option for booleans, if that's the case. It's just broken. I would still like

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Alex, I just pushed fix for this issue, but I would love to see what you did also. Take a look into my commit where I'm adding "defines" to pom of TLF module. Harbs, I did changes for assert.as - could you take a look whether I didn't break any of your existing code ? Thanks, Piotr -

Re: git commit: [flex-falcon] [refs/heads/develop] - compiler-jx: Added -js-default-initializers option to force uninitialized variables to default to the same values in JS as they do in SWF.

One suggestion on this: Instead of making it a simple true/false, I’d suggest a tristate control of true/false/booleans. The reason I’m making that suggestion is because even without strict equality, setting booleans to false has the benefit that bool1 == bool2 will work as expected where

Re: XML hasOwnProperty method

Take a look in XML.js in your js-debug folder. XML.prototype.toAttributeName should look like this: XML.prototype.toAttributeName = function(name) { var /** @type {QName} */ qname; if (!org.apache.flex.utils.Language.is(name, QName)) { name = name.toString(); if (name.indexOf("@") >

Re: Debugger statement

I'll pass that on to my manager, but I don't think that will be the key argument. I've mentioned lots of mx_internal APIs over the years and they were also considered undocumented. My argument right now, which I hope will win, is that discovery of any API, not just this one, by examining open

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Some time ago I've prepared pom for TLF branch and it was working till today. Additionally I thought that additionalCompilerOptions is being passed to compiler as a long string and we don't have to care about splitting anything in code. Ok your fix will allow for many parameters and now we will

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Hi Piotr, These flags are only used by TLF, but TLF was building just fine for a while. I agree that the current failures appear unrelated, but I want to get it to build locally in order to compare working vs not-working. AFAICT, you can't specify more than one option in

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Hi Alex, I don't recall that we have used CONFIG::debug or CONFIG::release somewhere earlier. My thought that if we have ever used and it's defined in loaded config - Maven shouldn't complain. I think in order to use it we have to put them in "additionalCompilerOptions" in pom, but maybe there

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Hi Piotr, Which loaded config had these settings? I was unable to define those flags in the Maven pom without changing the BaseMojo. I have those fixes locally, but I'm trying to understand how this ever worked so we are more sure my proposed changes don't duplicate something or something else

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Hi Josh, I thought that if we have it declared in loaded config, it should not be any problems. [1] I will try to declare it in Maven pom. [1] https://github.com/apache/flex-asjs/blob/develop/frameworks/projects/TLF/src/main/config/compile-swf-config.xml Piotr - Apache Flex PMC

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

It looks like assert.as uses CONFIG::debug and CONFIG::release. Are those defined in the compiler options for Maven? - Josh On Tue, Aug 1, 2017 at 12:59 AM, piotrz wrote: > Hi Alex, > > I just tried and yes it's also failing for me in TLF [1]. But on Jenkins it >

Re: Debugger statement

Would it be helpful if someone from Adobe talked about flash.debugger.enterDebugger() publicly? I assume that user mmorearty on the official Adobe forums may be Mike Morearty from the Flex team, and he mentions it in this thread: https://forums.adobe.com/thread/247021 - Josh On Mon, Jul 31,

Re: Moonshine 1.5.1 Released

Go ahead! > On Aug 1, 2017, at 3:23 PM, piotrz wrote: > > Team, > > It is worth to mention this one on or Fan page and twitter again - any > objections ? > > Thanks, > Piotr > > > > - > Apache Flex PMC > piotrzarzyck...@gmail.com > -- > View this message in

Re: Moonshine 1.5.1 Released

Team, It is worth to mention this one on or Fan page and twitter again - any objections ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/Moonshine-1-5-1-Released-tp63623p63625.html Sent from

Re: [MAVEN-BUILD] FlexJS Framework (maven) - Build # 1129 - Still Failing

Hi Alex, I just tried and yes it's also failing for me in TLF [1]. But on Jenkins it look like it is failing at the beginning, so it something else there. [1] https://paste.apache.org/tvD7 Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: