Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
We don't do any rewriting right now, but we might be able to rewrite them in the future. One warning I see is from this code: /** * @export * @type {org.apache.flex.core.WrappedHTMLElement} */ positioner: { get: org.apache.flex.core.UIBase.prototype.get__positioner, set:

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
Alex, What do you mean by rewriting those getter/setters ? Could you point to an some example ? Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Closure-warnings-tp63939p63944.html Sent

Re: FlexJS Closure warnings

2017-08-22 Thread Alex Harui
Some are from Closure Library. I haven't really looked into why. I don't think we are on the absolute latest, so we might need to move there. Others are from our code because we are now annotating the Object.defineProperties getter/setters with @type information, but we don't force the inclusion

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
.n4.nabble.com/FlexJS-Closure-warnings-tp63939p63942.html Sent from the Apache Flex Development mailing list archive at Nabble.com.

Re: FlexJS Closure warnings

2017-08-22 Thread Josh Tynjala
I remember seeing that Alex updated to a newer version of Closure compiler recently. I don't recall if he updated Closure library at the same time. As I understand it, it's a good idea to keep them both in sync. - Josh On Aug 22, 2017 3:43 AM, "Harbs" wrote: > I’ve been

Re: FlexJS Closure warnings

2017-08-22 Thread piotrz
Hi Harbs, I can confirm that I have also a lot of warnings in Maven build. Even with simple project. Thanks, Piotr - Apache Flex PMC piotrzarzyck...@gmail.com -- View this message in context: http://apache-flex-development.247.n4.nabble.com/FlexJS-Closure-warnings-tp63939p63940

FlexJS Closure warnings

2017-08-22 Thread Harbs
I’ve been getting hundreds of warnings when FlexJS runs GCC. It’s kind of weird that the errors seem to be in the Google library files. FlexJSStore generates 119 warnings for me. My app generates over 300 warnings. Some of additional ones are in the typedef files. Harbs