[jira] [Created] (FLINK-6269) var could be a val

2017-04-05 Thread CanBin Zheng (JIRA)
CanBin Zheng created FLINK-6269: --- Summary: var could be a val Key: FLINK-6269 URL: https://issues.apache.org/jira/browse/FLINK-6269 Project: Flink Issue Type: Wish Components:

Re: [DISCUSS] Code style / checkstyle

2017-04-05 Thread Chesnay Schepler
I agree to just allow both. While I definitely prefer 1) i can see why someone might prefer 2). Wouldn't want to delay this anymore; can't find to add this to flink-metrics and flink-python... On 03.04.2017 18:33, Aljoscha Krettek wrote: I think enough people did already look at the

Re: [DISCUSS] FLIP-18: Code Generation for improving sorting performance

2017-04-05 Thread Greg Hogan
Pat, Thanks for running additional tests and continuing to work on this contribution. My testing is also showing that the performance gains remain even when multiple classes are used for sorting. I think we should proceed in the order of FLINK-3722, FLINK-4705, and FLINK-5734. Gabor has

Re: [DISCUSS] Code style / checkstyle

2017-04-05 Thread Greg Hogan
Could we use Aljoscha’s proposed checkstyle [0] as a baseline for discussion? It does not define a line length and we could bid down from there. Chesnay not only reviewed the changes but summarized the checkstyle [1]: It enforces the following rules: • every file has to end with a

[jira] [Created] (FLINK-6268) Object reuse for Either type

2017-04-05 Thread Greg Hogan (JIRA)
Greg Hogan created FLINK-6268: - Summary: Object reuse for Either type Key: FLINK-6268 URL: https://issues.apache.org/jira/browse/FLINK-6268 Project: Flink Issue Type: Improvement

Re: [VOTE] Release Apache Flink 1.2.1 (RC1)

2017-04-05 Thread Ufuk Celebi
@Stefan: What's the state with the RocksDB fixes? I would be +1 to do this. On Tue, Apr 4, 2017 at 6:05 PM, Chesnay Schepler wrote: > Yes, aljoscha already opened one against master: > https://github.com/apache/flink/pull/3670 > > On 04.04.2017 17:57, Ted Yu wrote: >> >>

[jira] [Created] (FLINK-6267) Remove the useless import in FlinkRelBuilder

2017-04-05 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6267: -- Summary: Remove the useless import in FlinkRelBuilder Key: FLINK-6267 URL: https://issues.apache.org/jira/browse/FLINK-6267 Project: Flink Issue Type:

[jira] [Created] (FLINK-6266) Remove the useless import in FlinkRelBuilder

2017-04-05 Thread sunjincheng (JIRA)
sunjincheng created FLINK-6266: -- Summary: Remove the useless import in FlinkRelBuilder Key: FLINK-6266 URL: https://issues.apache.org/jira/browse/FLINK-6266 Project: Flink Issue Type: