Re: [DISCUSS] Switch docker iamge base to Eclipse Temurin

2022-08-31 Thread Xingbo Huang
Thanks Chesnay for driving this. I found a problem with image name change[1] and I have created a PR[2] to fix it. Best, Xingbo [1] https://issues.apache.org/jira/browse/FLINK-29161 [2] https://github.com/apache/flink/pull/20726 Chesnay Schepler 于2022年8月31日周三 17:15写道: > I will optimistically

Re: [DISCUSS] FLIP-256 Support Job Dynamic Parameter With Flink Rest Api

2022-08-31 Thread Zheng Yu Chen
Hi @Hong As @Chesnay said, we just follow the same order that the CLI currently enforces. @ Gyula and me agree this sugget, It also makes sense to mention that this FLIP is not about the prioritization of config options. so this feature maybe do this filp and after discuss , not now After the

[jira] [Created] (FLINK-29163) There is a problem when compiling Flink 1.15.rc-2 and flink-1.14.3-rc1 in Windows operations

2022-08-31 Thread mindest liu (Jira)
mindest liu created FLINK-29163: --- Summary: There is a problem when compiling Flink 1.15.rc-2 and flink-1.14.3-rc1 in Windows operations Key: FLINK-29163 URL: https://issues.apache.org/jira/browse/FLINK-29163

[jira] [Created] (FLINK-29162) missCounter and loadCount metrics also increase even if cache hint

2022-08-31 Thread dalongliu (Jira)
dalongliu created FLINK-29162: - Summary: missCounter and loadCount metrics also increase even if cache hint Key: FLINK-29162 URL: https://issues.apache.org/jira/browse/FLINK-29162 Project: Flink

[jira] [Created] (FLINK-29161) Run kubernetes application HA test failed with unable to prepare context: path "dev/test_kubernetes_application_ha-debian" not found

2022-08-31 Thread Xingbo Huang (Jira)
Xingbo Huang created FLINK-29161: Summary: Run kubernetes application HA test failed with unable to prepare context: path "dev/test_kubernetes_application_ha-debian" not found Key: FLINK-29161 URL:

[jira] [Created] (FLINK-29160) 在windows 编译flink 1.15.rc-2时出现问题

2022-08-31 Thread mindest liu (Jira)
mindest liu created FLINK-29160: --- Summary: 在windows 编译flink 1.15.rc-2时出现问题 Key: FLINK-29160 URL: https://issues.apache.org/jira/browse/FLINK-29160 Project: Flink Issue Type: Bug

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Yu Li
*bq. a list of all breaking changes between 1.15.0 and the latest 1.15.x (or intermediate releases)* Yes, this might help users to be more prepared before upgrading, if they could know whether need to recompile their applications. Asking about 1.14/1.15 since they are the "in service" versions.

[jira] [Created] (FLINK-29159) Revisit/harden initial deployment logic

2022-08-31 Thread Thomas Weise (Jira)
Thomas Weise created FLINK-29159: Summary: Revisit/harden initial deployment logic Key: FLINK-29159 URL: https://issues.apache.org/jira/browse/FLINK-29159 Project: Flink Issue Type:

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Chesnay Schepler
Well then someone didnt update the FLIP number as they should! I'll increment the number of this FLIP to 255. On 31/08/2022 15:06, Matthias Pohl wrote: +1 for bringing this into a consistent state. Thanks, Chesnay. nit: There's a conflict between this FLIP-254 and the FLIP-254 on the redis

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Matthias Pohl
+1 for bringing this into a consistent state. Thanks, Chesnay. nit: There's a conflict between this FLIP-254 and the FLIP-254 on the redis streams connector. On Wed, Aug 31, 2022 at 2:52 PM Chesnay Schepler wrote: > * backport to 1.14/1.15 > > On 31/08/2022 14:45, Chesnay Schepler wrote: > >

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Chesnay Schepler
* backport to 1.14/1.15 On 31/08/2022 14:45, Chesnay Schepler wrote: @Yu I haven't really considered 1.14/1.15. What exactly are you interested in; a list of all breaking changes between 1.15.0 and the latest 1.15.x (or intermediate releases), or are you suggesting to also backport this whole

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Chesnay Schepler
@Yu I haven't really considered 1.14/1.15. What exactly are you interested in; a list of all breaking changes between 1.15.0 and the latest 1.15.x (or intermediate releases), or are you suggesting to also backport this whole thing to 1.16 (which should be possible)? On 31/08/2022 13:31, Yu

Re: [DISCUSS] FLIP-254 Redis Streams connector

2022-08-31 Thread Konstantin Knauf
Hi Martijn, Hi Mohammad, thanks for creating this FLIP. I am wondering, do you know how much Redis Streams are used compared to other Redis data structures? At least as a sink and LookupTableSource supporting regular Redis data structures seems quite useful. I suppose such connectors would live

Re: [DISCUSS] FLIP-254 Redis Streams connector

2022-08-31 Thread Martijn Visser
Hi everyone, Last call for comments, else I'll open up a VOTE thread later this week. Best regards, Martijn Op ma 1 aug. 2022 om 15:40 schreef Martijn Visser : > Hi everyone, > > Together with Mohammad we would like to start a discussion thread on > FLIP-254 for a Redis Streams connector.

[GitHub] [flink-connector-rabbitmq] MartijnVisser commented on pull request #1: [FLINK-20628] RabbitMQ Connector using FLIP-27 Source API

2022-08-31 Thread GitBox
MartijnVisser commented on PR #1: URL: https://github.com/apache/flink-connector-rabbitmq/pull/1#issuecomment-1232836643 @pscls Weird. Could you push once more, since the logs are no longer available? -- This is an automated message from the Apache Git Service. To respond to the

Re: Re: Re: Re: Re: [DISCUSS] FLIP-239: Port JDBC Connector Source to FLIP-27

2022-08-31 Thread Martijn Visser
It would be great if João could help finalize the PR. In case he doesn't have the permission to update the FLIP, please reach out to me so we can get that sorted. Op wo 10 aug. 2022 om 04:41 schreef Roc Marshal : > Hi, > Martijn, Boto. > I just complete the design of the source and the skeleton

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Yu Li
+1 for the FLIP. Thanks for the efforts Chesnay. I believe ensuring binary compatibility for patch releases will also benefit our end users besides the cloud service providers. I'm also wondering about the compatibility checking result after enabling japicmp for all modules with existing patch

[jira] [Created] (FLINK-29158) Fix logging in DefaultCompletedCheckpointStore

2022-08-31 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-29158: - Summary: Fix logging in DefaultCompletedCheckpointStore Key: FLINK-29158 URL: https://issues.apache.org/jira/browse/FLINK-29158 Project: Flink

[jira] [Created] (FLINK-29157) Clarify the contract between CompletedCheckpointStore and SharedStateRegistry

2022-08-31 Thread Roman Khachatryan (Jira)
Roman Khachatryan created FLINK-29157: - Summary: Clarify the contract between CompletedCheckpointStore and SharedStateRegistry Key: FLINK-29157 URL: https://issues.apache.org/jira/browse/FLINK-29157

Re: [DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Konstantin Knauf
Hi Chesnay, thanks for bringing this up and for your research and fixes to japicmd. +1 for the proposal. For Immerok as an Apache Flink cloud service provider it is very valuable to know that our users don't need to upgrade their Jobs when the Flink patch version changes. I am sure the same is

[DISCUSS] FLIP-254 Guarantee binary compatibility for Public/-Evolving APIs between patch releases

2022-08-31 Thread Chesnay Schepler
Hello, I just published a FLIP to guarantee binary compatibility for patch releases. I don't think our current guarantees of source-compatibility are sufficient for patch releases. https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=225152857 Let me know what you think.

Re: [DISCUSS] Switch docker iamge base to Eclipse Temurin

2022-08-31 Thread Chesnay Schepler
I will optimistically merge the PRs that make the switch so we can gather some e2e testing data. On 30/08/2022 14:51, Chesnay Schepler wrote: yes, alpine would have similar issues as CentOS. As for usability, from personal experience it has always been a bit of a drag to extend or use

[jira] [Created] (FLINK-29156) Support LISTAGG in the Table API

2022-08-31 Thread zhangjingcun (Jira)
zhangjingcun created FLINK-29156: Summary: Support LISTAGG in the Table API Key: FLINK-29156 URL: https://issues.apache.org/jira/browse/FLINK-29156 Project: Flink Issue Type: New Feature

Re: [Discuss] KafkaSink making low level components PublicEvolving

2022-08-31 Thread Piotr Nowojski
Hi Mason, Thanks for the clarification and great that you have found a workaround :) I would be personally ok with making it `public class` marked as `@Internal` if needed. Best, Piotrek śr., 31 sie 2022 o 01:35 Mason Chen napisał(a): > Hi Piotr, > > The reasoning makes sense to me. I

Re: [VOTE] FLIP-243: Dedicated Opensearch connectors

2022-08-31 Thread Danny Cranmer
Thanks for putting this together Andy. I missed the discussion but would like to propose you consider using the Async Sink (FLIP-171) for the sink implementation on top of the sink v2 interfaces. +1 (binding) Thanks, Danny On Thu, Aug 18, 2022 at 8:06 AM Matthias Pohl wrote: > I'm gonna

[jira] [Created] (FLINK-29155) Improve default config of grpcServer in Process Mode

2022-08-31 Thread Xingbo Huang (Jira)
Xingbo Huang created FLINK-29155: Summary: Improve default config of grpcServer in Process Mode Key: FLINK-29155 URL: https://issues.apache.org/jira/browse/FLINK-29155 Project: Flink Issue

[jira] [Created] (FLINK-29154) Support LookupTableSource for table store

2022-08-31 Thread Jingsong Lee (Jira)
Jingsong Lee created FLINK-29154: Summary: Support LookupTableSource for table store Key: FLINK-29154 URL: https://issues.apache.org/jira/browse/FLINK-29154 Project: Flink Issue Type: New

Re: [flink-connector-elasticsearch] Supporting ElasticSearch 8 & Dropping ES 6 ?

2022-08-31 Thread Niels Basjes
Ok, that's a bit bigger than I thought. On Tue, Aug 30, 2022 at 10:03 AM Martijn Visser wrote: > Hi Niels, > > With regards to ES support, we should follow the supported version that ES > supports [1]. So if we add support for ES8, we drop support for ES6. > > With regards to the used clients,

[jira] [Created] (FLINK-29153) KafkaConsumerThread should catch WakeupException when committing offsets

2022-08-31 Thread Qingsheng Ren (Jira)
Qingsheng Ren created FLINK-29153: - Summary: KafkaConsumerThread should catch WakeupException when committing offsets Key: FLINK-29153 URL: https://issues.apache.org/jira/browse/FLINK-29153 Project:

[jira] [Created] (FLINK-29152) Describe statement resutls is different from the Hive

2022-08-31 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29152: - Summary: Describe statement resutls is different from the Hive Key: FLINK-29152 URL: https://issues.apache.org/jira/browse/FLINK-29152 Project: Flink

[jira] [Created] (FLINK-29151) SHOW CREATE TABLE doesn't work for Hive dialect

2022-08-31 Thread Shengkai Fang (Jira)
Shengkai Fang created FLINK-29151: - Summary: SHOW CREATE TABLE doesn't work for Hive dialect Key: FLINK-29151 URL: https://issues.apache.org/jira/browse/FLINK-29151 Project: Flink Issue

[jira] [Created] (FLINK-29150) TIMESTAMPDIFF microsecond unit for table api

2022-08-31 Thread jackylau (Jira)
jackylau created FLINK-29150: Summary: TIMESTAMPDIFF microsecond unit for table api Key: FLINK-29150 URL: https://issues.apache.org/jira/browse/FLINK-29150 Project: Flink Issue Type: Bug