[jira] [Created] (FLINK-30516) Add file count and row count in snapshots table

2022-12-27 Thread Shammon (Jira)
Shammon created FLINK-30516: --- Summary: Add file count and row count in snapshots table Key: FLINK-30516 URL: https://issues.apache.org/jira/browse/FLINK-30516 Project: Flink Issue Type: Sub-task

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2022-12-27 Thread Jane Chan
Hi @yuxia, Thank you for reviewing the FLIP and raising questions. 1: Is the PlanAnalyzerFactory also expected to be implemented by users just > like DynamicTableSourceFactory or other factories? If so, I notice that in > the code of PlanAnalyzerManager#registerAnalyzers, the code is as follows:

[jira] [Created] (FLINK-30515) Add benchmark for CountVectorizer, Imputer, RobustScaler, UnivariateFeatureSelector and VarianceThresholdSelector

2022-12-27 Thread Jiang Xin (Jira)
Jiang Xin created FLINK-30515: - Summary: Add benchmark for CountVectorizer, Imputer, RobustScaler, UnivariateFeatureSelector and VarianceThresholdSelector Key: FLINK-30515 URL:

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-27 Thread Jing Zhang
Hi Biao, Thanks for driving this FLIP. It's meaningful to support speculative execution of sinks is important. I have a question about this: Speculative execution of Committer will be disabled. I agree with your point and I saw the similar requirements to disable speculative execution for

Re: [DISCUSS] FLIP-282: Introduce Delete & Update API

2022-12-27 Thread Lincoln Lee
Hi yuxia, Thanks for the proposal! I think it'll be very useful for users in batch scenarios to cooperate with external systems. For the flip I have two questions: 1. Is it a typo the default method 'default ScanPurpose getScanPurpose();' without implementation in interface ScanContext? 2. For

Re: [DISCUSS] FLIP-266: Simplify network memory configurations for TaskManager

2022-12-27 Thread Roman Khachatryan
Hi everyone, Thanks for the proposal and the discussion. I couldn't find much details on how exactly the values of ExclusiveBuffersPerChannel and FloatingBuffersPerGate are calculated. I guess that - the threshold evaluation is done on JM - floating buffers calculation is done on TM based on the

[jira] [Created] (FLINK-30514) HybridSource savepoint recovery sequence

2022-12-27 Thread Denis Golovachev (Jira)
Denis Golovachev created FLINK-30514: Summary: HybridSource savepoint recovery sequence Key: FLINK-30514 URL: https://issues.apache.org/jira/browse/FLINK-30514 Project: Flink Issue Type:

[jira] [Created] (FLINK-30513) HA storage dir leaks on cluster termination

2022-12-27 Thread Zhanghao Chen (Jira)
Zhanghao Chen created FLINK-30513: - Summary: HA storage dir leaks on cluster termination Key: FLINK-30513 URL: https://issues.apache.org/jira/browse/FLINK-30513 Project: Flink Issue Type:

Re: [DISCUSS] FLIP-280: Introduce a new explain mode to provide SQL advice

2022-12-27 Thread yuxia
Thanks for driving this FLIP. It should be a good improvement to users. But I have few questions: 1: Is the PlanAnalyzerFactory also expected to be implemented by users just like DynamicTableSourceFactory or other factories? If so, I notice that in the code of

[jira] [Created] (FLINK-30512) Flink SQL state TTL has no effect when using Interval Join

2022-12-27 Thread wangkang (Jira)
wangkang created FLINK-30512: Summary: Flink SQL state TTL has no effect when using Interval Join Key: FLINK-30512 URL: https://issues.apache.org/jira/browse/FLINK-30512 Project: Flink Issue

[jira] [Created] (FLINK-30511) Ignore the Exception in user-timer Triggerble when recover form state.

2022-12-27 Thread RocMarshal (Jira)
RocMarshal created FLINK-30511: -- Summary: Ignore the Exception in user-timer Triggerble when recover form state. Key: FLINK-30511 URL: https://issues.apache.org/jira/browse/FLINK-30511 Project: Flink

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-27 Thread Lijie Wang
Hi Biao, Thanks for driving this FLIP. In this FLIP, it introduces "int getFinishedAttempt(int subtaskIndex)" for OutputFormat to know which subtask attempt is the one marked as finished by JM and commit the right data. I have a question about this: does SinkV2 need to do the same thing? Should

[jira] [Created] (FLINK-30510) Allow configuring minimum and maximum metrics window size

2022-12-27 Thread Maximilian Michels (Jira)
Maximilian Michels created FLINK-30510: -- Summary: Allow configuring minimum and maximum metrics window size Key: FLINK-30510 URL: https://issues.apache.org/jira/browse/FLINK-30510 Project: Flink

Re: [DISCUSS] Extending the feature freezing date of Flink 1.17

2022-12-27 Thread Xintong Song
Thanks QIngsheng, +1 for extending the feature freeze date to Jan 31st. I'm aware of several feature developing threads that are struggling to catch the deadline. Extending the freeze date would help avoid halfly-cooked features and last-minute rushes. Moreover, I believe most of the

[jira] [Created] (FLINK-30509) Modify sql-client.sh

2022-12-27 Thread yuzelin (Jira)
yuzelin created FLINK-30509: --- Summary: Modify sql-client.sh Key: FLINK-30509 URL: https://issues.apache.org/jira/browse/FLINK-30509 Project: Flink Issue Type: Sub-task Components: Table

[RESULT][VOTE] FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records

2022-12-27 Thread Dong Lin
Hi all, I am happy to announce that FLIP-208: Add RecordEvaluator to dynamically stop source based on de-serialized records [1] has been accepted. The FLIP was voted in this thread [2]. There are 3 binding votes and 1 non-binding vote: - Qingsheng Ren (binding) - Leonard Xu (binding) - Dong Lin

[DISCUSS] Extending the feature freezing date of Flink 1.17

2022-12-27 Thread Qingsheng Ren
Hi devs, I'd like to make a proposal of extending the feature freezing date of Flink 1.17 by two weeks, to January 31st, 2023. With feedback release managers gathered these days and the ongoing pandemic in China, one extra week would make it easier for developers to finish their work. Also