Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

2023-12-18 Thread Alan Sheinberg
Thanks for the helpful comments, Xuyang and Timo. @Timo, @Alan: IIUC, there seems to be something wrong here. Take kafka as > source and mysql as sink as an example. > Although kafka is an append-only source, one of its fields is used as pk > when writing to mysql. If async udx is executed > in

Re: 退订

2023-12-18 Thread Hang Ruan
Please send email to user-unsubscr...@flink.apache.org if you want to unsubscribe the mail from u...@flink.apache.org, and you can refer [1][2] for more details. 请发送任意内容的邮件到 user-unsubscr...@flink.apache.org 地址来取消订阅来自 u...@flink.apache.org 邮件组的邮件,你可以参考[1][2] 管理你的邮件订阅。 Best, Hang [1]

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Jiabao Sun
Thanks Becket for the suggestions, Updated. Please help review it again when you have time. Best, Jiabao > 2023年12月19日 09:06,Becket Qin 写道: > > Hi JIabao, > > Thanks for updating the FLIP. It looks better. Some suggestions / questions: > > 1. In the motivation section: > >> *Currently,

[jira] [Created] (FLINK-33878) Many Keyed Operator extends `TableStreamOperator` which is marked without key.

2023-12-18 Thread xuyang (Jira)
xuyang created FLINK-33878: -- Summary: Many Keyed Operator extends `TableStreamOperator` which is marked without key. Key: FLINK-33878 URL: https://issues.apache.org/jira/browse/FLINK-33878 Project: Flink

Re:Re:Re: [DISCUSS] FLIP-392: Deprecate the Legacy Group Window Aggregation

2023-12-18 Thread Xuyang
Hi, Timo. Sorry for this noise. What do you think about splitting the flip like this? -- Best! Xuyang At 2023-12-15 10:05:32, "Xuyang" wrote: >Hi, Timo, thanks for your advice. > > >I am considering splitting the existing flip into two while leaving the >existing flip (or

[jira] [Created] (FLINK-33877) CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException

2023-12-18 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33877: -- Summary: CollectSinkFunctionTest.testConfiguredPortIsUsed fails due to BindException Key: FLINK-33877 URL: https://issues.apache.org/jira/browse/FLINK-33877 Project:

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Becket Qin
Hi JIabao, Thanks for updating the FLIP. It looks better. Some suggestions / questions: 1. In the motivation section: > *Currently, Flink Table/SQL does not expose fine-grained control for users > to control filter pushdown. **However, filter pushdown has some side > effects, such as additional

Re: [DISCUSS] Release Flink 1.18.1

2023-12-18 Thread Jing Ge
Hi folks, Found another blocker issue for 1.18: https://github.com/apache/flink/pull/23950. Thanks Sergey for the heads-up. Best regards, Jing On Mon, Dec 18, 2023 at 5:02 PM Jing Ge wrote: > Hi, > > I am waiting for the CI of > https://issues.apache.org/jira/browse/FLINK-33872 @Hong. It

Re: [DISCUSS] Release Flink 1.18.1

2023-12-18 Thread Jing Ge
Hi, I am waiting for the CI of https://issues.apache.org/jira/browse/FLINK-33872 @Hong. It would be great if anyone would like to review the PR. Thanks. 1.18.1-rc1 release will be canceled because of https://issues.apache.org/jira/browse/FLINK-33704, I will start with rc2 once FLINK-33872 has

[jira] [Created] (FLINK-33876) [JUnit5 Migration] Introduce testName method in TableTestBase

2023-12-18 Thread Jiabao Sun (Jira)
Jiabao Sun created FLINK-33876: -- Summary: [JUnit5 Migration] Introduce testName method in TableTestBase Key: FLINK-33876 URL: https://issues.apache.org/jira/browse/FLINK-33876 Project: Flink

退订

2023-12-18 Thread 唐大彪
退订

Re: Request permission for creating a new FLIP page

2023-12-18 Thread Martijn Visser
Hi Jinsui, You should now have permissions. Best regards, Martijn On Mon, Dec 18, 2023 at 1:56 PM Jinsui Chen wrote: > > hi, all > > I want to add a new connector for Flink (see FLINK-33873). For this level > of change a new FLIP page needs to be created, but I don't have the > corresponding

[jira] [Created] (FLINK-33875) Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
RocMarshal created FLINK-33875: -- Summary: Support slots wait mechanism at DeclarativeSlotPoolBridge side for Default Scheduler Key: FLINK-33875 URL: https://issues.apache.org/jira/browse/FLINK-33875

[jira] [Created] (FLINK-33874) Introduce resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler

2023-12-18 Thread RocMarshal (Jira)
RocMarshal created FLINK-33874: -- Summary: Introduce resource request wait mechanism at DefaultDeclarativeSlotPool side for Default Scheduler Key: FLINK-33874 URL: https://issues.apache.org/jira/browse/FLINK-33874

Request permission for creating a new FLIP page

2023-12-18 Thread Jinsui Chen
hi, all I want to add a new connector for Flink (see FLINK-33873). For this level of change a new FLIP page needs to be created, but I don't have the corresponding permissions. Following the instructions in the FLIP document, I sent this email. Could anyone help me with this? Thanks, Jinsui

Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

2023-12-18 Thread Gyula Fóra
+1 (binding) Gyula On Mon, 18 Dec 2023 at 13:04, Márton Balassi wrote: > +1 (binding) > > On Mon 18. Dec 2023 at 09:34, Péter Váry > wrote: > > > Hi everyone, > > > > Since there were no further comments on the discussion thread [1], I > would > > like to start the vote for FLIP-372 [2]. > >

Re: [VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

2023-12-18 Thread Márton Balassi
+1 (binding) On Mon 18. Dec 2023 at 09:34, Péter Váry wrote: > Hi everyone, > > Since there were no further comments on the discussion thread [1], I would > like to start the vote for FLIP-372 [2]. > > The FLIP started as a small new feature, but in the discussion thread and > in a similar

[jira] [Created] (FLINK-33873) Create a Redis HyperLogLog Connector for Flink

2023-12-18 Thread Jinsui Chen (Jira)
Jinsui Chen created FLINK-33873: --- Summary: Create a Redis HyperLogLog Connector for Flink Key: FLINK-33873 URL: https://issues.apache.org/jira/browse/FLINK-33873 Project: Flink Issue Type: New

[jira] [Created] (FLINK-33872) Checkpoint history does not display for completed jobs

2023-12-18 Thread Hong Liang Teoh (Jira)
Hong Liang Teoh created FLINK-33872: --- Summary: Checkpoint history does not display for completed jobs Key: FLINK-33872 URL: https://issues.apache.org/jira/browse/FLINK-33872 Project: Flink

Re: Question on lookup joins

2023-12-18 Thread Benchao Li
I don't see a problem in the result. Since you are using LEFT JOIN, the NULLs are expected where there is no matching result in the right table. Hang Ruan 于2023年12月18日周一 09:39写道: > > Hi, David. > > The FLIP-377[1] is about this part. You could take a look at it. > > Best, > Hang > > [1] >

Re: [DISCUSS] Release Flink 1.18.1

2023-12-18 Thread Jing Ge
Hi folks, Thanks Martijn for driving the https://issues.apache.org/jira/browse/FLINK-33704, which will solve the issue of https://issues.apache.org/jira/browse/FLINK-33793. I will move forward with the 1.18.1 release today. Best regards, Jing On Thu, Dec 14, 2023 at 11:17 AM Jing Ge wrote: >

Re: [DISCUSS] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

2023-12-18 Thread Timo Walther
Hi Xuyang and Alan, thanks for this productive discussion. > Would it make a difference if it were exposed by the explain @Alan: I think this is great idea. +1 on exposing the sync/async behavior thought EXPLAIN. > Is there an easy way to determine if the output of an async function >

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Jiabao Sun
Hi Becket, The FLIP document[1] has been updated. Could you help take a look again? Thanks, Jiabao [1] https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=276105768 > 2023年12月18日 16:53,Becket Qin 写道: > > Yes, that sounds reasonable to me. We can start with ALWAYS and NEVER, and

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Becket Qin
Yes, that sounds reasonable to me. We can start with ALWAYS and NEVER, and add more policies as needed. Thanks, Jiangjie (Becket) Qin On Mon, Dec 18, 2023 at 4:48 PM Jiabao Sun wrote: > Thanks Bucket, > > The jdbc.filter.handling.policy is good to me as it provides sufficient > extensibility

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Jiabao Sun
Thanks Bucket, The jdbc.filter.handling.policy is good to me as it provides sufficient extensibility for future filter pushdown optimizations. However, currently, we don't have an implementation for the AUTO mode, and it seems that the AUTO mode can easily be confused with the ALWAYS mode

[VOTE] FLIP-372: Allow TwoPhaseCommittingSink WithPreCommitTopology to alter the type of the Committable

2023-12-18 Thread Péter Váry
Hi everyone, Since there were no further comments on the discussion thread [1], I would like to start the vote for FLIP-372 [2]. The FLIP started as a small new feature, but in the discussion thread and in a similar parallel thread [3] we opted for a somewhat bigger change in the Sink V2 API.

[jira] [Created] (FLINK-33871) Reduce getTable call for hive client and optimize graph generation time

2023-12-18 Thread hehuiyuan (Jira)
hehuiyuan created FLINK-33871: - Summary: Reduce getTable call for hive client and optimize graph generation time Key: FLINK-33871 URL: https://issues.apache.org/jira/browse/FLINK-33871 Project: Flink

Re: [DISCUSS] FLIP-377: Support configuration to disable filter push down for Table/SQL Sources

2023-12-18 Thread Becket Qin
Hi Jiabao, Please see the reply inline. > The MySQL connector is currently in the flink-connector-jdbc repository > and is not a standalone connector. > Is it too unique to use "mysql" as the configuration option prefix? If the intended behavior makes sense to all the supported JDBC drivers,