Re: Re: [VOTE] Release 2.1.0, release candidate #1

2025-07-24 Thread Xingbo Huang
+1 (binding) - verified signatures & checksums - pip install apache-flink-libraries && apache-flink with Python 3.12/3.10 in M2 - run pyflink job with UDF/Pandas in jdk11 && python 3.10 Best, Xingbo Xuyang 于2025年7月24日周四 17:28写道: > +1 > > > > > - built from sources (mac) > > - ran simple jobs b

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-07-24 Thread Hao Li
Hi Shengkai, Leonard, Thanks for the feedback. For Shengkai's feedback: > 1. Why SecretStoreFactory#open throws a CatalogException? I think the exteranl system can not handle this exception. You are right, we can make it throw `Exception` > 2. I think we can also modify the create catalog ddl s

[jira] [Created] (FLINK-38140) Change name from table.exec.async-scalar.buffer-capacity to max-concurrent-operations

2025-07-24 Thread Alan Sheinberg (Jira)
Alan Sheinberg created FLINK-38140: -- Summary: Change name from table.exec.async-scalar.buffer-capacity to max-concurrent-operations Key: FLINK-38140 URL: https://issues.apache.org/jira/browse/FLINK-38140

Re: [VOTE] FLIP-400: AsyncScalarFunction for asynchronous scalar function support

2025-07-24 Thread Alan Sheinberg
Hi, New functionality for AsyncTableFunction ( https://github.com/apache/flink/pull/26567) was recently added, which is essentially the same async behavior, but for table functions. It contains similar configurations as for AsyncScalarFunction. While reviewing, we decided to change the config nam

Re: I'm migrating https://github.com/apache/flink-training to 2.0.0

2025-07-24 Thread Xeno Amess
https://github.com/apache/flink-training/pull/89 done. pr at here. though in this branch we still be using the old deprecated Source based api. But as shown at https://issues.apache.org/jira/browse/FLINK-28045 , seems no much movement to on really deleting these api for nearly a year, so I think

Re: [DISCUSS][FLIP-536] Add latest checkpoint details endpoint to Rest API

2025-07-24 Thread Chesnay Schepler
I think the idea of filtering is interesting but I do wonder if we should introduce it as part of this FLIP. That seems like something we'd maybe want to introduce consistently for all checkpoint-related endpoints. I'm also not sure about returning a 404 if no checkpoints exists (especially wi

Re: [DISCUSS] FLIP-535:Introduce RateLimiter to Source

2025-07-24 Thread Leonard Xu
Thanks Zexian for driving this work. Rate limiting is a common requirement, TBH, we should have supported it in earlier stage, and the proposed design integrating it into the source operator lifecycle, it is already able to meet the vast majority of scenarios, looks good from my side. Best, L

Re: [DISCUSS] FLIP-537: Enumerator with Global Split Assignment Distribution for Balanced Split assignment

2025-07-24 Thread Leonard Xu
Thanks Hongshun for driving this work. We also suffering the issue in production Kafka restoration usage, current design is a nice tradeoff and has considered the new Source implementation details, +1 from my side. Best, Leonard > 2025 7月 19 18:59,Hongshun Wang 写道: > > Hi devs, > > I'd

Re: [DISCUSS] FLIP-529 Connections in Flink SQL and Table API

2025-07-24 Thread Leonard Xu
Hi friends I like the updated FLIP goals, that’s what I want. I’ve some feedback: (1) Minor: Interface Hierarchy : Why doesn't WritableSecretStore extend SecretStore? (2) Configurability of SECRET_FIELDS : Could the hardcoded SECRET_FIELDS in BasicConnectionFactory be made configurable (e.g., '

I'm migrating https://github.com/apache/flink-training to 2.0.0

2025-07-24 Thread Xeno Amess
Half done. Would finish it this weekend(or if really unluckily, before next weekend ends) Wanna ask, if you mind me stay the legacy apis, or wanna migrate to a suit of new apis. import org.apache.flink.streaming.api.functions.sink.legacy.PrintSinkFunction; import org.apache.flink.streaming.api.fun

Re:Re: [VOTE] Release 2.1.0, release candidate #1

2025-07-24 Thread Xuyang
+1 - built from sources (mac) - ran simple jobs by sql-client - checked the git tag and date in flink-ui -- Best! Xuyang 在 2025-07-24 11:50:44,"Lincoln Lee" 写道: >Retract my previous -1, it's a local env issue and works fine after fixed. >Will continue the verification and g

Re: [VOTE] Release 2.1.0, release candidate #1

2025-07-24 Thread Lincoln Lee
+1 (binding) - Verified signatures & checksums - Built from src with jdk17 and maven 3.8.6 - Reviewed the release blog pr - Started local cluster and verified web ui & logs - Ran simple queries via sql-client with csv format source in batch mode - Tested new model ddl Best, Lincoln Lee Lincoln