Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-05 Thread Lincoln Lee
Thanks to Xintong for clarifying this! @Rui Due to the rules of feature freeze: "Only bug fixes and documentation changes are allowed."[1], your merge request has been discussed among 1.19 RMs, we also agree that do not merge these PRs which are purely cleanup work and no more benefits for

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-04 Thread Rui Fan
> My opinion would be to follow the process by default, and to make exceptions only if there're good reasons. Sounds make sense, I will merge it after 1.19 branch cutting. Thanks Xintong for the explanation! And sorry for bothering. Best, Rui On Mon, Feb 5, 2024 at 1:20 PM Xintong Song wrote:

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-04 Thread Xintong Song
Thanks for the info. My opinion would be to follow the process by default, and to make exceptions only if there're good reasons. From your description, it sounds like merging the PR in or after 1.19 doesn't really make a difference. In that case, I'd suggest to merge it for the next release (i.e.

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-04 Thread Rui Fan
Thanks Xintong for the reply. They are Flink internal classes, and they are not used anymore. So I think they don't affect users, the benefit of removing them is to simplify Flink's code and reduce maintenance costs. If we just merge some user-related PRs recently, I could merge it after 1.19.

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-04 Thread Xintong Song
Hi Rui, Quick question, would there be any downside if this PR doesn't go into 1.19? Or any user benefit from getting it into this release? Best, Xintong On Sun, Feb 4, 2024 at 10:16 AM Rui Fan <1996fan...@gmail.com> wrote: > Hi release managers, > > > The feature freeze of 1.19 has started

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-02-03 Thread Rui Fan
Hi release managers, > The feature freeze of 1.19 has started now. That means that no new features > or improvements should now be merged into the master branch unless you ask > the release managers first, which has already been done for PRs, or pending > on CI to pass. Bug fixes and

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-01-31 Thread Lincoln Lee
Hi Matthias, Thanks for letting us know! After discussed with 1.19 release managers, we agreed to merge these pr. Thank you for the work on GHA workflows! Best, Yun, Jing, Martijn and Lincoln Matthias Pohl 于2024年1月30日周二 22:20写道: > Thanks for the update, Lincoln. > > fyi: I merged

Re: [ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-01-30 Thread Matthias Pohl
Thanks for the update, Lincoln. fyi: I merged FLINK-32684 (deprecating AkkaOptions) [1] since we agreed in today's meeting that this change is still ok to go in. The beta version of the GitHub Actions workflows (FLIP-396 [2]) are also finalized (see related PRs for basic CI [3], nightly master

[ANNOUNCE] Flink 1.19 feature freeze & sync summary on 01/30/2024

2024-01-30 Thread Lincoln Lee
Hi everyone, (Since feature freeze and release sync are on the same day, we merged the announcement and sync summary together) *- Feature freeze* The feature freeze of 1.19 has started now. That means that no new features or improvements should now be merged into the master branch unless you