Just to double check are the changes in the PR of Thomas even touching the
API or would that be another PR?
Or are the API changes contained to FLINK-20379?
On Wed, May 5, 2021 at 8:29 PM Arvid Heise wrote:
> After looking a bit more into it, I'm also +1.
>
> Let's merge it soonish.
>
> On Wed,
After looking a bit more into it, I'm also +1.
Let's merge it soonish.
On Wed, May 5, 2021 at 7:20 PM Thomas Weise wrote:
> I opened the PR to backport the changes:
> https://github.com/apache/flink/pull/15840
>
> Without these fixes the new KafkaSource in 1.12 is near unusable. The most
>
I opened the PR to backport the changes:
https://github.com/apache/flink/pull/15840
Without these fixes the new KafkaSource in 1.12 is near unusable. The most
obvious problem I ran into during testing was that checkpoints fail when
consumption has not started for a split (easily reproduced with a
Hi all!
Generally, avoiding API changes in Bug fix versions is the right thing, in
my opinion.
But this case is a bit special, because we are changing something that
never worked properly in the first place.
So we are not breaking a "running thing" here, but making it usable.
So +1 from my side
Hi Arvid,
There are interface changes to the Kafka source, and there is a backwards
compatible change in the base source implementation. Therefore technically
speaking, users might be able to run the Kafka source in 1.13 with a 1.12
Flink job. However, it could be tricky because there might be
Hi Becket,
did you need to change anything to the source interface itself? Wouldn't it
be possible for users to simply use the 1.13 connector with their Flink
1.12 deployment?
I think the late-upgrade argument can be made for any feature, but I also
see that the Kafka connector is of high
Thanks for the comment, Till and Thomas.
As far as I know there are some users who have just upgraded their Flink
version from 1.8 / 1.9 to Flink 1.12 and might not upgrade the version in 6
months or more. There are also some organizations that have the strategy of
not running the latest version
Hi,
Thanks for fixing the new KafkaSource issues.
I'm interested in using these fixes with 1.12 for experimental purposes.
+1 for backporting. 1.12 is the current stable release and users who would
like to try the FLIP-27 sources are likely to use that release.
Thomas
On Wed, Apr 7, 2021 at
Hi Becket,
If I remember correctly, then we deliberately not documented the Kafka
connector in the 1.12 release. Hence, from this point there should be no
need to backport any fixes because users are not aware of this feature.
On the other hand this also means that we should be able to break
Hi folks,
I'd like to start a discussion thread about backporting some FLIP-27 Kafka
source connector fixes to release-1.12. These fixes include some API
changes and thus needs a public discussion.
The tickets in question are following:
https://issues.apache.org/jira/browse/FLINK-20379
10 matches
Mail list logo
