Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-09 Thread Ahmed Hamdy
Hi Danny +1 (non-binding) Best Regards Ahmed Hamdy On Tue, 9 Jan 2024 at 11:59, Xingbo Huang wrote: > Hi Danny, > > +1 > > Thanks a lot for investigating this. Let me share the current code > management and release situation of pyflink here. I hope it will be helpful > to you. > > Since Flink

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-09 Thread Xingbo Huang
Hi Danny, +1 Thanks a lot for investigating this. Let me share the current code management and release situation of pyflink here. I hope it will be helpful to you. Since Flink 1.13, release managers need to release two python packages to pypi, apache-flink[1] and apache-flink-libraries[2].

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-08 Thread Leonard Xu
+1 Thanks Danny for driving this. Best, Leonard > 2024年1月9日 上午2:01,Márton Balassi 写道: > > +1 > > Thanks, Danny - I really appreciate you taking the time for the in-depth > investigation. Please proceed, looking forward to your experience. > > On Mon, Jan 8, 2024 at 6:04 PM Martijn Visser

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-08 Thread Márton Balassi
+1 Thanks, Danny - I really appreciate you taking the time for the in-depth investigation. Please proceed, looking forward to your experience. On Mon, Jan 8, 2024 at 6:04 PM Martijn Visser wrote: > Thanks for investigating Danny. It looks like the best direction to go to > :) > > On Mon, Jan

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-08 Thread Martijn Visser
Thanks for investigating Danny. It looks like the best direction to go to :) On Mon, Jan 8, 2024 at 5:56 PM Péter Váry wrote: > > Thanks Danny for working on this! > > It would be good to do this in a way that the different connectors could > reuse as much code as possible, so if possible put

Re: [DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-08 Thread Péter Váry
Thanks Danny for working on this! It would be good to do this in a way that the different connectors could reuse as much code as possible, so if possible put most of the code to the flink connector shared utils repo [1] +1 from for the general direction (non-binding) Thanks, Peter [1]

[DISCUSS] Externalized Python Connector Release/Dependency Process

2024-01-08 Thread Danny Cranmer
Hello all, I have been working with Péter and Marton on externalizing python connectors [1] from the main repo to the connector repositories. We have the code moved and the CI running tests for Kafka and AWS Connectors. I am now looking into the release process. When we undertake a Flink release