Thanks Jingsong for the explanation and it makes sense. I have updated the
FLIP. Let me know if that reflects what you have in mind.
On Mon, Apr 13, 2020 at 4:52 PM Jingsong Li wrote:
> Hi,
>
> I didn't mean to unify parser for Flink SQL and Hive SQL.
> I mean we should not put hive things to pl
Hi,
I didn't mean to unify parser for Flink SQL and Hive SQL.
I mean we should not put hive things to planner.
Because planner have set conformance. So the parser already know the
dialect things.
A simple way is implement a Flink SqlParserImplFactory with conformance. We
can limit dialect things
Hi Jingsong,
Thanks for your input. I'd prefer to keep Hive syntax to a separate parser,
because 1) Supporting both Hive and Flink syntax in one parser makes the
grammar complicated and less efficient, e.g. we may need a bigger LOOKAHEAD
value to resolve conflicts. 2) It can be difficult to add ne
Thanks Rui for diving.
+1 for this proposal.
There are still lots of people who love Hive SQL.
And I have seen some people support HQL on presto. Presto, as a famous
computing engine, also supports ANSI SQL as we do. This is quite different
from HQL.
Do you think we must need import `FlinkHiveSq
Hi Kurt,
Thanks for the feedback and that's a good idea. I have updated the FLIP and
added tables in the "Limited Scope" section to list the supported and
unsupported features. Please have a look and let me know if that makes
sense. Thanks.
On Wed, Apr 8, 2020 at 2:19 PM Kurt Young wrote:
> Hi
Hi Rui,
Thanks for bringing up this discussion and it makes sense to me though i
have one comment about the FLIP.
There are a few places in the design document saying some features will not
be supported or not included in
this FLIP, but I don't get what will be supported exactly. I can imagine
oth
Hi devs,
I'd like to start a discussion about bringing DDL & DML compatibility for
Hive connector. The proposal mainly aims to implement more DDLs for Hive
connector and allow users to write Hive syntax when using the Hive dialect.
Hopefully this will make it easier for users to migrate to Flink,