Hi Danny
this is a good idea. We can do it easily.
I am amending the FLIP accordingly
Regards
Lorenzo
On Mon, 18 Sept 2023 at 20:17, Danny Cranmer
wrote:
> Hello Lorenzo,
>
> > Please consider this is not an AWS-specific connector and will not depend
> on flink-connector-aws-base
>
> This is
Hello Lorenzo,
> Please consider this is not an AWS-specific connector and will not depend
on flink-connector-aws-base
This is my point, how can we introduce AWS specific functionality without
coupling them. How about this. The Prometheus connector does not depend on
aws-base but publishes a
Hi Danny
Please consider this is not an AWS-specific connector and will not depend
on flink-connector-aws-base.
Prometheus remote-write specs deem authentication as out-of-scope [1].
Amazon Managed Prometheus uses request signing to authenticate
remote-writes. To support AMP but also keep the
Thanks for the reply Lorenzo.
> Static credentials are just for the sake of the example. The current
prototype implementation already uses DefaultAWSCredentialsProviderChain
that supports static and dynamic credentials. We can make the credential
provider configurable.
The point here was that
Hello
I am also re-sending an old answer I sent on May 24th, that, for some
reason, did not appear in the thread.
--
Q1) The fact we are using the remote write feature is not covered beyond
the code example. Can we add details on this to make it clear? Additionally
would this
Thanks Lorenzo,
Looking forward to the PRs.
Best Regards
Ahmed Hamdy
On Sat, 16 Sept 2023 at 06:27, Lorenzo Nicora
wrote:
> Hello
>
> (apologies if this is a duplicate reply)
>
> I was working with Karthi on this connector, and I have taken over the
> development.
> We have a working version
Hello
(apologies if this is a duplicate reply)
I was working with Karthi on this connector, and I have taken over the
development.
We have a working version we would like to submit to the community.
The renumbered FLIP-312 is also updated with more details [1].
Happy to answer any questions.
Hello
I was working with Karthi and took over development. I have a working
version already.
I also updated the FLIP (now FLIP-312, it was renumbered due to a clash)
Please, let me know how to proceed with this. Happy to answer any questions
about the FLIP
Regards
Lorenzo
[1]
Hello Karthi
Is this FLIP still in progress? I see the FLIP not updated & couldn't find
open JIRAs.
I am happy to take over if you are no longer working on this.
Best Regards
Ahmed Hamdy
On Mon, 22 May 2023 at 14:49, Martijn Visser
wrote:
> Hi all,
>
> > For example, a user might want to read
nfigurable.
Lorenzo
[1] https://prometheus.io/docs/concepts/remote_write_spec/
[2]
https://docs.google.com/document/d/1LPhVRSFkGNSuU1fBd81ulhsCPR4hkSZyyBj1SZ8fWOM/edit
On Wed, 24 May 2023 at 19:37, Nicora, Lorenzo wrote:
> *From: *Martijn Visser
>
> *Subject: RE: [EXTERNAL][DISCUSS] F
Hi all,
> For example, a user might want to read in logs, perform some aggregations
and publish it into a metrics store for visualisation. This might be a
great use-case for reducing the cardinality of metrics!
I can see that. What I would like to see in the FLIP is a proposal on the
boundaries
Hi LijieThank you for pointing this out. I've corrected it [1]. Also, this page [2] still shows 178 and 229 as available, which is why I
picked it up.ThanksKarthi[1] https://cwiki.apache.org/confluence/display/FLINK/FLIP-312%3A+Prometheus+Sink+Connector[2]
the FLIP itself, I think we should also consider the rate limit
> feature to avoid breaking down the metrics services.
>
> Best
> Yun Tang
>
> From: Jing Ge
> Sent: Friday, May 19, 2023 4:49
> To: dev@flink.apache.org
> Subject: Re:
limit feature to
avoid breaking down the metrics services.
Best
Yun Tang
From: Jing Ge
Sent: Friday, May 19, 2023 4:49
To: dev@flink.apache.org
Subject: Re: [DISCUSS] FLIP-229: Prometheus Sink Connector
Hi Karthi,
Thanks for raising this proposal
Hi Karthi,
Thanks for raising this proposal. It is a common use case to sink metric
"data" into downstream Prometheus. The description in the motivation
section is more or less misleading the discussion. I would suggest you
rephrase it, e.g. metrics (pre)processing via Flink is
The current
Thanks for the FLIP.
I agree that there is a real usecase for metrics sink vs metric reporter.
The metric reporters in Flink cover metrics about the Flink job, and a sink
is used when the metrics are the _data_.
+1 on the FLIP ID, can you please fix that?
With regard to this FLIP.
1/ The fact
Thanks Karthi for creating the FLIP!
Re: Martijn,
As I understand it, the motivation for the Prometheus Sink is for users who
want to write metrics to a Prometheus remote_write endpoint as an output of
their job graph, so it would be good to treat it as a first-class citizen and
do it as part
Hi Karthi,
I think you are using a wrong FLIP id, the FLIP-229 has already be used[1].
[1]
https://cwiki.apache.org/confluence/display/FLINK/FLIP-229%3A+Introduces+Join+Hint+for+Flink+SQL+Batch+Job
Best,
Lijie
Martijn Visser 于2023年5月16日周二 04:44写道：
> Hi Karthi,
>
> Thanks for the FLIP and
Hi Karthi,
Thanks for the FLIP and opening up the discussion. My main question is: why
should we create a separate connector and not use and/or improve the
existing integrations with Prometheus? I would like to understand more so
that it can be added to the motivation of the FLIP.
Best regards,
Hello all,We would like to start a discussion thread on FLIP-229: Prometheus
Sink Connector [1] where we propose to provide a sink connector for Prometheus
[2] based on the Async Sink [3]. Looking forward to comments and feedback.
Thank you.[1]
20 matches
Mail list logo
