Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-18 Thread Martijn Visser
; > > > > > BTW, we might make it done in flink-1.17 release with deprecating > > > SourceFunction[1] together. > > > > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-28045 > > > > > > Best > > > Yun Tang > &g

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-18 Thread Jing Ge
Function[1] together. > > > > > > [1] https://issues.apache.org/jira/browse/FLINK-28045 > > > > Best > > Yun Tang > > ________ > > From: Biao Liu > > Sent: Wednesday, January 18, 2023 16:15 > > To: dev@flink.apache.or

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-18 Thread Martijn Visser
s.apache.org/jira/browse/FLINK-28045 > > Best > Yun Tang > > From: Biao Liu > Sent: Wednesday, January 18, 2023 16:15 > To: dev@flink.apache.org > Subject: Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For > Batch Job >

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-18 Thread Yun Tang
From: Biao Liu Sent: Wednesday, January 18, 2023 16:15 To: dev@flink.apache.org Subject: Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job Hi Martijn & Jing, Thanks for feedback! Currently, SinkFunction is in a subtle circumstance. Like

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-18 Thread Biao Liu
of scope: > "Sink > > > > > > Supports > > > > > > > Speculative Execution For Batch Job". I think it's better to > > start > > > > > > another > > > > > > > FLIP to discuss it. "Fine-grai

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-12 Thread Jing Ge
gt; > > > > > > > > > What do you think? > > > > > > > > > > > > Thanks, > > > > > > Biao /'bɪ.aʊ/ > > > > > > > > > > > > > > > > > > > > > > > > On Wed, 28 De

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-11 Thread Martijn Visser
> > of sinks is important. > > > > > > > > > > > > I have a question about this: Speculative execution of Committer > > will > > > > be > > > > > > disabled. > > > > > > > > > > > &g

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-11 Thread Biao Liu
> > I agree with your point and I saw the similar requirements to > disable > > > > > speculative execution for specified operators. > > > > > > > > > > However the requirement is not supported currently. I think there > > > should > > &g

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-11 Thread Martijn Visser
it. > > > > > > > > Best, > > > > Jing Zhang > > > > > > > > Lijie Wang 于2022年12月27日周二 18:51写道: > > > > > > > > > Hi Biao, > > > > > > > > > > Thanks for driving this FLIP. > > >

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-03 Thread Jing Zhang
. > > > > I have a question about this: does SinkV2 need to do the same thing? > > > Should > > > > we/users do it in the committer? If yes, how does the commiter know > > which > > > > one is the right subtask attempt? > > > > > > &g

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2023-01-03 Thread Lijie Wang
s the right subtask attempt? > > > > > > Best, > > > Lijie > > > > > > yuxia 于2022年12月27日周二 10:01写道: > > > > > > > HI, Biao. > > > > Thanks for driving this FLIP. > > > > After quick look of this FLIP, I hav

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-28 Thread Biao Liu
> > What the sink expect to do to isolate data produced by speculative > > > executions? IIUC, if the taks failover, it also generate a new > attempt. > > > Does it make difference in isolating data produced? > > > > > > Best regards, > > >

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-27 Thread Jing Zhang
rence in isolating data produced? > > > > Best regards, > > Yuxia > > > > - 原始邮件 ----- > > 发件人: "Biao Liu" > > 收件人: "dev" > > 发送时间: 星期四, 2022年 12 月 22日 下午 8:16:21 > > 主题: [DISCUSS] FLIP-281 Sink Supports Speculative Exec

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-27 Thread Lijie Wang
in isolating data produced? > > Best regards, > Yuxia > > - 原始邮件 - > 发件人: "Biao Liu" > 收件人: "dev" > 发送时间: 星期四, 2022年 12 月 22日 下午 8:16:21 > 主题: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job > > Hi everyone, > &

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-26 Thread yuxia
executions? IIUC, if the taks failover, it also generate a new attempt. Does it make difference in isolating data produced? Best regards, Yuxia - 原始邮件 - 发件人: "Biao Liu" 收件人: "dev" 发送时间: 星期四, 2022年 12 月 22日 下午 8:16:21 主题: [DISCUSS] FLIP-281 Sink Supports Speculati

Re: [DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-26 Thread Zhu Zhu
Hi Biao, Thanks for creating this FLIP! Supporting speculative execution of sinks is important. Also In production we see sinks chaining with other operators, e.g. sources in simple ETL jobs, and currently the task cannot do speculative execution due to sinks are not supported. +1 for the

[DISCUSS] FLIP-281 Sink Supports Speculative Execution For Batch Job

2022-12-22 Thread Biao Liu
Hi everyone, I would like to start a discussion about making Sink support speculative execution for batch jobs. This proposal is a follow up of "FLIP-168: Speculative Execution For Batch Job"[1]. Speculative execution is very meaningful for batch jobs. And it would be more complete after