Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hi Junrui, Thanks for the clarification. On one hand, adding more methods into the RuntimeContext flat will increase the effort for users who will use RuntimeContext. But the impact is limited. It is fine. The big impact is, on the other hand, for users who want to focus on the execution config,

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hi Jing, Thank you for your feedback. I understand your concerns regarding putting all methods into the RuntimeContext flat. I would like to share some of my thoughts on this matter. Firstly, this FLIP only proposes the addition of three additional methods, which should not impose too much extra

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hi Junrui, Thanks for bringing this to our attention. First of all, it makes sense to deprecate RuntimeContext#getExecutionConfig. Afaic, this is an issue of how we design API with clean concepts/aspects. There are two issues mentioned in the FLIP: 1. short of user-facing abstraction - we just

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hello Wencong, Thank you for your valuable feedback and suggestions. I want to clarify that reviewing existing methods in the ExecutionConfig is not directly related to the proposal in this FLIP. The main focus of this FLIP is to deprecate the specific method RuntimeContext#getExecutionConfig().

Re:[DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hello Junrui, Thanks for the effort. I agree with the proposal to deprecate the getExecutionConfig() method in the RuntimeContext class. Exposing the complex ExecutionConfig to user-defined functions can lead to unnecessary complexity and risks. I also have a suggestion. We could consider

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Sorry, I read something wrong when I read FLIP. It's fine for me. Best, Rui On Thu, Nov 16, 2023 at 2:32 PM Junrui Lee wrote: > Hi Rui, > > Thank you for your feedback. Regarding your question, I want to let you > know that we have included the alternative getter method "@PublicEvolving > Map

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hi Rui, Thank you for your feedback. Regarding your question, I want to let you know that we have included the alternative getter method "@PublicEvolving Map getGlobalJobParameters()" in this FLIP. And this method will provide users with global job parameters. I would appreciate it if you could

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Thanks Junrui for driving this proposal! Overall looks good to me! I have a question: How do the flink users to getGlobalJobParameters if RuntimeContext#getExecutionConfig is removed? Is there any alternative api? Or is this feature removed? Maybe this is a noob question and I may have missed

Re: [DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Thanks Junrui for creating the FLIP and kicking off this discussion. Exposing a mutable ExecutionConfig which is even shared by multiple operators is truly a defect which can result in weird results. +1 Thanks, Zhu Junrui Lee 于2023年11月15日周三 16:53写道： > Hi all, > > I'd like to start a

[DISCUSS] FLIP-391: Deprecate RuntimeContext#getExecutionConfig

Hi all, I'd like to start a discussion of FLIP-391: Deprecate RuntimeContext#getExecutionConfig[1]. Currently, the FLINK RuntimeContext is important for connecting user functions to the underlying runtime details. It provides users with necessary runtime information during job execution.