Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-26 Thread yue ma
Hi all, Thank you all for your feedback. If there are no extra comments, I will start voting in three days, thank you :) yue ma 于2024年4月22日周一 14:09写道: > Hi Flink devs, > > I would like to start a discussion on FLIP-447: Upgrade FRocksDB from > 6.20.3 to 8.10.0 > > >

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread yue ma
> > > > > > > > > Hi Yue, > > > > > > > > > > > > > > Thanks for driving this work. > > > > > > > > > > > > > > It has been three years since last major upgrade of FRocksDB. > And it > &

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread Hangxiang Yu
Hi, Yue. Very glad to see that IngestDB will be used to improve the rescaling performance of RocksDB. And +1 for the upgrade. Thanks for the great work! On Thu, Apr 25, 2024 at 5:16 AM Martijn Visser wrote: > +1 > > On Wed, Apr 24, 2024 at 5:31 PM Congxian Qiu > wrote: > > > Thanks for driving

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread Martijn Visser
+1 On Wed, Apr 24, 2024 at 5:31 PM Congxian Qiu wrote: > Thanks for driving this, yue > > We also observed significant performance improvements in some cases after > bumped the Rocksdb version, +1 for this work > > Best, > Congxian > > > yue ma 于2024年4月24日周三 19:16写道: > > > hi Yanfei, > > > >

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread Congxian Qiu
Thanks for driving this, yue We also observed significant performance improvements in some cases after bumped the Rocksdb version, +1 for this work Best, Congxian yue ma 于2024年4月24日周三 19:16写道: > hi Yanfei, > > Thanks for your feedback and reminders I have updated related information. > In

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread yue ma
hi Yanfei, Thanks for your feedback and reminders I have updated related information. In fact, most of them use the default Configrations. Yanfei Lei 于2024年4月23日周二 12:51写道: > Hi Yue & Roman, > > Thanks for initiating this FLIP and all the efforts for the upgrade. > > 8.10.0 introduces some new

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread yue ma
_____ > > From: Yanfei Lei > > Sent: Tuesday, April 23, 2024 12:50 > > To: dev@flink.apache.org > > Subject: Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 > > > > Hi Yue & Roman, > > > > Thanks for ini

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread yue ma
hi Roman, Thank you very much for your feedback and effort, especially for your help in releasing Frocksdb products and testing the performance. Roman Khachatryan 于2024年4月23日周二 12:07写道: > Hi, > > Thanks for writing the proposal and preparing the upgrade. > > FRocksDB definitely needs to be

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-24 Thread lorenzo . affetti
gt; > > > > > > Hi Yue, > > > > > > > > > > > > Thanks for driving this work. > > > > > > > > > > > > It has been three years since last major upgrade of FRocksDB. And it > > > > would > > > > > > be g

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-23 Thread Gyula Fóra
iving this work. > > > > > > It has been three years since last major upgrade of FRocksDB. And it > > would > > > be great improvement of Flink's state-backend with this upgrade. +1 for > > > this work. > > > > > > > > > Best > > > Y

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-23 Thread Yuan Mei
ang > > ________ > > From: Yanfei Lei > > Sent: Tuesday, April 23, 2024 12:50 > > To: dev@flink.apache.org > > Subject: Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 > > > > Hi Yue & Roman, > > > &

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-23 Thread Zakelly Lan
> > > Best > Yun Tang > > From: Yanfei Lei > Sent: Tuesday, April 23, 2024 12:50 > To: dev@flink.apache.org > Subject: Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 > > Hi Yue & Roman, > > Thanks for initiating this FLIP and all the efforts

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-22 Thread Yun Tang
:50 To: dev@flink.apache.org Subject: Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 Hi Yue & Roman, Thanks for initiating this FLIP and all the efforts for the upgrade. 8.10.0 introduces some new features, making it possible for Flink to implement some new exciting feat

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-22 Thread Yanfei Lei
Hi Yue & Roman, Thanks for initiating this FLIP and all the efforts for the upgrade. 8.10.0 introduces some new features, making it possible for Flink to implement some new exciting features, and the upgrade also makes FRocksDB easier to maintain, +1 for upgrading. I read the FLIP and have a

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-22 Thread Rui Fan
Thanks Yue for driving this proposal! This upgrade makes sense, +1 for that. Best, Rui On Tue, Apr 23, 2024 at 12:06 PM Roman Khachatryan wrote: > Hi, > > Thanks for writing the proposal and preparing the upgrade. > > FRocksDB definitely needs to be kept in sync with the upstream and the new

Re: [DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-22 Thread Roman Khachatryan
Hi, Thanks for writing the proposal and preparing the upgrade. FRocksDB definitely needs to be kept in sync with the upstream and the new APIs are necessary for faster rescaling. We're already using a similar version internally. I reviewed the FLIP and it looks good to me (disclaimer: I took

[DISCUSS] FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0

2024-04-22 Thread yue ma
Hi Flink devs, I would like to start a discussion on FLIP-447: Upgrade FRocksDB from 6.20.3 to 8.10.0 https://cwiki.apache.org/confluence/display/FLINK/FLIP-447%3A+Upgrade+FRocksDB+from+6.20.3++to+8.10.0 This FLIP proposes upgrading the version of FRocksDB in the Flink Project from 6.20.3 to