Re: [DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-20 Thread Sergey Nuyanzin
Thanks Timo, I fixed the example I'm going to start the voting then in a separate thread On Thu, Dec 19, 2024 at 12:32 PM Timo Walther wrote: > Hi Sergey, > > thanks for working on this. The FLIP is a nice continuation of started > efforts. The example of createTable doesn't use the flag. Othe

Re: [DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-19 Thread Timo Walther
Hi Sergey, thanks for working on this. The FLIP is a nice continuation of started efforts. The example of createTable doesn't use the flag. Otherwise +1 to vote, as it is not very controversial. Cheers, Timo On 18.12.24 09:35, Sergey Nuyanzin wrote: Hi Ron, good catch, I fixed it thanks O

Re: [DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-18 Thread Sergey Nuyanzin
Hi Ron, good catch, I fixed it thanks On Wed, Dec 18, 2024 at 3:27 AM Ron Liu wrote: > Hi Sergey > > Thanks for driving this FLIP, +1. > > It may be a minor typo for the createTable method doc. > > ``` > > * {@code > * tEnv.createTemporaryTable("MyTable", > TableDescriptor.forConnector("datag

Re: [DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-17 Thread Ron Liu
Hi Sergey Thanks for driving this FLIP, +1. It may be a minor typo for the createTable method doc. ``` * {@code * tEnv.createTemporaryTable("MyTable", TableDescriptor.forConnector("datagen") * .schema(Schema.newBuilder() * .column("f0", DataTypes.STRING()) * .build()) * .option(DataGenOpt

[DISCUSS] FLIP-494: Add missing createTable/createView methods to TableEnvironment

2024-12-17 Thread Sergey Nuyanzin
Hi all! I would like to open up for discussion another new small FLIP-494[1]. Motivation This FLIP continues the journey of bringing Table API and FlinkSQL closer to each other. It adds missing create methods to TableEnvironment (alter functionality will be added in follow up FLIP(s)). There are