Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-11-08 Thread Jingsong Li
Thanks Kurt and Terry for bringing this to my attention. Agree each topic of this FLIP touched is super big. But because it's too big, we can't cover everything in one FLIP. So I think there are two ways: 1. Decompose this big thing into an independent topic(FLIP), so that each FLIP can be

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-11-07 Thread Kurt Young
Hi Terry, I wouldn't say it's a mistake, I also don't have any suggestions about the issue. I just saw this and want to point it out to bring more attention. Maybe someone has some good opinion on that part and we can discuss around it and have some good advises for the community in the future.

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-11-07 Thread Terry Wang
Hi, Kurt~ Thanks for your vote and pointing out some deficiency of this flip. I’ll try to avoid making similar mistakes. Best, Terry Wang > 2019年11月8日 11:28,Kurt Young 写道: > > Hi, > > Sorry to join this so late and thanks for proposing this FLIP. After > going through the proposal

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-11-07 Thread Kurt Young
Hi, Sorry to join this so late and thanks for proposing this FLIP. After going through the proposal details, I would +1 for the changes. However, the FLIP name is kind of confusing me. It says will do DDL enhancement, and picked up a few new features to do. It looks to me the goal and content of

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-11-05 Thread Terry Wang
Hi Bowen~ We don’t intend to support create/drop catalog syntax in this flip, we may support it if there indeed has a strong desire. And I’m going to kick off a vote for this flip, feel free to review again. Best, Terry Wang > 2019年9月26日 00:44,Xuefu Z 写道: > > Actually catalogs are more of

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-10-30 Thread Terry Wang
Hi, everyone~ Sorry so late to reply this this thread again. I am working on FLIP-84 recently to make sql api support return value which this flip depends on. I think it’s time to pick up this discussion again and there are some new updates in this flip design:

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-09-25 Thread Xuefu Z
Actually catalogs are more of system settings than of user objects that a user might create or drop constantly. Thus, it's probably sufficient to set up catalog information in the config file, at least for now. Thanks, Xuefu On Tue, Sep 24, 2019 at 7:10 PM Terry Wang wrote: > Thanks Bowen for

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-09-24 Thread Terry Wang
Thanks Bowen for your insightful comments, I’ll think twice and do corresponding improvement. After finished, I’ll update in this mailing thread again. Best, Terry Wang > 在 2019年9月25日,上午8:28,Bowen Li 写道: > > BTW, will there be a "CREATE/DROP CATALOG" DDL? > > Though it's not SQL standard, I

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-09-24 Thread Bowen Li
BTW, will there be a "CREATE/DROP CATALOG" DDL? Though it's not SQL standard, I can see it'll be useful and handy for our end users in many cases. On Mon, Sep 23, 2019 at 12:28 PM Bowen Li wrote: > Hi Terry, > > Thanks for driving the effort! I left some comments in the doc. > > AFAIU, the

Re: [DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-09-23 Thread Bowen Li
Hi Terry, Thanks for driving the effort! I left some comments in the doc. AFAIU, the biggest motivation is to support DDLs in sql parser so that both Table API and SQL CLI can share the stack, despite that SQL CLI has already supported some commands itself. However, I don't see details on how

[DISCUSS] FLIP 69 - Flink SQL DDL Enhancement

2019-09-16 Thread Terry Wang
Hi everyone, In flink 1.9, we have introduced some awesome features such as complete catalog support[1] and sql ddl support[2]. These features have been a critical integration for Flink to be able to manage data and metadata like a classic RDBMS and make developers more easy to construct their