Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-06-07 Thread Ferenc Csaky
Hi, Thank you everyone for the valuable comments, if there are no new messages by then, I will start a vote on Monday. Thanks, Ferenc On Monday, 3 June 2024 at 17:27, Jeyhun Karimov wrote: > > > Hi Ferenc, > > Thanks for the proposal. +1 for it! This FLIP will improve the user >

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-06-03 Thread Jeyhun Karimov
Hi Ferenc, Thanks for the proposal. +1 for it! This FLIP will improve the user experience. Regards, Jeyhun On Mon, Jun 3, 2024 at 1:50 PM Ferenc Csaky wrote: > Hi Hang, > > Thank you for your inputs, both points make sense, updated the > FLIP according to them. > > Best, > Ferenc > > > >

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-06-03 Thread Ferenc Csaky
Hi Hang, Thank you for your inputs, both points make sense, updated the FLIP according to them. Best, Ferenc On Friday, 31 May 2024 at 04:31, Hang Ruan wrote: > > > Hi, Ferenc. > > +1 for this proposal. This FLIP will help to make the CLI clearer for users. > > I think we should better

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-05-30 Thread Hang Ruan
Hi, Ferenc. +1 for this proposal. This FLIP will help to make the CLI clearer for users. I think we should better add an example in the FLIP about how to use the application mode with the new CLI. Besides that, we need to add some new tests for this change instead of only using the existed

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-05-29 Thread Mate Czagany
Hi Ferenc, Thanks for the FLIP, +1 from me for the proposal. I think these changes would be a great solution to all the confusion that comes from these two action parameters. Best regards, Mate Ferenc Csaky ezt írta (időpont: 2024. máj. 28., K, 16:13): > Thank you Xintong for your input. > >

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-05-28 Thread Ferenc Csaky
Thank you Xintong for your input. I prepared a FLIP for this change [1], looking forward for any other opinions. Thanks, Ferenc [1] https://docs.google.com/document/d/1EX74rFp9bMKdfoGkz1ASOM6Ibw32rRxIadX72zs2zoY/edit?usp=sharing On Friday, 17 May 2024 at 07:04, Xintong Song wrote: > > >

Re: [DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-05-16 Thread Xintong Song
AFAIK, the main purpose of having `run-application` was to make sure the user is aware that application mode is used, which executes the main method of the user program in JM rather than in client. This was important at the time application mode was first introduced, but maybe not that important

[DISCUSS] Merge "flink run" and "flink run-application" in Flink 2.0

2024-05-16 Thread Ferenc Csaky
Hello devs, I saw quite some examples when customers were confused about run​, and run- application​ in the Flink CLI and I was wondering about the necessity of deploying Application Mode (AM) jobs with a different command, than Session and Per-Job mode jobs. I can see a point that