Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Aljoscha Krettek
Yes, in fact I anticipated this. There is one central place where we can insert a copy step, in OperatorCollector in OutputHandler. On Wed, May 20, 2015 at 11:17 AM, Paris Carbone par...@kth.se wrote: I guess it was not intended ^^. Chaining should be transparent and not break the

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able to implement something like this without having to worry about copying the object (and at this point the user would need to know whether it comes from the network to

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Stephan Ewen
I am curious why the copying is actually needed. In the batch API, we chain and do not copy and it is rather predictable. The cornerpoints of that design is to follow these rules: 1) Objects read from the network or any buffer are always new objects. That comes naturally when they are

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Paris Carbone
I guess it was not intended ^^. Chaining should be transparent and not break the correct/expected behaviour. Paris? On 20 May 2015, at 11:02, Márton Balassi mbala...@apache.org wrote: +1 for copying. On May 20, 2015 10:50 AM, Gyula Fóra gyf...@apache.org wrote: Hey, The latest streaming

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Márton Balassi
+1 for copying. On May 20, 2015 10:50 AM, Gyula Fóra gyf...@apache.org wrote: Hey, The latest streaming operator rework removed the copying of the outputs before passing them to chained operators. This is a major break for the previous operator semantics which guaranteed immutability. I

RE: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Paris Carbone
, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able to implement something like this without having to worry about

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Stephan Ewen
. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Stephan Ewen
to evaluate them. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Stephan Ewen
chained) operators that need to evaluate them. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Stephan Ewen
To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able to implement something like

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Aljoscha Krettek
to other (possibly chained) operators that need to evaluate them. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Aljoscha Krettek
: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able to implement

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
to other (possibly chained) operators that need to evaluate them. From: Gyula Fóra gyf...@apache.org Sent: Wednesday, May 20, 2015 2:06 PM To: dev@flink.apache.org Subject: Re: [DISCUSS] Re-add record copy to chained

Re: [DISCUSS] Re-add record copy to chained operator calls

2015-05-20 Thread Gyula Fóra
Subject: Re: [DISCUSS] Re-add record copy to chained operator calls Copy before putting it into a window buffer and any other group buffer. Exactly my point. Any stateful operator should be able to implement something like