Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-03-12 Thread Jinzhong Li
gt; > > > > > On Mon, Feb 26, 2024 at 11:29 AM Yanfei Lei > > wrote: > > > > > > > > > @Yun Tang > > > > > Thanks for the information, +1 for marking > > > > > `ConfigurableRocksDBOptionsFactory` as `Publi

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-03-12 Thread Jing Ge
t; Yun Tang 于2024年2月23日周五 19:54写道: > > > > > > > > > > Hi Jinzhong, > > > > > > > > > > Thanks for driving this topic, and +1 for fixing the lack of > > > annotation. > > > > > > > > > > @Yanfei the `ConfigurableRocksDBOptionsFactory`

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-03-11 Thread Jinzhong Li
gt; @Yanfei the `ConfigurableRocksDBOptionsFactory` interface is > introduced > > > for user extension, you can refer to the doc[1], which shows an example > > of > > > how to use this interface. > > > > > > > > > > > > [1] > > &

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-03-10 Thread Jing Ge
ould also > > > > > mark RocksDBStateBackendFactory as Deprecated > > > > > 2. Since 1.19 will be freezed in 1.26. Let's adjust the target > > version to > > > > > 1.20 > > > > > > > > > > >

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-02-26 Thread Jinzhong Li
/docs/ops/state/large_state_tuning/#tuning-rocksdb-memory > > > > > > Best > > Yun Tang > > ____ > > From: Yanfei Lei > > Sent: Thursday, February 22, 2024 15:39 > > To: dev@flink.apache.org > > Subject: Re: [DISCUSS]

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-02-25 Thread Yanfei Lei
rocksdb-memory > > > Best > Yun Tang > > From: Yanfei Lei > Sent: Thursday, February 22, 2024 15:39 > To: dev@flink.apache.org > Subject: Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend > user-facing classe

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-02-23 Thread Yun Tang
t; *RocksDBStateDownloader > > > *with @Internal, as they seem to be ordinary classes without interacting > > > with other modules. > > > Also, I have reservations about annotating *SingleStateIterator*, but I'd > > > like to hear others' opinions and won't insist on t

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-02-21 Thread Yanfei Lei
eDownloader > > > *with @Internal, as they seem to be ordinary classes without interacting > > > with other modules. > > > Also, I have reservations about annotating *SingleStateIterator*, but I'd > > > like to hear others' opinions and won't insist on this. > > &

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-01-24 Thread Jinzhong Li
s and won't insist on this. > > > > Best, > > Zakelly > > > > On Wed, Jan 24, 2024 at 10:26 PM Jinzhong Li > > wrote: > > > > > Hi devs, > > > > > > I’m opening this thread to discuss about FLIP-420: Add API annotations > > for

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-01-24 Thread Hangxiang Yu
modules. > Also, I have reservations about annotating *SingleStateIterator*, but I'd > like to hear others' opinions and won't insist on this. > > Best, > Zakelly > > On Wed, Jan 24, 2024 at 10:26 PM Jinzhong Li > wrote: > > > Hi devs, > > > > I

Re: [DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-01-24 Thread Zakelly Lan
annotating *SingleStateIterator*, but I'd like to hear others' opinions and won't insist on this. Best, Zakelly On Wed, Jan 24, 2024 at 10:26 PM Jinzhong Li wrote: > Hi devs, > > I’m opening this thread to discuss about FLIP-420: Add API annotations for > RocksDB StateBackend user-fa

[DISCUSS]FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes

2024-01-24 Thread Jinzhong Li
Hi devs, I’m opening this thread to discuss about FLIP-420: Add API annotations for RocksDB StateBackend user-facing classes[1]. As described in FLINK-18255[2] , several user-facing classes in flink-statebackend-rocksdb module don't have any API annotations, not even @PublicEvolving. This FLIP