Thanks Alan for starting this flip!
+1 for the new `supportsConstantFolding`. We do need to reserve the
ability to not perform constant folding for certain cases.
Best,
Lincoln Lee
Alan Sheinberg 于2024年5月7日周二 08:32写道：
> Hi Muhammet, Timo
>
> The `isDeterministic()`[1] function is mentioned
Hi Muhammet, Timo
The `isDeterministic()`[1] function is mentioned in the documentation,
> I would suggest to add maybe a section for `supportsConstantFolding()`,
> with short description and examples use cases (similar to the
> motivation of the FLIP) where this could be useful in UDFs.
>
Thanks
Hi Alan,
thanks for the update. From my side, the FLIP seems good for voting.
Since it only touches a small API surface, I guess the proposal is not
very controversial.
Feel free to start a vote thread by tomorrow. If there are no objections?
Thanks,
Timo
On 02.05.24 09:45, Muhammet
Hey Alan,
Thanks for the proposal, +1!
The `isDeterministic()`[1] function is mentioned in the documentation,
I would suggest to add maybe a section for `supportsConstantFolding()`,
with short description and examples use cases (similar to the
motivation of the FLIP) where this could be useful
Thanks for the comment Timo!
Since FunctionDefinition is kind of a declaration, it should rather read
> declarative as well. I suggest to call this method
> `supportsConstantFolding`. `allow` sounds like one could influence the
> state of the function from the outside.
>
That makes sense.
Hi Alan,
thanks for starting this small FLIP. A new method in FunctionDefinition
makes a lot of sense and the lack of it was an issue in past already. We
should clearly separate determinism and constant folding behavior.
Since FunctionDefinition is kind of a declaration, it should rather
I'd like to start a discussion of FLIP-452: Allow Skipping Invocation of
Function Calls While Constant-folding [1]
This feature proposes adding a new
method FunctionDefinition.allowConstantFolding() as part of the Flink
Table/SQL API. This would be used to determine whether an expression
