Re: [VOTE] FLIP-254 Redis Streams connector

2022-10-07 Thread Zheng Yu Chen
+1 (no-binding) thanks for drive this flip Yu Li 于2022年9月19日周一 14:20写道: > +1 (binding) > > Thanks for the clarification Martijn. I'd suggest considering adding a note > in the FLIP document (since the proposed repository name for this connector > is "flink-connector-redis") or changing the

[RESULT] [VOTE] FLIP-254: Redis Streams Connector

2022-10-07 Thread Martijn Visser
Hi all, Happy to announce that we have unanimously approved FLIP-254 [1] There are 5 approving votes, 3 of which are binding: - Yu Li (binding) - Jingsong Li (binding) - Martijn Visser (binding) - Zheng Yu Chen (non-binding) - Ryan Skraba (non-binding) There are no disapproving votes. Best

Re: [VOTE] FLIP-254 Redis Streams connector

2022-10-07 Thread Martijn Visser
+1 (binding) On Mon, Sep 19, 2022 at 3:49 AM Jingsong Li wrote: > +1 (binding) > > Best, > Jingsong > > On Mon, Sep 19, 2022 at 2:20 PM Yu Li wrote: > > > > +1 (binding) > > > > Thanks for the clarification Martijn. I'd suggest considering adding a > note > > in the FLIP document (since the

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-19 Thread Jingsong Li
+1 (binding) Best, Jingsong On Mon, Sep 19, 2022 at 2:20 PM Yu Li wrote: > > +1 (binding) > > Thanks for the clarification Martijn. I'd suggest considering adding a note > in the FLIP document (since the proposed repository name for this connector > is "flink-connector-redis") or changing the

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-19 Thread Yu Li
+1 (binding) Thanks for the clarification Martijn. I'd suggest considering adding a note in the FLIP document (since the proposed repository name for this connector is "flink-connector-redis") or changing the repository name to "flink-connector-redis-streams". Best Regards, Yu On Thu, 15 Sept

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-15 Thread Martijn Visser
Hi Ryan and Yu, > There's quite a bit of existing code and it looks like there's > interest and community willing to contribute to this connector with 2 > implementations already in the flink-connector-redis repo[1]. Yes, this FLIP is to formalize that the Flink community wants to add this

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-12 Thread Yu Li
Hi Martijn, Thanks for driving this forward, but from the discussion thread [1], it seems one question from Konstantin is still not answered: does this FLIP only aim to add source/sink connectors for Redis Streams, and we will create another one to support regular Redis data structures (as

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-12 Thread Ryan Skraba
Hello! There's quite a bit of existing code and it looks like there's interest and community willing to contribute to this connector with 2 implementations already in the flink-connector-redis repo[1]. There's a couple of points that should probably be fixed in the FLIP: some typos such as

Re: [VOTE] FLIP-254 Redis Streams connector

2022-09-12 Thread Zheng Yu Chen
+1 (non-binding) Martijn Visser 于2022年9月12日周一 15:58写道: > Hi everyone, > > With no comments provided in the discussion thread, I'm opening a vote > thread on FLIP-254: Redis Streams connector: > > FLIP: > > https://cwiki.apache.org/confluence/display/FLINK/FLIP-254%3A+Redis+Streams+Connector > >

[VOTE] FLIP-254 Redis Streams connector

2022-09-12 Thread Martijn Visser
Hi everyone, With no comments provided in the discussion thread, I'm opening a vote thread on FLIP-254: Redis Streams connector: FLIP: https://cwiki.apache.org/confluence/display/FLINK/FLIP-254%3A+Redis+Streams+Connector The vote will be open for at least 72h. Best regards, Martijn