Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-26 Thread Dian Fu
Hi Dong, Thanks for the explanation. The changes sound reasonable to me. It could avoid changing the interface again in the future and so +1 from my side. Regards, Dian On Fri, Feb 24, 2023 at 2:03 PM Zhipeng Zhang wrote: > Thanks for the update. The change looks good to me. > > So +1 from my

Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-23 Thread Zhipeng Zhang
Thanks for the update. The change looks good to me. So +1 from my side. Dong Lin 于2023年2月24日周五 13:56写道: > > As we are working on FLIP-289 PR, we realized that we need to make > one minor change to the ModelServable#setModelData() API. > > More specifically, we would like to update the

Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-23 Thread Dong Lin
As we are working on FLIP-289 PR, we realized that we need to make one minor change to the ModelServable#setModelData() API. More specifically, we would like to update the ModelServable#setModelData to use the following signature. It additionally throws IOException and allows users to provide

[RESULT][VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-16 Thread Dong Lin
Hi all, I am happy to announce that FLIP-289: Support online inference (Flink ML) [1] has been accepted. There are 3 binding votes [2]: - Dian Fu (binding) - Zhipeng Zhang (binding) - Dong Lin (binding) There is no disapproving vote. Regards, Dong [1]

Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-16 Thread Dong Lin
Thank you all for the votes! The vote is now closed. I will announce the results in a separate email. Cheers, Dong On Thu, Feb 16, 2023 at 6:02 PM Zhipeng Zhang wrote: > +1 (binding) > > Regards, > Zhipeng > > Dian Fu 于2023年2月13日周一 20:21写道: > > > > +1 (binding) > > > > Regards, > > Dian > >

Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-16 Thread Zhipeng Zhang
+1 (binding) Regards, Zhipeng Dian Fu 于2023年2月13日周一 20:21写道: > > +1 (binding) > > Regards, > Dian > > On Mon, Feb 13, 2023 at 11:04 AM Dong Lin wrote: > > > Hi all, > > > > We would like to start the vote for FLIP-289: Support online inference > > (Flink ML) [1]. This FLIP was discussed in

Re: [VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-13 Thread Dian Fu
+1 (binding) Regards, Dian On Mon, Feb 13, 2023 at 11:04 AM Dong Lin wrote: > Hi all, > > We would like to start the vote for FLIP-289: Support online inference > (Flink ML) [1]. This FLIP was discussed in this thread [2]. > > The goal of this FLIP is to enable users to use the model trained

[VOTE] FLIP-289: Support online inference (Flink ML)

2023-02-12 Thread Dong Lin
Hi all, We would like to start the vote for FLIP-289: Support online inference (Flink ML) [1]. This FLIP was discussed in this thread [2]. The goal of this FLIP is to enable users to use the model trained by Flink ML to do online inference. The vote will be open until at least Feb 16th (at