Thanks Dawid and everyone.
I'm hereby glad to announce that we have unanimously approved this FLIP
with 5 +1 votes, 3 binding (Timo, Jark, Dawid) and 2 non-binding (Xuefu,
Peter), and no -1.
This FLIP shall move to implementation phase and will target for Flink 1.10.
On Fri, Oct 18, 2019 at
Thank you Bowen for the update. Great to hear we can have just
ModuleFactory#createModule(Map)
+1 for the FLIP. Nice design BTW ;)
Best,
Dawid
On 17/10/2019 18:36, Bowen Li wrote:
> Thanks for pointing them out, Dawid. I've went over the overall doc again
> and corrected the above typos.
>
>
Thanks for pointing them out, Dawid. I've went over the overall doc again
and corrected the above typos.
- ModuleManager#listFunctions() returns Set
- ModuleManager holds a LinkedHashMap to keep loaded
modules in order
- ModuleFactory#createModule(Map) and returns Module
On Thu, Oct 17, 2019 at
Hi all,
Generally I'm fine with the design. Before I cast my +1 I wanted to
clarify one thing. Is the module name in ModuleFactory#createModule
necessary? Can't it be just?:
interface ModuleFactory extends TableFactory {
Module createModule(Map properties);
}
The name under which the module
+1
Thanks,
Jark
On Thu, 17 Oct 2019 at 04:44, Peter Huang
wrote:
> +1 Thanks
>
> On Wed, Oct 16, 2019 at 12:48 PM Xuefu Z wrote:
>
> > +1 (non-biding)
> >
> > On Wed, Oct 16, 2019 at 2:26 AM Timo Walther wrote:
> >
> > > +1
> > >
> > > Thanks,
> > > Timo
> > >
> > >
> > > On 15.10.19 20:50,
+1 Thanks
On Wed, Oct 16, 2019 at 12:48 PM Xuefu Z wrote:
> +1 (non-biding)
>
> On Wed, Oct 16, 2019 at 2:26 AM Timo Walther wrote:
>
> > +1
> >
> > Thanks,
> > Timo
> >
> >
> > On 15.10.19 20:50, Bowen Li wrote:
> > > Hi all,
> > >
> > > I'd like to kick off a voting thread for FLIP-68:
+1 (non-biding)
On Wed, Oct 16, 2019 at 2:26 AM Timo Walther wrote:
> +1
>
> Thanks,
> Timo
>
>
> On 15.10.19 20:50, Bowen Li wrote:
> > Hi all,
> >
> > I'd like to kick off a voting thread for FLIP-68: Extend Core Table
> System
> > with Pluggable Modules [1], as we have reached consensus in
+1
Thanks,
Timo
On 15.10.19 20:50, Bowen Li wrote:
Hi all,
I'd like to kick off a voting thread for FLIP-68: Extend Core Table System
with Pluggable Modules [1], as we have reached consensus in [2].
The voting period will be open for at least 72 hours, ending at 7pm Oct 18
UTC.
Thanks,
Hi all,
I'd like to kick off a voting thread for FLIP-68: Extend Core Table System
with Pluggable Modules [1], as we have reached consensus in [2].
The voting period will be open for at least 72 hours, ending at 7pm Oct 18
UTC.
Thanks,
Bowen
[1]
