[RESULT][VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-09 Thread Terry Wang
Hi all, The voting time for FLIP-69 has passed. I'm closing the vote now. There were seven +1 votes, 3 of which are binding: - Bowen Li (binding) - Jark Wu (binding) - Kurt Young (binding) - Xuefu Z (non-binding) - Peter Huang (non-binding) - Jingsong Li (non-binding) - Danny Chan (non-binding)

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-09 Thread Jark Wu
+1 from my side. They are useful features. Best, Jark On Fri, 8 Nov 2019 at 16:42, Danny Chan wrote: > +1(non-binding), nice job, Terry ~ > > Best, > Danny Chan > 在 2019年11月5日 +0800 PM10:32,dev@flink.apache.org,写道: > > > > +1 to the long missing feature in Flink SQL. >

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-08 Thread Danny Chan
+1(non-binding), nice job, Terry ~ Best, Danny Chan 在 2019年11月5日 +0800 PM10:32,dev@flink.apache.org,写道: > > +1 to the long missing feature in Flink SQL.

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-08 Thread Jingsong Li
Thanks Terry for driving this. +1 With these features, SQL-CLI could be really used. Best, Jingsong Lee On Fri, Nov 8, 2019 at 2:20 PM Kurt Young wrote: > Forgot to vote.. +1 from my side. > > Best, > Kurt > > > On Fri, Nov 8, 2019 at 11:00 AM Kurt Young wrote: > > > Hi all, > > > > I think we

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-07 Thread Kurt Young
Forgot to vote.. +1 from my side. Best, Kurt On Fri, Nov 8, 2019 at 11:00 AM Kurt Young wrote: > Hi all, > > I think we should focus to discuss the document in [DISCUSS] thread and > keep this vote thread purely for voting. > > Otherwise, it's hard for others to collect feedbacks for this topi

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-07 Thread Kurt Young
Hi all, I think we should focus to discuss the document in [DISCUSS] thread and keep this vote thread purely for voting. Otherwise, it's hard for others to collect feedbacks for this topic. Best, Kurt On Thu, Nov 7, 2019 at 5:51 PM Terry Wang wrote: > Hi Rui~ > What you suggested makes sense

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-07 Thread Terry Wang
Hi Rui~ What you suggested makes sense, remove description and detailed description from `DESCRIBE DATABASE`. Open to more comments and votes :) Best, Terry Wang > 2019年11月7日 17:15,Rui Li 写道: > > I see, thanks for the clarification. In current implementation, it seems > just a duplicate of c

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-07 Thread Rui Li
I see, thanks for the clarification. In current implementation, it seems just a duplicate of comment. So I'd prefer not to display it for DESCRIBE DATABASE, because 1) users have no control over the content and 2) it's totally redundant. We can add it in the future when we come up with something mo

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-06 Thread Terry Wang
Hi Rui~ Description of the database is obtained from `CatalogDatabase#getDescription()` method, which is implement by CatalogDatebaseImpl. Users don’t need to specify the description. Best, Terry Wang > 2019年11月7日 15:40,Rui Li 写道: > > Thanks Terry for driving this forward. > Got one questi

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-06 Thread Rui Li
Thanks Terry for driving this forward. Got one question about DESCRIBE DATABASE: the results display comment and description of a database. While comment can be specified when a database is created, I don't see how users can specify description of the database? On Thu, Nov 7, 2019 at 4:16 AM Bowen

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-06 Thread Bowen Li
Thanks. As Terry and I discussed offline yesterday, we added a new section to explain the detailed implementation plan. +1 (binding) from me. Bowen On Tue, Nov 5, 2019 at 6:33 PM Terry Wang wrote: > Hi Bowen: > Thanks for your feedback. > Your opinion convinced me and I just remove the sectio

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-05 Thread Terry Wang
Hi Bowen: Thanks for your feedback. Your opinion convinced me and I just remove the section about catalog create statement and also remove `DBPROPERTIES` `PROPERTIES` from alter DDLs. Open to more comments or votes :) ! Best, Terry Wang > 2019年11月6日 07:22,Bowen Li 写道: > > Hi Terry, > > I w

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-05 Thread Bowen Li
Hi Terry, I went over the FLIP in detail again. The FLIP mostly LGTM. A couple issues: - since we on't plan to support catalog ddl, can you remove them from the FLIP? - I found there are some discrepancies in proposed database and table DDLs. For db ddl, the create db syntax proposes specifying

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-05 Thread Peter Huang
+1 for the enhancement. On Tue, Nov 5, 2019 at 11:04 AM Xuefu Z wrote: > +1 to the long missing feature in Flink SQL. > > On Tue, Nov 5, 2019 at 6:32 AM Terry Wang wrote: > > > Hi all, > > > > I would like to start the vote for FLIP-69[1] which is discussed and > > reached consensus in the disc

Re: [VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-05 Thread Xuefu Z
+1 to the long missing feature in Flink SQL. On Tue, Nov 5, 2019 at 6:32 AM Terry Wang wrote: > Hi all, > > I would like to start the vote for FLIP-69[1] which is discussed and > reached consensus in the discussion thread[2]. > > The vote will be open for at least 72 hours. I'll try to close it

[VOTE] FLIP-69: Flink SQL DDL Enhancement

2019-11-05 Thread Terry Wang
Hi all, I would like to start the vote for FLIP-69[1] which is discussed and reached consensus in the discussion thread[2]. The vote will be open for at least 72 hours. I'll try to close it by 2019-11-08 14:30 UTC, unless there is an objection or not enough votes. [1] https://cwiki.apache.org