Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-22 Thread Till Rohrmann
I think the oshi-core test dependency in flink-tests is ok because we don't include the oshi-core binary in any of our published binaries (neither the flink-tests_2.11-1.8-SNAPSHOT.jar nor the convenience tarballs contain oshi-core classes). Linking against EPL 1.0 binaries should be ok.

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-22 Thread jincheng sun
Hi Hequn, Thanks for check the test, +1 this not a blocker of the release. and I'll merge your PR. Best, Jincheng Hequn Cheng 于2018年11月22日周四 下午4:35写道: > Hi, > > I'm trying to check if the source release is building properly. And found > that NonHAQueryableStateFsBackendITCase failed when run

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-22 Thread Hequn Cheng
Hi, I'm trying to check if the source release is building properly. And found that NonHAQueryableStateFsBackendITCase failed when run `mvn install`. This should not be a release blocker, however, I ceated a pr[1] to make it more stable. Best, Hequn [1]

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-21 Thread Till Rohrmann
Thanks Chesnay for going through the release notes. I've updated them accordingly. Concerning the test dependency and the LICENSE/NOTICE files, I'm looking into it and will report back. Cheers, Till On Wed, Nov 21, 2018 at 3:46 PM Chesnay Schepler wrote: > Our LICENSE/NOTICE files in the

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-21 Thread Chesnay Schepler
Our LICENSE/NOTICE files in the binary distribution may also be botched (and may have been for quite some time). As per http://www.apache.org/dev/licensing-howto.html#binary "|[...] LICENSE| and |NOTICE| must *exactly* represent the contents of the distribution they reside in.", which also

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-21 Thread Chesnay Schepler
I may have found a potential blocker while looking at dependencies: flink-tests now has a non-optional test dependency on oshi-core, which is licensed under EPL 1.0. As per https://issues.apache.org/jira/browse/LEGAL-207, test dependencies are not exempt from license restrictions. We thus

Re: [VOTE] Release 1.7.0, release candidate #2

2018-11-21 Thread Chesnay Schepler
I looked through the release notes: Entries that shouldn't be included: * [FLINK-9983] - Savepoints should count as checkpoints when recovering o duplicate of FLINK-1035 * [FLINK-10714] - java.lang.IndexOutOfBoundsException when creating a heap backend snapshot o closed as "Not a

[VOTE] Release 1.7.0, release candidate #2

2018-11-20 Thread Till Rohrmann
Hi everyone, Please review and vote on the release candidate #2 for the version 1.7.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) The complete staging area is available for your review, which includes: * JIRA release notes [1], *