This vote is now closed due to the Flink version error in the pom reported
by Leonard.
Thanks all.
On Thu, Nov 9, 2023 at 3:19 PM Martijn Visser
wrote:
> I agree with Leonard. We should also not update 1.16.0 to 1.18.0, but
> to the lowest supported Flink version of this release (in this case,
I agree with Leonard. We should also not update 1.16.0 to 1.18.0, but
to the lowest supported Flink version of this release (in this case,
1.17.0)
On Thu, Nov 9, 2023 at 3:08 AM Leonard Xu wrote:
>
> Thanks Danny for the reply.
>
> -1 (binding)
>
> Let’s fix the outdated version in the source
Thanks Danny for the reply.
-1 (binding)
Let’s fix the outdated version in the source code and spin a new rc2.
I’d like to open a PR to fix it, and hope everything OK in your Flink Forward
Trip.
Best,
Leonard
> Thanks for helping to verify the release. The 1.16.0 Flink version in the
>
Hey Leonard,
Thanks for helping to verify the release. The 1.16.0 Flink version in the
pom is a miss, ideally it should be updated to 1.18.0, additionally this
should have been updated to 1.17.x previously. I would not consider it a
hard blocker since the Maven build overrides this variable based
Thanks Danny for driving this. I'm considering -1, please correct me if I
understand wrong.
>> * The sources can be compiled and unit tests pass with flink.version 1.17.1
>> and flink.version 1.18.0
>>
>> * Nexus has two staged artifact ids for 3.0.2-1.17 and 3.0.2-1.18
>> -
+1(non-binding)
- Checked release notes
- Verified checksums and signatures
- Verified no binaries in release
- Build connector from source
Bests,
Samrat
On Mon, 6 Nov 2023 at 8:20 PM, Ryan Skraba
wrote:
> Hello! +1 (non-binding)
>
> One note: the parent pom still has 1.16.0 for the Maven
Hello! +1 (non-binding)
One note: the parent pom still has 1.16.0 for the Maven property of
flink.version for both 1.17 and 1.18 releases.
I've validated the source for the RC1:
flink-connector-gcp-pubsub-3.0.2-src.tgz at r65060
* The sha512 checksum is OK.
* The source file is signed correctly.
+1(non-binding)
-Checked release notes
- Verified checksums and signatures
- Verified no binaries in release
- Build connector from source
- Reviewed web PR.
Best Regards
Ahmed Hamdy
On Fri, 3 Nov 2023 at 11:23, Danny Cranmer wrote:
> Hi everyone,
>
> Please review and vote on the release
Hi everyone,
Please review and vote on the release candidate #1 for the version 3.0.2 of
flink-connector-pubsub, as follows:
[ ] +1, Approve the release
[ ] -1, Do not approve the release (please provide specific comments)
The complete staging area is available for your review, which includes:
*
