Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-05-05 Thread Danny Cranmer
Thanks all, this vote is now closed. I will announce the results in a separate thread. Danny On Thu, May 4, 2023 at 4:54 AM Leonard Xu wrote: > +1 (binding) > > - built from source code succeeded > - verified signatures > - verified hashsums > - checked Github release tag > - checked release

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-05-03 Thread Leonard Xu
+1 (binding) - built from source code succeeded - verified signatures - verified hashsums - checked Github release tag - checked release notes - reviewed the web PR - found the JDBC docs contains a valid link, reopened FLINK-31759[1] to fix it, not a blocker Best, Leonard

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-05-02 Thread Danny Cranmer
+1 (binding) - Release notes look good - Source archive signature and checksums good - Verified there are no binaries in the source archive - Contents of Maven repo look good - Built from source/tests pass - Tag is present in Github - Fixed web PR as per feedback Thanks, Danny On Wed, Apr 19,

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-19 Thread Martijn Visser
+1 (binding) - Validated hashes - Verified signature - Verified that no binaries exist in the source archive - Build the source with Maven - Verified licenses - Verified web PRs On Wed, Apr 19, 2023 at 9:35 AM Martijn Visser wrote: > Hi all, > > There was already a blocker ticken op for this,

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-19 Thread Martijn Visser
Hi all, There was already a blocker ticken op for this, that's https://issues.apache.org/jira/browse/FLINK-31770. There's also an open PR that should resolve it, but is waiting on a reviewer. See https://github.com/apache/flink-connector-jdbc/pull/22 I've already done the administration, so this

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-19 Thread Danny Cranmer
Thank Benchao for the hotfix. I noticed the CI is also failing/flaky for the main branch, I have raised a follow-up [1]. Danny, [1] https://issues.apache.org/jira/browse/FLINK-31847 On Sun, Apr 16, 2023 at 10:57 AM Benchao Li wrote: > And I've filed a hotfix PR[1] to fix the copyright issue.

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-16 Thread Benchao Li
And I've filed a hotfix PR[1] to fix the copyright issue. [1] https://github.com/apache/flink-connector-jdbc/pull/41 Benchao Li 于2023年4月16日周日 17:51写道: > * Verified hashes, signatures (OK) > * Download, build and test source code (OK) > * Checked files in Nexus staging (OK) > * Start a Flink

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-16 Thread Benchao Li
* Verified hashes, signatures (OK) * Download, build and test source code (OK) * Checked files in Nexus staging (OK) * Start a Flink local cluster (1.17.0), run sql-client with jdbc connector jar with Mysql 8.0.28 (OK) * Go through the release note (OK) One thing I spotted is that when I checked

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-14 Thread Teoh, Hong
Thanks Danny +1 (non-binding) * Hashes and Signatures look good * All required files on dist.apache.org * Tag is present in Github * Verified source archive does not contain any binary files * Source archive builds using maven Cheers, Hong > On 14 Apr 2023, at 05:21, Elphas Toringepi wrote:

Re: [VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-13 Thread Elphas Toringepi
+1 (non-binding) * JIRA release notes look good * Verified signature and checksum for Apache source * Checked source code tag and confirmed Github and Apache source releases are identical * Reviewed website pull request and left comment Kind regards, Elphas On Thu, Apr 13, 2023 at 3:42 PM

[VOTE] Release flink-connector-jdbc v3.1.0, release candidate #1

2023-04-13 Thread Danny Cranmer
Hi everyone, Please review and vote on the release candidate #1 for the version v3.1.0, as follows: [ ] +1, Approve the release [ ] -1, Do not approve the release (please provide specific comments) This version supports both Flink 1.16.x and Flink 1.17.x The complete staging area is available